Code Review for MinGW_MSYS_hotspot

Prepared by:Volker H. Simonis on Thu Mar 8 18:26:11 CET 2012
Contributed by:volker.simonis@gmail.com
Workspace:/share/software/Java/OpenJDK/jdk8_build/hotspot
Compare against: http://hg.openjdk.java.net/jdk8/build/hotspot
Compare against version:3160
Summary of changes: 45 lines changed: 11 ins; 0 del; 34 mod; 444 unchg
Patch of changes: MinGW_MSYS_hotspot.patch
Author comments:

This is the hotspot repository part of the "Enable OpenJDK builds on Windows with MinGW/MSYS" patch. The change only touches Windows make files so it should have no effect for other platforms.

I tested full OpenJDK 8 product and debug builds on Windows with MKS, Cygwin and MinGW/MSYS. To avoid regressions I also did product and debug builds on Solaris10/amd64 without any problems.

The patch mainly replaces forward slash style options (e.g. /NOLOG) for calls to Windows programs with their corresponding dash form (e.g -NOLOG) and backslash path separators with forward path separators (or prevents the replacement of forward path separators with backslash path separators if this was not necessary).

Note that this change is minimal in the sense that I only did "just enough" changes to be able to build on Windows with either one of the three Unix emulation environments (MKS, Cygwin, MinGW/MSYS).

Particularly I haven't done the above changes in the nmake make files although this would have been possible. I'm very much in favor of completely removing the special nmake make files and do the complete build with GNU make. Besides the fact that this unifies the makefiles and removes yet another dependency from the build, this will also allow to take advantage of parallel HotSpot makes as this is currently done under Linux and which is much faster on recent multi-core hardware than the nmake batch build mode. As noted, these improvements are left for a future change.

Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/windows/makefiles/defs.make

rev 3161 : Enable OpenJDK builds on Windows with MinGW/MSYS
16 lines changed: 11 ins; 0 del; 5 mod; 199 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/windows/makefiles/rules.make

rev 3161 : Enable OpenJDK builds on Windows with MinGW/MSYS
6 lines changed: 0 ins; 0 del; 6 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/windows/makefiles/sa.make

rev 3161 : Enable OpenJDK builds on Windows with MinGW/MSYS
22 lines changed: 0 ins; 0 del; 22 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/windows/makefiles/shared.make

rev 3161 : Enable OpenJDK builds on Windows with MinGW/MSYS
1 line changed: 0 ins; 0 del; 1 mod; 69 unchg

This code review page was prepared using /sapmnt/home1/d046063/webrev.ksh (vers 23.18-hg).