Code Review for jdk9-dev

Prepared by:simonis on Tue Aug 5 19:51:15 CEST 2014
Workspace:/net/usr.work/d046063/OpenJDK/jdk9-dev
Compare against: http://hg.openjdk.java.net/jdk9/dev
Compare against version:1118
Summary of changes: 1025 lines changed: 795 ins; 197 del; 33 mod; 53720 unchg
Changeset: jdk9-dev.changeset
Bug id: JDK-8022177 : Windows/MSYS builds broken
Author comments:

common/autoconf/basics.m4

  • Check for bsdcpio if cpio is not found. Also make the check for cpio optional, as suggested in the bug report.
  • Only do the BASIC_CHECK_SRC_PERMS check on Cygwin as it only seems to be relavant there and because the stat utility isn't availabel in MSYS anyway.

common/autoconf/basics_windows.m4

  • Same story like on Cygwin: '.bat' and '.cmd' files are not always considered executable in MSYS causing which to not find them.

common/autoconf/flags.m4

  • Use "-WX" option syntax for cl options (instead of "/WX") to prevent option rewriting by MSYS.

toolchain_windows.m4

  • Account for the fact that the MSYS file utility reports different file types for Windows DLLs than its Cygwin counterpart.
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw common/autoconf/basics.m4 

rev 1119 : 8022177: Windows/MSYS builds broken
3 lines changed: 1 ins; 1 del; 1 mod; 958 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw common/autoconf/basics_windows.m4 

rev 1119 : 8022177: Windows/MSYS builds broken
8 lines changed: 8 ins; 0 del; 0 mod; 420 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw common/autoconf/flags.m4 

rev 1119 : 8022177: Windows/MSYS builds broken
1 line changed: 0 ins; 0 del; 1 mod; 918 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw common/autoconf/generated-configure.sh

999 lines changed: 776 ins; 196 del; 27 mod; 51084 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw common/autoconf/toolchain_windows.m4 

rev 1119 : 8022177: Windows/MSYS builds broken
14 lines changed: 10 ins; 0 del; 4 mod; 340 unchg

This code review page was prepared using /usr/work/d046063/OpenJDK/webrev/webrev.ksh (vers 25.2-hg+openjdk.java.net).