Code Review for jdk

Prepared by:simonis on Mon Jun 24 19:15:35 CEST 2013
Summary of changes: 49 lines changed: 42 ins; 3 del; 4 mod; 4071 unchg
Patch of changes: jdk.patch
Author comments:


Remove mapfile from build instructions of BUILD_UNPACKEXE:

  CFLAGS_macosx:=-fPIC, \
- MAPFILE:=$(JDK_TOPDIR)/makefiles/mapfiles/libunpack/mapfile-vers-unpack200,\

I think it makes no sense to use a version script file for an executable and older linkers (e.g. on SLES 10) complain with: "Invalid version tag `SUNWprivate_1.1'. Only anonymous version tag is allowed in executable." The GNU ld manualstates: "Version scripts are only meaningful when creating shared libraries." Morover unpack200 was the only executable which used a version script file.

Fix typo (replace 'defalt: all' by 'default')

default: all


Only use $(OPENWIN_LIB) for linking LIBSPLASHSCREEN on Solaris! The old code worked only accidentally when the X-libraries are in the default linker path anyway. The right solution is to use $(X_LIBS) if not on Windows or Solaris.

Append -DX_ARCH=X_PPC64 to LIBJSOUND_CFLAGS on PPC64. The value of X_ARCH isn't actually used on the PPC architectures, but there's a check to verify that it is set.

Fix typo (replace 'defalt: all' by 'default')

default: all
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw makefiles/CompileLaunchers.gmk

2 lines changed: 0 ins; 1 del; 1 mod; 632 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw makefiles/CompileNativeLibraries.gmk

14 lines changed: 9 ins; 2 del; 3 mod; 3439 unchg

------ ------ ------ ------ --- New Patch Raw src/solaris/bin/ppc64/jvm.cfg

33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../make/scripts/webrev.ksh (vers 24.0-hg+jbs).