Code Review for hs-rt9

Prepared by:sjiang on Tue Mar 31 19:37:57 CEST 2015
Workspace:/Users/sjiang/projects/jdk/workspace/fix/hs-rt9
Summary of changes: 1734 lines changed: 1080 ins; 397 del; 257 mod; 21360 unchg
Patch of changes: hs-rt9.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw common/bin/unshuffle_list.txt

3 lines changed: 1 ins; 1 del; 1 mod; 1497 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/Images.gmk

1 line changed: 0 ins; 0 del; 1 mod; 538 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules.xml

14 lines changed: 11 ins; 3 del; 0 mod; 1852 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/classfile/vmSymbols.hpp

6 lines changed: 0 ins; 1 del; 5 mod; 1266 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/services/diagnosticFramework.cpp

8 lines changed: 0 ins; 3 del; 5 mod; 569 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/services/gcNotifier.cpp

4 lines changed: 1 ins; 1 del; 2 mod; 241 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/services/management.cpp

30 lines changed: 4 ins; 13 del; 13 mod; 2322 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/services/management.hpp

32 lines changed: 16 ins; 10 del; 6 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/services/memoryManager.cpp

12 lines changed: 9 ins; 1 del; 2 mod; 320 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/services/memoryPool.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 313 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/gc/TestSmallHeap.java

7 lines changed: 5 ins; 1 del; 1 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/gc/arguments/TestG1HeapRegionSize.java

5 lines changed: 2 ins; 1 del; 2 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/gc/arguments/TestUseCompressedOopsErgoTools.java

5 lines changed: 2 ins; 1 del; 2 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/gc/g1/TestHumongousShrinkHeap.java

7 lines changed: 3 ins; 1 del; 3 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/gc/g1/TestShrinkDefragmentedHeap.java

7 lines changed: 3 ins; 1 del; 3 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/gc/g1/TestSummarizeRSetStatsTools.java

7 lines changed: 1 ins; 3 del; 3 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/gc/parallelScavenge/TestDynShrinkHeap.java

6 lines changed: 3 ins; 1 del; 2 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/make/lib/Lib-java.management.gmk

13 lines changed: 0 ins; 12 del; 1 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/make/mapfiles/libmanagement/mapfile-vers

30 lines changed: 0 ins; 27 del; 3 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/make/src/classes/build/tools/module/boot.modules

1 line changed: 1 ins; 0 del; 0 mod; 30 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management/share/classes/java/lang/management/DefaultPlatformMBeanProvider.java

36 lines changed: 0 ins; 35 del; 1 mod; 467 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management/share/classes/java/lang/management/ManagementFactory.java

9 lines changed: 7 ins; 0 del; 2 mod; 971 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management/share/classes/sun/management/GarbageCollectorImpl.java

147 lines changed: 2 ins; 139 del; 6 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management/share/classes/sun/management/LazyCompositeData.java

5 lines changed: 0 ins; 0 del; 5 mod; 191 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management/share/classes/sun/management/ManagementFactoryHelper.java

78 lines changed: 26 ins; 47 del; 5 mod; 422 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management/share/classes/sun/management/MappedMXBeanType.java

71 lines changed: 37 ins; 6 del; 28 mod; 827 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management/share/classes/sun/management/NotificationEmitterSupport.java

5 lines changed: 0 ins; 1 del; 4 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management/share/classes/sun/management/ThreadImpl.java

41 lines changed: 31 ins; 0 del; 10 mod; 466 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management/share/classes/sun/management/Util.java

2 lines changed: 0 ins; 0 del; 2 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management/share/classes/sun/management/spi/PlatformMBeanProvider.java

2 lines changed: 0 ins; 0 del; 2 mod; 231 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management/share/native/libmanagement/GarbageCollectorImpl.c

14 lines changed: 0 ins; 14 del; 0 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/java/lang/instrument/NMTHelper.java

11 lines changed: 7 ins; 0 del; 4 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/java/lang/instrument/RedefineMethodInBacktraceApp.java

8 lines changed: 4 ins; 0 del; 4 mod; 192 unchg

------ ------ ------ ------ Old --- Patch --- jdk/src/java.management/share/classes/sun/management/ManagementFactory.java

55 lines changed: 0 ins; 55 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/make/lib/Lib-jdk.management.gmk

81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/make/mapfiles/libmanagement_ext/mapfile-vers

60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/linux/native/libmanagement_ext/UnixOperatingSystem.c (was jdk/src/java.management/unix/native/libmanagement/LinuxOperatingSystem.c)

4 lines changed: 0 ins; 0 del; 4 mod; 329 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/macosx/native/libmanagement_ext/UnixOperatingSystem.c (was jdk/src/java.management/unix/native/libmanagement/MacosxOperatingSystem.c)

4 lines changed: 0 ins; 0 del; 4 mod; 157 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.management/share/classes/META-INF/services/sun.management.spi.PlatformMBeanProvider (was jdk/src/java.management/share/classes/META-INF/services/sun.management.spi.PlatformMBeanProvider)

0 lines changed: 0 ins; 0 del; 0 mod; 25 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/DiagnosticCommandMBean.java (was jdk/src/java.management/share/classes/com/sun/management/DiagnosticCommandMBean.java)

0 lines changed: 0 ins; 0 del; 0 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/GarbageCollectionNotificationInfo.java (was jdk/src/java.management/share/classes/com/sun/management/GarbageCollectionNotificationInfo.java)

5 lines changed: 0 ins; 3 del; 2 mod; 233 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/GarbageCollectorMXBean.java (was jdk/src/java.management/share/classes/com/sun/management/GarbageCollectorMXBean.java)

0 lines changed: 0 ins; 0 del; 0 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/GcInfo.java (was jdk/src/java.management/share/classes/com/sun/management/GcInfo.java)

4 lines changed: 0 ins; 1 del; 3 mod; 285 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java (was jdk/src/java.management/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java)

0 lines changed: 0 ins; 0 del; 0 mod; 119 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/OperatingSystemMXBean.java (was jdk/src/java.management/share/classes/com/sun/management/OperatingSystemMXBean.java)

0 lines changed: 0 ins; 0 del; 0 mod; 131 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/ThreadMXBean.java (was jdk/src/java.management/share/classes/com/sun/management/ThreadMXBean.java)

0 lines changed: 0 ins; 0 del; 0 mod; 222 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/UnixOperatingSystemMXBean.java (was jdk/src/java.management/share/classes/com/sun/management/UnixOperatingSystemMXBean.java)

0 lines changed: 0 ins; 0 del; 0 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/VMOption.java (was jdk/src/java.management/share/classes/com/sun/management/VMOption.java)

6 lines changed: 3 ins; 0 del; 3 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/internal/DiagnosticCommandArgumentInfo.java (was jdk/src/java.management/share/classes/sun/management/DiagnosticCommandArgumentInfo.java)

2 lines changed: 0 ins; 0 del; 2 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/internal/DiagnosticCommandImpl.java (was jdk/src/java.management/share/classes/sun/management/DiagnosticCommandImpl.java)

36 lines changed: 31 ins; 0 del; 5 mod; 375 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/internal/DiagnosticCommandInfo.java (was jdk/src/java.management/share/classes/sun/management/DiagnosticCommandInfo.java)

3 lines changed: 1 ins; 0 del; 2 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/internal/Flag.java (was jdk/src/java.management/share/classes/sun/management/Flag.java)

2 lines changed: 0 ins; 0 del; 2 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/internal/GarbageCollectionNotifInfoCompositeData.java (was jdk/src/java.management/share/classes/sun/management/GarbageCollectionNotifInfoCompositeData.java)

8 lines changed: 3 ins; 1 del; 4 mod; 210 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/internal/GarbageCollectorExtImpl.java

181 lines changed: 181 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/internal/GcInfoBuilder.java (was jdk/src/java.management/share/classes/sun/management/GcInfoBuilder.java)

9 lines changed: 1 ins; 5 del; 3 mod; 197 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/internal/GcInfoCompositeData.java (was jdk/src/java.management/share/classes/sun/management/GcInfoCompositeData.java)

12 lines changed: 4 ins; 5 del; 3 mod; 268 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/internal/HotSpotDiagnostic.java (was jdk/src/java.management/share/classes/sun/management/HotSpotDiagnostic.java)

3 lines changed: 1 ins; 0 del; 2 mod; 141 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/internal/HotSpotThreadImpl.java

74 lines changed: 74 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/internal/PlatformMBeanProviderImpl.java (was jdk/src/java.management/share/classes/com/sun/management/internal/PlatformMBeanProviderImpl.java)

104 lines changed: 80 ins; 4 del; 20 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/internal/VMOptionCompositeData.java (was jdk/src/java.management/share/classes/sun/management/VMOptionCompositeData.java)

4 lines changed: 2 ins; 0 del; 2 mod; 131 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.management/share/classes/com/sun/management/package-info.java (was jdk/src/java.management/share/classes/com/sun/management/package-info.java)

0 lines changed: 0 ins; 0 del; 0 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/share/native/libmanagement_ext/DiagnosticCommandImpl.c (was jdk/src/java.management/share/native/libmanagement/DiagnosticCommandImpl.c)

11 lines changed: 0 ins; 0 del; 11 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/share/native/libmanagement_ext/Flag.c (was jdk/src/java.management/share/native/libmanagement/Flag.c)

12 lines changed: 0 ins; 0 del; 12 mod; 224 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.management/share/native/libmanagement_ext/GarbageCollectorExtImpl.c

41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c (was jdk/src/java.management/share/native/libmanagement/GcInfoBuilder.c)

7 lines changed: 0 ins; 0 del; 7 mod; 277 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/share/native/libmanagement_ext/HotSpotDiagnostic.c (was jdk/src/java.management/share/native/libmanagement/HotSpotDiagnostic.c)

4 lines changed: 0 ins; 0 del; 4 mod; 32 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.management/share/native/libmanagement_ext/management_ext.c

61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.management/share/native/libmanagement_ext/management_ext.h

38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/solaris/native/libmanagement_ext/UnixOperatingSystem.c (was jdk/src/java.management/unix/native/libmanagement/SolarisOperatingSystem.c)

4 lines changed: 0 ins; 0 del; 4 mod; 237 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/unix/classes/com/sun/management/internal/OperatingSystemImpl.java (was jdk/src/java.management/unix/classes/sun/management/OperatingSystemImpl.java)

4 lines changed: 2 ins; 0 del; 2 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/unix/native/libmanagement_ext/OperatingSystemImpl.c (was jdk/src/java.management/unix/native/libmanagement/OperatingSystemImpl.c)

12 lines changed: 0 ins; 0 del; 12 mod; 467 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/windows/classes/com/sun/management/internal/OperatingSystemImpl.java (was jdk/src/java.management/windows/classes/sun/management/OperatingSystemImpl.java)

12 lines changed: 10 ins; 0 del; 2 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management/windows/native/libmanagement_ext/OperatingSystemImpl.c (was jdk/src/java.management/windows/native/libmanagement/OperatingSystemImpl.c)

12 lines changed: 0 ins; 0 del; 12 mod; 1351 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/com/sun/management/CheckSomeMXBeanImplPackage.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/com/sun/management/VMOptionOpenDataTest.java

76 lines changed: 76 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/sun/management/PlatformMBeanProviderConstructorCheck.java

82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../webrev/webrev.ksh (vers 25.6-hg+openjdk.java.net).