Code Review for jdk-s1

Prepared by:smarks on Wed Feb 23 19:50:20 PST 2011
Workspace:/home/smarks/src/jdk-s1
Compare against version:qparent
Summary of changes: 729 lines changed: 108 ins; 146 del; 475 mod; 12269 unchg
Patch of changes: jdk-s1.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/util/jar/pack/BandStructure.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
27 lines changed: 5 ins; 5 del; 17 mod; 2660 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/util/jar/pack/Driver.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
13 lines changed: 2 ins; 5 del; 6 mod; 717 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
3 lines changed: 0 ins; 0 del; 3 mod; 319 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/util/jar/pack/PackageReader.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
26 lines changed: 4 ins; 3 del; 19 mod; 2181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
31 lines changed: 2 ins; 1 del; 28 mod; 1589 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/util/jar/pack/PropMap.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
24 lines changed: 5 ins; 5 del; 14 mod; 322 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
3 lines changed: 1 ins; 0 del; 2 mod; 278 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/util/jar/pack/Utils.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
6 lines changed: 0 ins; 0 del; 6 mod; 338 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/jar/JarFile.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
7 lines changed: 0 ins; 0 del; 7 mod; 729 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/jar/JarEntry/GetMethodsReturnClones.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
18 lines changed: 5 ins; 6 del; 7 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/jar/JarFile/ScanSignedJar.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
25 lines changed: 10 ins; 10 del; 5 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/Available.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
5 lines changed: 1 ins; 1 del; 3 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/FileBuilder.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
18 lines changed: 0 ins; 1 del; 17 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/GZIP/Accordion.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
6 lines changed: 0 ins; 4 del; 2 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/GZIP/GZIPInputStreamRead.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
24 lines changed: 2 ins; 1 del; 21 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/InflateIn_DeflateOut.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
4 lines changed: 1 ins; 1 del; 2 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/InfoZip.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
25 lines changed: 1 ins; 5 del; 19 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/LargeZip.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
47 lines changed: 12 ins; 8 del; 27 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/TestEmptyZip.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
28 lines changed: 0 ins; 18 del; 10 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/ZipCoding.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
43 lines changed: 2 ins; 3 del; 38 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/ZipFile/Assortment.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
7 lines changed: 0 ins; 1 del; 6 mod; 239 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/ZipFile/Comment.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
28 lines changed: 2 ins; 3 del; 23 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/ZipFile/CopyJar.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
14 lines changed: 2 ins; 2 del; 10 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/ZipFile/CorruptedZipFiles.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
18 lines changed: 1 ins; 7 del; 10 mod; 225 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/ZipFile/DeleteTempJar.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
25 lines changed: 5 ins; 5 del; 15 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/ZipFile/EnumAfterClose.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
6 lines changed: 2 ins; 0 del; 4 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/ZipFile/GetDirEntry.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
7 lines changed: 1 ins; 1 del; 5 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/ZipFile/LargeZipFile.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
46 lines changed: 7 ins; 8 del; 31 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/ZipFile/ManyEntries.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
13 lines changed: 0 ins; 7 del; 6 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/ZipFile/ManyZipFiles.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
15 lines changed: 1 ins; 0 del; 14 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/ZipFile/ReadAfterClose.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
7 lines changed: 3 ins; 0 del; 4 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/ZipFile/ReadZip.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
65 lines changed: 17 ins; 23 del; 25 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/ZipFile/ShortRead.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
23 lines changed: 3 ins; 1 del; 19 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/zip/zip.java

rev 3516 : 7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: XXX
72 lines changed: 11 ins; 11 del; 50 mod; 682 unchg

This code review page was prepared using /home/smarks/bin/webrev (vers 23.18-hg).