# HG changeset patch # User smarks # Date 1387905400 28800 # Node ID 4d6f45069679ea573835cf25cc7a8781f9051b2e # Parent eaa533e9778a2aa892884e5d4b2e03affb735bab 8007256: RMI testlibrary cleanup: remove JavaVMCallbackHandler Reviewed-by: XXX diff --git a/test/java/rmi/testlibrary/JavaVM.java b/test/java/rmi/testlibrary/JavaVM.java --- a/test/java/rmi/testlibrary/JavaVM.java +++ b/test/java/rmi/testlibrary/JavaVM.java @@ -59,9 +59,6 @@ } } - public JavaVM(String classname) { - this.classname = classname; - } public JavaVM(String classname, String options, String args) { this.classname = classname; @@ -110,15 +107,6 @@ return TestLibrary.getExtraProperty("jcov.options",""); } - public void start(Runnable runnable) throws IOException { - if (runnable == null) { - throw new NullPointerException("Runnable cannot be null."); - } - - start(); - new JavaVMCallbackHandler(runnable).start(); - } - /** * Exec the VM as specified in this object's constructor. */ @@ -176,7 +164,7 @@ */ public int waitFor() throws InterruptedException { if (vm == null) - throw new IllegalStateException("can't wait for JavaVM that hasn't started"); + throw new IllegalStateException("can't wait for JavaVM that isn't running"); int status = vm.waitFor(); outPipe.join(); @@ -191,35 +179,4 @@ start(); return waitFor(); } - - /** - * Handles calling the callback. - */ - private class JavaVMCallbackHandler extends Thread { - Runnable runnable; - - JavaVMCallbackHandler(Runnable runnable) { - this.runnable = runnable; - } - - - /** - * Wait for the Process to terminate and notify the callback. - */ - @Override - public void run() { - if (vm != null) { - try { - vm.waitFor(); - } catch(InterruptedException ie) { - // Restore the interrupted status - Thread.currentThread().interrupt(); - } - } - - if (runnable != null) { - runnable.run(); - } - } - } }