Code Review for jdk

Prepared by:smarks on Tue Dec 1 18:30:12 PST 2015
Workspace:/Users/src/jdk-dev/jdk9-sandbox/jdk
Compare against: ssh://hg.openjdk.java.net/jdk9/sandbox/jdk
Compare against version:base
Branch:JEP-269-api-branch
Summary of changes: 2299 lines changed: 2292 ins; 0 del; 7 mod; 3795 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/List.java

rev 14015 : Remove words implying creation; add value-based disclaimers; add
ordering specification for List; add non-ordering disclaimer for
Set and Map; Map.entry() non serializable; clarify immutability;
other cleanups.
330 lines changed: 330 ins; 0 del; 0 mod; 734 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/Map.java

rev 14015 : Remove words implying creation; add value-based disclaimers; add
ordering specification for List; add non-ordering disclaimer for
Set and Map; Map.entry() non serializable; clarify immutability;
other cleanups.
479 lines changed: 479 ins; 0 del; 0 mod; 1236 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/Set.java

rev 14015 : Remove words implying creation; add value-based disclaimers; add
ordering specification for List; add non-ordering disclaimer for
Set and Map; Map.entry() non serializable; clarify immutability;
other cleanups.
359 lines changed: 359 ins; 0 del; 0 mod; 413 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Collection/MOAT.java

rev 13824 : Remove factories from concrete collections. Increase counts to 10.
116 lines changed: 109 ins; 0 del; 7 mod; 1412 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/util/KeyValueHolder.java

rev 14014 : Add note on final KeyValueHolder.
126 lines changed: 126 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/util/Collection/SetFactories.java

rev 13828 : Defensive copy of List varargs array; additional null checking and tests. (Hixson)
275 lines changed: 275 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/util/List/ListFactories.java

rev 13828 : Defensive copy of List varargs array; additional null checking and tests. (Hixson)
234 lines changed: 234 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/util/Map/MapFactories.java

rev 14015 : Remove words implying creation; add value-based disclaimers; add
ordering specification for List; add non-ordering disclaimer for
Set and Map; Map.entry() non serializable; clarify immutability;
other cleanups.
380 lines changed: 380 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /Users/src/jdk-dev/code-tools/webrev/webrev.ksh (vers 25.10-hg+openjdk.java.net).