Code Review for hs-gc

Prepared by:stefank on Wed Apr 9 14:17:44 CEST 2014
Workspace:/home/stefank/hg/hs-gc
Compare against version:-2
Summary of changes: 101 lines changed: 14 ins; 0 del; 87 mod; 42658 unchg
Patch of changes: hs-gc.patch
Bug id: JDK-8039743 : Use correct format specifier to print size_t values and pointers in the GC code
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
8 lines changed: 1 ins; 0 del; 7 mod; 3005 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
13 lines changed: 0 ins; 0 del; 13 mod; 9524 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/concurrentMarkSweep/promotionInfo.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
1 line changed: 0 ins; 0 del; 1 mod; 362 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/concurrentMark.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
4 lines changed: 0 ins; 0 del; 4 mod; 4693 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
1 line changed: 0 ins; 0 del; 1 mod; 6926 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
6 lines changed: 2 ins; 0 del; 4 mod; 1341 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/survRateGroup.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
7 lines changed: 2 ins; 0 del; 5 mod; 237 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/parallelScavenge/adjoiningGenerations.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
3 lines changed: 1 ins; 0 del; 2 mod; 281 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/parallelScavenge/asPSOldGen.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
8 lines changed: 0 ins; 0 del; 8 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/parallelScavenge/asPSYoungGen.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
4 lines changed: 0 ins; 0 del; 4 mod; 544 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
1 line changed: 0 ins; 0 del; 1 mod; 1141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
2 lines changed: 0 ins; 0 del; 2 mod; 374 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
2 lines changed: 0 ins; 0 del; 2 mod; 1340 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
2 lines changed: 1 ins; 0 del; 1 mod; 685 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
4 lines changed: 1 ins; 0 del; 3 mod; 3386 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
1 line changed: 0 ins; 0 del; 1 mod; 341 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
3 lines changed: 1 ins; 0 del; 2 mod; 871 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/shared/adaptiveSizePolicy.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
5 lines changed: 0 ins; 0 del; 5 mod; 664 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/shared/allocationStats.hpp

rev 6220 : [mq]: printffmt_size.gc.patch
3 lines changed: 1 ins; 0 del; 2 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/shared/markSweep.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
1 line changed: 0 ins; 0 del; 1 mod; 171 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
3 lines changed: 2 ins; 0 del; 1 mod; 982 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/shared/parGCAllocBuffer.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
2 lines changed: 0 ins; 0 del; 2 mod; 351 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/shared/spaceDecorator.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
1 line changed: 0 ins; 0 del; 1 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/binaryTreeDictionary.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
5 lines changed: 0 ins; 0 del; 5 mod; 1406 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/defNewGeneration.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
2 lines changed: 0 ins; 0 del; 2 mod; 1090 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/generation.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
2 lines changed: 0 ins; 0 del; 2 mod; 864 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/sharedHeap.cpp

rev 6220 : [mq]: printffmt_size.gc.patch
1 line changed: 0 ins; 0 del; 1 mod; 266 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/globalDefinitions.hpp

rev 6220 : [mq]: printffmt_size.gc.patch
6 lines changed: 2 ins; 0 del; 4 mod; 1363 unchg

This code review page was prepared using ../webrev/webrev.ksh (vers 25.2-hg+openjdk.java.net).