Code Review for open

Prepared by:stefank on Wed Feb 13 16:35:08 CET 2019
Workspace:/home/stefank/hg/jdk/jdk/open
Compare against version:-2
Summary of changes: 610 lines changed: 497 ins; 71 del; 42 mod; 6959 unchg
Patch of changes: open.patch
Bug id: JDK-8218922 : SA: Enable best-effort implementation of live regions iteration for ZGC
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/vmStructs_z.cpp

1 line changed: 1 ins; 0 del; 0 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/vmStructs_z.hpp

7 lines changed: 7 ins; 0 del; 0 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zCollectedHeap.cpp

4 lines changed: 0 ins; 4 del; 0 mod; 355 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zCollectedHeap.hpp

2 lines changed: 0 ins; 2 del; 0 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vmStructs.cpp

1 line changed: 1 ins; 0 del; 0 mod; 3160 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/CompactibleFreeListSpace.java

7 lines changed: 1 ins; 0 del; 6 mod; 202 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/ConcurrentMarkSweepGeneration.java

3 lines changed: 3 ins; 0 del; 0 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/epsilon/EpsilonHeap.java

5 lines changed: 5 ins; 0 del; 0 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/G1CollectedHeap.java

11 lines changed: 10 ins; 0 del; 1 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/HeapRegion.java

4 lines changed: 1 ins; 0 del; 3 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/parallel/ImmutableSpace.java

1 line changed: 0 ins; 0 del; 1 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/parallel/MutableSpace.java

2 lines changed: 0 ins; 0 del; 2 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/parallel/ParallelScavengeHeap.java

30 lines changed: 30 ins; 0 del; 0 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/serial/DefNewGeneration.java

5 lines changed: 5 ins; 0 del; 0 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/serial/TenuredGeneration.java

4 lines changed: 4 ins; 0 del; 0 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/CollectedHeap.java

3 lines changed: 3 ins; 0 del; 0 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/ContiguousSpace.java

3 lines changed: 0 ins; 0 del; 3 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/GenCollectedHeap.java

9 lines changed: 9 ins; 0 del; 0 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/Generation.java

1 line changed: 1 ins; 0 del; 0 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/GenerationFactory.java

2 lines changed: 2 ins; 0 del; 0 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/Space.java

3 lines changed: 0 ins; 3 del; 0 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shenandoah/ShenandoahHeap.java

7 lines changed: 7 ins; 0 del; 0 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddress.java

1 line changed: 0 ins; 0 del; 1 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java

24 lines changed: 23 ins; 0 del; 1 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZCollectedHeap.java

12 lines changed: 11 ins; 1 del; 0 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZExternalBitMap.java

1 line changed: 0 ins; 0 del; 1 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZGlobals.java

6 lines changed: 6 ins; 0 del; 0 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZGlobalsForVMStructs.java

6 lines changed: 6 ins; 0 del; 0 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZOop.java

15 lines changed: 0 ins; 14 del; 1 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZPage.java

137 lines changed: 133 ins; 1 del; 3 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZPageTable.java

110 lines changed: 110 ins; 0 del; 0 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZPageTableEntry.java

9 lines changed: 8 ins; 0 del; 1 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java

69 lines changed: 5 ins; 46 del; 18 mod; 393 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/LiveRegionsClosure.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/LiveRegionsProvider.java

33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZUtils.java

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/stefank/hg/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).