Code Review for source

Prepared by:stuefe stuefe on Wed May 9 12:24:51 CEST 2018
Workspace:/shared/projects/openjdk/jdk-jdk/source
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version:50067
Summary of changes: 8240 lines changed: 4451 ins; 3620 del; 169 mod; 8182 unchg
Patch of changes: source.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/vmStructs_cms.hpp

rev 50068 : [mq]: metaspace-split
1 line changed: 0 ins; 0 del; 1 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/binaryTreeDictionary.hpp

rev 50068 : [mq]: metaspace-split
12 lines changed: 3 ins; 8 del; 1 mod; 391 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/binaryTreeDictionary.inline.hpp

rev 50068 : [mq]: metaspace-split
13 lines changed: 12 ins; 1 del; 0 mod; 1024 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/freeList.inline.hpp

rev 50068 : [mq]: metaspace-split
1 line changed: 0 ins; 1 del; 0 mod; 330 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace.cpp

rev 50068 : [mq]: metaspace-split
3732 lines changed: 90 ins; 3516 del; 126 mod; 1568 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace.hpp

rev 50068 : [mq]: metaspace-split
35 lines changed: 8 ins; 7 del; 20 mod; 445 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metaspaceCommon.cpp

rev 50068 : [mq]: metaspace-split
69 lines changed: 69 ins; 0 del; 0 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metaspaceCommon.hpp

rev 50068 : [mq]: metaspace-split
77 lines changed: 76 ins; 1 del; 0 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metaspaceStatistics.cpp

rev 50068 : [mq]: metaspace-split
1 line changed: 0 ins; 0 del; 1 mod; 277 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metaspaceStatistics.hpp

rev 50068 : [mq]: metaspace-split
2 lines changed: 1 ins; 1 del; 0 mod; 188 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vmStructs.cpp

rev 50068 : [mq]: metaspace-split
1 line changed: 0 ins; 0 del; 1 mod; 3212 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/memory/test_chunkManager.cpp

rev 50068 : [mq]: metaspace-split
33 lines changed: 29 ins; 0 del; 4 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/memory/test_metachunk.cpp

rev 50068 : [mq]: metaspace-split
3 lines changed: 2 ins; 0 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/memory/test_spaceManager.cpp

rev 50068 : [mq]: metaspace-split
40 lines changed: 36 ins; 1 del; 3 mod; 35 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/blockFreelist.cpp

rev 50068 : [mq]: metaspace-split
110 lines changed: 110 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/blockFreelist.hpp

rev 50068 : [mq]: metaspace-split
94 lines changed: 94 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkManager.cpp

rev 50068 : [mq]: metaspace-split
657 lines changed: 657 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkManager.hpp

rev 50068 : [mq]: metaspace-split
231 lines changed: 231 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/metaDebug.cpp

rev 50068 : [mq]: metaspace-split
66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/metaDebug.hpp

rev 50068 : [mq]: metaspace-split
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/metabase.hpp

rev 50068 : [mq]: metaspace-split
84 lines changed: 84 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/metablock.hpp

rev 50068 : [mq]: metaspace-split
52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metachunk.cpp (was src/hotspot/share/memory/metachunk.cpp)

rev 50068 : [mq]: metaspace-split
26 lines changed: 24 ins; 0 del; 2 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metachunk.hpp (was src/hotspot/share/memory/metachunk.hpp)

rev 50068 : [mq]: metaspace-split
102 lines changed: 9 ins; 84 del; 9 mod; 157 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/occupancyMap.cpp

rev 50068 : [mq]: metaspace-split
137 lines changed: 137 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/occupancyMap.hpp

rev 50068 : [mq]: metaspace-split
244 lines changed: 244 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/printCLDMetaspaceInfoClosure.cpp

rev 50068 : [mq]: metaspace-split
86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/printCLDMetaspaceInfoClosure.hpp

rev 50068 : [mq]: metaspace-split
62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/smallBlocks.cpp

rev 50068 : [mq]: metaspace-split
63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/smallBlocks.hpp

rev 50068 : [mq]: metaspace-split
90 lines changed: 90 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/spaceManager.cpp

rev 50068 : [mq]: metaspace-split
523 lines changed: 523 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/spaceManager.hpp

rev 50068 : [mq]: metaspace-split
235 lines changed: 235 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/virtualSpaceList.cpp

rev 50068 : [mq]: metaspace-split
388 lines changed: 388 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/virtualSpaceList.hpp

rev 50068 : [mq]: metaspace-split
152 lines changed: 152 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp

rev 50068 : [mq]: metaspace-split
599 lines changed: 599 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/virtualSpaceNode.hpp

rev 50068 : [mq]: metaspace-split
171 lines changed: 171 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../../code-tools/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).