Code Review for hotspot

Prepared by:stuefe on Mon Jul 17 12:28:00 CEST 2017
Workspace:/cygdrive/c/d031900/openjdk/jdk10-hs/source/hotspot
Compare against: http://hg.openjdk.java.net/jdk10/hs/hotspot
Compare against version:13264
Summary of changes: 814 lines changed: 307 ins; 145 del; 362 mod; 94449 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/vm_version_sparc.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
3 lines changed: 2 ins; 0 del; 1 mod; 501 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/vm_version_x86.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
3 lines changed: 2 ins; 0 del; 1 mod; 1457 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/classFileParser.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
7 lines changed: 2 ins; 0 del; 5 mod; 6155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/classLoader.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
9 lines changed: 2 ins; 0 del; 7 mod; 2045 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/classLoaderData.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
25 lines changed: 4 ins; 1 del; 20 mod; 1247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/classLoaderData.hpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
1 line changed: 0 ins; 0 del; 1 mod; 396 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/defaultMethods.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
36 lines changed: 6 ins; 0 del; 30 mod; 1058 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/dictionary.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
6 lines changed: 2 ins; 0 del; 4 mod; 564 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/loaderConstraints.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
45 lines changed: 7 ins; 11 del; 27 mod; 456 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/modules.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
14 lines changed: 3 ins; 0 del; 11 mod; 713 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/protectionDomainCache.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
8 lines changed: 3 ins; 0 del; 5 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/sharedPathsMiscInfo.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
11 lines changed: 6 ins; 2 del; 3 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/sharedPathsMiscInfo.hpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
2 lines changed: 1 ins; 0 del; 1 mod; 155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionary.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
9 lines changed: 2 ins; 0 del; 7 mod; 2908 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/verifier.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
19 lines changed: 9 ins; 0 del; 10 mod; 3066 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/nmethod.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
6 lines changed: 2 ins; 0 del; 4 mod; 2991 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/compileBroker.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
4 lines changed: 3 ins; 0 del; 1 mod; 2423 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/compileTask.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
29 lines changed: 29 ins; 0 del; 0 mod; 428 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/compileTask.hpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
22 lines changed: 0 ins; 19 del; 3 mod; 212 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc/cms/compactibleFreeListSpace.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
6 lines changed: 2 ins; 0 del; 4 mod; 2895 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc/cms/concurrentMarkSweepGeneration.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
18 lines changed: 11 ins; 0 del; 7 mod; 8137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc/cms/parNewGeneration.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
5 lines changed: 3 ins; 0 del; 2 mod; 1471 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc/cms/parOopClosures.inline.hpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
4 lines changed: 2 ins; 0 del; 2 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc/g1/g1AllocRegion.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
8 lines changed: 2 ins; 3 del; 3 mod; 305 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc/g1/g1CollectedHeap.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
6 lines changed: 1 ins; 0 del; 5 mod; 5461 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc/g1/g1GCPhaseTimes.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
12 lines changed: 2 ins; 0 del; 10 mod; 443 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc/g1/g1HeapVerifier.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
9 lines changed: 6 ins; 1 del; 2 mod; 732 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc/g1/g1RemSet.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
4 lines changed: 2 ins; 0 del; 2 mod; 827 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc/g1/heapRegion.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
12 lines changed: 7 ins; 0 del; 5 mod; 890 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc/parallel/adjoiningGenerations.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
5 lines changed: 3 ins; 0 del; 2 mod; 276 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc/parallel/gcTaskManager.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
6 lines changed: 1 ins; 1 del; 4 mod; 1068 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc/parallel/psParallelCompact.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
4 lines changed: 2 ins; 0 del; 2 mod; 3177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc/parallel/psPromotionManager.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
3 lines changed: 2 ins; 0 del; 1 mod; 511 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc/shared/collectedHeap.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
4 lines changed: 1 ins; 0 del; 3 mod; 617 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc/shared/gcTraceTime.inline.hpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
1 line changed: 0 ins; 0 del; 1 mod; 161 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/linkResolver.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
7 lines changed: 5 ins; 0 del; 2 mod; 1743 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/logging/log.hpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
10 lines changed: 0 ins; 10 del; 0 mod; 202 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/logging/logHandle.hpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
5 lines changed: 0 ins; 5 del; 0 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/logging/logStream.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
rev 13266 : [mq]: 8181917-refactor-ul-logstream-delta-to-next
83 lines changed: 78 ins; 0 del; 5 mod; 29 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/logging/logStream.hpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
75 lines changed: 23 ins; 44 del; 8 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/binaryTreeDictionary.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
2 lines changed: 1 ins; 0 del; 1 mod; 1411 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/filemap.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
4 lines changed: 1 ins; 0 del; 3 mod; 1038 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/metaspace.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
32 lines changed: 7 ins; 0 del; 25 mod; 4392 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/universe.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
15 lines changed: 4 ins; 0 del; 11 mod; 1335 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/generateOopMap.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
5 lines changed: 1 ins; 0 del; 4 mod; 2578 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/instanceKlass.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
7 lines changed: 2 ins; 0 del; 5 mod; 3675 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/klassVtable.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
38 lines changed: 7 ins; 0 del; 31 mod; 1575 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/runtime.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
5 lines changed: 3 ins; 0 del; 2 mod; 1682 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/jvmtiExport.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
6 lines changed: 0 ins; 0 del; 6 mod; 2752 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/jvmtiImpl.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
1 line changed: 0 ins; 0 del; 1 mod; 1023 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/stackwalk.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
25 lines changed: 5 ins; 0 del; 20 mod; 462 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/arguments.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
1 line changed: 0 ins; 0 del; 1 mod; 4817 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/java.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
5 lines changed: 3 ins; 0 del; 2 mod; 742 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/os.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
2 lines changed: 0 ins; 0 del; 2 mod; 1749 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/safepoint.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
5 lines changed: 3 ins; 0 del; 2 mod; 1354 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/sweeper.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
4 lines changed: 3 ins; 0 del; 1 mod; 821 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/thread.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
8 lines changed: 3 ins; 0 del; 5 mod; 4887 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/vm_operations.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
13 lines changed: 2 ins; 1 del; 10 mod; 497 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/vm_version.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
3 lines changed: 1 ins; 0 del; 2 mod; 355 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/exceptions.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
6 lines changed: 2 ins; 0 del; 4 mod; 516 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/native/logging/test_logConfiguration.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
2 lines changed: 1 ins; 0 del; 1 mod; 413 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/native/logging/test_logStream.cpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
rev 13266 : [mq]: 8181917-refactor-ul-logstream-delta-to-next
33 lines changed: 20 ins; 1 del; 12 mod; 70 unchg

------ ------ ------ ------ Old --- Patch --- src/share/vm/logging/logStream.inline.hpp

rev 13265 : imported patch 8181917-refactor-ul-logstream
46 lines changed: 0 ins; 46 del; 0 mod; 0 unchg

This code review page was prepared using ../../../code-tools/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).