Code Review for source

Prepared by:stuefe stuefe on Thu Apr 26 07:34:09 CEST 2018
Workspace:/shared/projects/openjdk/jdk-jdk/source
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version:49894
Summary of changes: 2344 lines changed: 1462 ins; 604 del; 278 mod; 13100 unchg
Changeset: source.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metachunk.hpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
4 lines changed: 3 ins; 0 del; 1 mod; 246 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metaspace.cpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
1153 lines changed: 412 ins; 495 del; 246 mod; 4602 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metaspace.hpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
137 lines changed: 71 ins; 49 del; 17 mod; 386 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/vm_operations.cpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
1 line changed: 0 ins; 0 del; 1 mod; 541 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/vm_operations.hpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
7 lines changed: 4 ins; 0 del; 3 mod; 506 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/services/diagnosticCommand.cpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
2 lines changed: 1 ins; 0 del; 1 mod; 1050 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/services/diagnosticCommand.hpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
21 lines changed: 0 ins; 21 del; 0 mod; 869 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/services/memReporter.cpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
1 line changed: 0 ins; 0 del; 1 mod; 756 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/services/memTracker.cpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
4 lines changed: 2 ins; 0 del; 2 mod; 321 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/services/nmtCommon.cpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
8 lines changed: 2 ins; 2 del; 4 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/services/virtualMemoryTracker.cpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
1 line changed: 0 ins; 0 del; 1 mod; 527 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/utilities/ostream.cpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
86 lines changed: 86 ins; 0 del; 0 mod; 1073 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/utilities/ostream.hpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
13 lines changed: 12 ins; 1 del; 0 mod; 295 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/utilities/vmError.cpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
14 lines changed: 14 ins; 0 del; 0 mod; 1721 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/TEST.ROOT 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
1 line changed: 0 ins; 0 del; 1 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/runtime/NMT/PrintNMTStatistics.java 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
4 lines changed: 4 ins; 0 del; 0 mod; 66 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/metaspaceCommon.cpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/metaspaceCommon.hpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/metaspaceDCmd.cpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
100 lines changed: 100 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/metaspaceDCmd.hpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/metaspaceStatistics.cpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
278 lines changed: 278 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/metaspaceStatistics.hpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
189 lines changed: 189 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/runtime/Metaspace/PrintMetaspaceDcmd.java 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
126 lines changed: 126 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/hotspot/share/services/metaspaceDCmd.cpp 

rev 49895 : [mq]: 8201572-improve-metaspace-reporting
36 lines changed: 0 ins; 36 del; 0 mod; 0 unchg

This code review page was prepared using ../../code-tools/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).