< prev index next >
src/hotspot/share/memory/metaspace/spaceManager.cpp
Print this page
rev 57601 : [mq]: metaspace-improvement
@@ -27,501 +27,223 @@
#include "logging/logStream.hpp"
#include "memory/metaspace/chunkManager.hpp"
#include "memory/metaspace/metachunk.hpp"
#include "memory/metaspace/metaDebug.hpp"
#include "memory/metaspace/metaspaceCommon.hpp"
+#include "memory/metaspace/metaspaceStatistics.hpp"
#include "memory/metaspace/spaceManager.hpp"
#include "memory/metaspace/virtualSpaceList.hpp"
#include "runtime/atomic.hpp"
#include "runtime/init.hpp"
#include "services/memoryService.hpp"
+#include "utilities/align.hpp"
#include "utilities/debug.hpp"
#include "utilities/globalDefinitions.hpp"
namespace metaspace {
-#define assert_counter(expected_value, real_value, msg) \
- assert( (expected_value) == (real_value), \
- "Counter mismatch (%s): expected " SIZE_FORMAT \
- ", but got: " SIZE_FORMAT ".", msg, expected_value, \
- real_value);
-
-// SpaceManager methods
-
-size_t SpaceManager::adjust_initial_chunk_size(size_t requested, bool is_class_space) {
- size_t chunk_sizes[] = {
- specialized_chunk_size(is_class_space),
- small_chunk_size(is_class_space),
- medium_chunk_size(is_class_space)
- };
-
- // Adjust up to one of the fixed chunk sizes ...
- for (size_t i = 0; i < ARRAY_SIZE(chunk_sizes); i++) {
- if (requested <= chunk_sizes[i]) {
- return chunk_sizes[i];
- }
- }
+// Given a requested allocation size, in words, returns the minimum size, in words, of an allocation from metaspace.
+// A metaspace allocation must be large enough to hold a Metablock. This is because deallocated allocations
+// are kept in the block freelist.
+static size_t get_allocation_word_size(size_t requested_word_size) {
- // ... or return the size as a humongous chunk.
- return requested;
-}
+ size_t byte_size = requested_word_size * BytesPerWord;
+ byte_size = MAX2(byte_size, sizeof(Metablock));
+ byte_size = align_up(byte_size, Metachunk::allocation_alignment_bytes);
-size_t SpaceManager::adjust_initial_chunk_size(size_t requested) const {
- return adjust_initial_chunk_size(requested, is_class());
-}
+ const size_t word_size = byte_size / BytesPerWord;
+ assert(word_size * BytesPerWord == word_size, "Size problem");
-size_t SpaceManager::get_initial_chunk_size(Metaspace::MetaspaceType type) const {
- size_t requested;
-
- if (is_class()) {
- switch (type) {
- case Metaspace::BootMetaspaceType: requested = Metaspace::first_class_chunk_word_size(); break;
- case Metaspace::UnsafeAnonymousMetaspaceType: requested = ClassSpecializedChunk; break;
- case Metaspace::ReflectionMetaspaceType: requested = ClassSpecializedChunk; break;
- default: requested = ClassSmallChunk; break;
- }
- } else {
- switch (type) {
- case Metaspace::BootMetaspaceType: requested = Metaspace::first_chunk_word_size(); break;
- case Metaspace::UnsafeAnonymousMetaspaceType: requested = SpecializedChunk; break;
- case Metaspace::ReflectionMetaspaceType: requested = SpecializedChunk; break;
- default: requested = SmallChunk; break;
- }
- }
-
- // Adjust to one of the fixed chunk sizes (unless humongous)
- const size_t adjusted = adjust_initial_chunk_size(requested);
-
- assert(adjusted != 0, "Incorrect initial chunk size. Requested: "
- SIZE_FORMAT " adjusted: " SIZE_FORMAT, requested, adjusted);
-
- return adjusted;
+ return word_size;
}
-void SpaceManager::locked_print_chunks_in_use_on(outputStream* st) const {
-
- for (ChunkIndex i = ZeroIndex; i < NumberOfInUseLists; i = next_chunk_index(i)) {
- st->print("SpaceManager: " UINTX_FORMAT " %s chunks.",
- num_chunks_by_type(i), chunk_size_name(i));
- }
+// Given a requested word size, will allocate a chunk large enough to at least fit that
+// size, but may be larger according to the rules in the ChunkAllocSequence.
+// Updates counters and adds the chunk to the head of the chunk list.
+Metachunk* SpaceManager::allocate_chunk_to_fit(size_t requested_word_size) {
- chunk_manager()->locked_print_free_chunks(st);
-}
+ guarantee(requested_word_size < chklvl::MAX_CHUNK_WORD_SIZE,
+ "Requested size too large (" SIZE_FORMAT ").", requested_word_size);
-size_t SpaceManager::calc_chunk_size(size_t word_size) {
+ const chklvl_t min_level = chklvl::level_fitting_word_size(requested_word_size);
+ chklvl_t max_level = _chunk_alloc_sequence->get_next_chunk_level(_chunks.size());
- // Decide between a small chunk and a medium chunk. Up to
- // _small_chunk_limit small chunks can be allocated.
- // After that a medium chunk is preferred.
- size_t chunk_word_size;
-
- // Special case for unsafe anonymous metadata space.
- // UnsafeAnonymous metadata space is usually small since it is used for
- // class loader data's whose life cycle is governed by one class such as an
- // unsafe anonymous class. The majority within 1K - 2K range and
- // rarely about 4K (64-bits JVM).
- // Instead of jumping to SmallChunk after initial chunk exhausted, keeping allocation
- // from SpecializeChunk up to _anon_or_delegating_metadata_specialize_chunk_limit (4)
- // reduces space waste from 60+% to around 30%.
- if ((_space_type == Metaspace::UnsafeAnonymousMetaspaceType || _space_type == Metaspace::ReflectionMetaspaceType) &&
- _mdtype == Metaspace::NonClassType &&
- num_chunks_by_type(SpecializedIndex) < anon_and_delegating_metadata_specialize_chunk_limit &&
- word_size + Metachunk::overhead() <= SpecializedChunk) {
- return SpecializedChunk;
- }
-
- if (num_chunks_by_type(MediumIndex) == 0 &&
- num_chunks_by_type(SmallIndex) < small_chunk_limit) {
- chunk_word_size = (size_t) small_chunk_size();
- if (word_size + Metachunk::overhead() > small_chunk_size()) {
- chunk_word_size = medium_chunk_size();
- }
- } else {
- chunk_word_size = medium_chunk_size();
+ if (max_level < min_level) {
+ max_level = min_level;
}
- // Might still need a humongous chunk. Enforce
- // humongous allocations sizes to be aligned up to
- // the smallest chunk size.
- size_t if_humongous_sized_chunk =
- align_up(word_size + Metachunk::overhead(),
- smallest_chunk_size());
- chunk_word_size =
- MAX2((size_t) chunk_word_size, if_humongous_sized_chunk);
-
- assert(!SpaceManager::is_humongous(word_size) ||
- chunk_word_size == if_humongous_sized_chunk,
- "Size calculation is wrong, word_size " SIZE_FORMAT
- " chunk_word_size " SIZE_FORMAT,
- word_size, chunk_word_size);
- Log(gc, metaspace, alloc) log;
- if (log.is_trace() && SpaceManager::is_humongous(word_size)) {
- log.trace("Metadata humongous allocation:");
- log.trace(" word_size " PTR_FORMAT, word_size);
- log.trace(" chunk_word_size " PTR_FORMAT, chunk_word_size);
- log.trace(" chunk overhead " PTR_FORMAT, Metachunk::overhead());
- }
- return chunk_word_size;
-}
+ Metachunk* c = _chunk_manager->get_chunk(min_level, max_level);
+ assert(c != NULL, "Could not get a chunk");
+ assert(c->level() >= min_level && c->level() <= max_level, "Sanity");
-void SpaceManager::track_metaspace_memory_usage() {
- if (is_init_completed()) {
- if (is_class()) {
- MemoryService::track_compressed_class_memory_usage();
- }
- MemoryService::track_metaspace_memory_usage();
- }
-}
-
-MetaWord* SpaceManager::grow_and_allocate(size_t word_size) {
- assert_lock_strong(_lock);
- assert(vs_list()->current_virtual_space() != NULL,
- "Should have been set");
- assert(current_chunk() == NULL ||
- current_chunk()->allocate(word_size) == NULL,
- "Don't need to expand");
- MutexLocker cl(MetaspaceExpand_lock, Mutex::_no_safepoint_check_flag);
-
- if (log_is_enabled(Trace, gc, metaspace, freelist)) {
- size_t words_left = 0;
- size_t words_used = 0;
- if (current_chunk() != NULL) {
- words_left = current_chunk()->free_word_size();
- words_used = current_chunk()->used_word_size();
- }
- log_trace(gc, metaspace, freelist)("SpaceManager::grow_and_allocate for " SIZE_FORMAT " words " SIZE_FORMAT " words used " SIZE_FORMAT " words left",
- word_size, words_used, words_left);
- }
-
- // Get another chunk
- size_t chunk_word_size = calc_chunk_size(word_size);
- Metachunk* next = get_new_chunk(chunk_word_size);
-
- MetaWord* mem = NULL;
-
- // If a chunk was available, add it to the in-use chunk list
- // and do an allocation from it.
- if (next != NULL) {
- // Add to this manager's list of chunks in use.
- // If the new chunk is humongous, it was created to serve a single large allocation. In that
- // case it usually makes no sense to make it the current chunk, since the next allocation would
- // need to allocate a new chunk anyway, while we would now prematurely retire a perfectly
- // good chunk which could be used for more normal allocations.
- bool make_current = true;
- if (next->get_chunk_type() == HumongousIndex &&
- current_chunk() != NULL) {
- make_current = false;
- }
- add_chunk(next, make_current);
- mem = next->allocate(word_size);
- }
+ _chunks.add(c);
+ _current_chunk = c;
- // Track metaspace memory usage statistic.
- track_metaspace_memory_usage();
+ return c;
- return mem;
}
-void SpaceManager::print_on(outputStream* st) const {
- SpaceManagerStatistics stat;
- add_to_statistics(&stat); // will lock _lock.
- stat.print_on(st, 1*K, false);
+void SpaceManager::create_block_freelist() {
+ assert(_block_freelist == NULL, "Only call once");
+ _block_freelist = new BlockFreelist();
}
-SpaceManager::SpaceManager(Metaspace::MetadataType mdtype,
- Metaspace::MetaspaceType space_type,//
- Mutex* lock) :
- _lock(lock),
- _mdtype(mdtype),
- _space_type(space_type),
- _chunk_list(NULL),
+SpaceManager::SpaceManager(ChunkManager* chunk_manager, const ChunkAllocSequence* alloc_sequence, Mutex* lock)
+ : _lock(lock),
+ _chunk_manager(chunk_manager),
+ _chunk_alloc_sequence(alloc_sequence),
+ _chunks(),
_current_chunk(NULL),
- _overhead_words(0),
- _capacity_words(0),
- _used_words(0),
- _block_freelists(NULL) {
- Metadebug::init_allocation_fail_alot_count();
- memset(_num_chunks_by_type, 0, sizeof(_num_chunks_by_type));
- log_trace(gc, metaspace, freelist)("SpaceManager(): " PTR_FORMAT, p2i(this));
-}
-
-void SpaceManager::account_for_new_chunk(const Metachunk* new_chunk) {
-
- assert_lock_strong(MetaspaceExpand_lock);
-
- _capacity_words += new_chunk->word_size();
- _overhead_words += Metachunk::overhead();
- DEBUG_ONLY(new_chunk->verify());
- _num_chunks_by_type[new_chunk->get_chunk_type()] ++;
-
- // Adjust global counters:
- MetaspaceUtils::inc_capacity(mdtype(), new_chunk->word_size());
- MetaspaceUtils::inc_overhead(mdtype(), Metachunk::overhead());
-}
-
-void SpaceManager::account_for_allocation(size_t words) {
- // Note: we should be locked with the ClassloaderData-specific metaspace lock.
- // We may or may not be locked with the global metaspace expansion lock.
- assert_lock_strong(lock());
-
- // Add to the per SpaceManager totals. This can be done non-atomically.
- _used_words += words;
-
- // Adjust global counters. This will be done atomically.
- MetaspaceUtils::inc_used(mdtype(), words);
-}
-
-void SpaceManager::account_for_spacemanager_death() {
-
- assert_lock_strong(MetaspaceExpand_lock);
-
- MetaspaceUtils::dec_capacity(mdtype(), _capacity_words);
- MetaspaceUtils::dec_overhead(mdtype(), _overhead_words);
- MetaspaceUtils::dec_used(mdtype(), _used_words);
+ _block_freelist(NULL)
+{
}
SpaceManager::~SpaceManager() {
- // This call this->_lock which can't be done while holding MetaspaceExpand_lock
- DEBUG_ONLY(verify_metrics());
+ assert_lock_strong(lock());
MutexLocker fcl(MetaspaceExpand_lock, Mutex::_no_safepoint_check_flag);
- account_for_spacemanager_death();
-
- Log(gc, metaspace, freelist) log;
- if (log.is_trace()) {
- log.trace("~SpaceManager(): " PTR_FORMAT, p2i(this));
- ResourceMark rm;
- LogStream ls(log.trace());
- locked_print_chunks_in_use_on(&ls);
- if (block_freelists() != NULL) {
- block_freelists()->print_on(&ls);
- }
+ // Return all chunks to our chunk manager.
+ // Note: this destroys the _chunks list.
+ Metachunk* c = _chunks.first();
+ Metachunk* c2 = NULL;
+ while(c) {
+ c2 = c->next();
+ _chunk_manager->return_chunk(c);
+ c = c2;
}
- // Add all the chunks in use by this space manager
- // to the global list of free chunks.
-
- // Follow each list of chunks-in-use and add them to the
- // free lists. Each list is NULL terminated.
- chunk_manager()->return_chunk_list(chunk_list());
-#ifdef ASSERT
- _chunk_list = NULL;
- _current_chunk = NULL;
-#endif
-
#ifdef ASSERT
EVERY_NTH(VerifyMetaspaceInterval)
- chunk_manager()->locked_verify(true);
+ chunk_manager()->verify(true);
END_EVERY_NTH
#endif
- if (_block_freelists != NULL) {
- delete _block_freelists;
- }
-}
+ delete _block_freelist;
-void SpaceManager::deallocate(MetaWord* p, size_t word_size) {
- assert_lock_strong(lock());
- // Allocations and deallocations are in raw_word_size
- size_t raw_word_size = get_allocation_word_size(word_size);
- // Lazily create a block_freelist
- if (block_freelists() == NULL) {
- _block_freelists = new BlockFreelist();
- }
- block_freelists()->return_block(p, raw_word_size);
- DEBUG_ONLY(Atomic::inc(&(g_internal_statistics.num_deallocs)));
-}
-
-// Adds a chunk to the list of chunks in use.
-void SpaceManager::add_chunk(Metachunk* new_chunk, bool make_current) {
-
- assert_lock_strong(_lock);
- assert(new_chunk != NULL, "Should not be NULL");
- assert(new_chunk->next() == NULL, "Should not be on a list");
-
- new_chunk->reset_empty();
-
- // Find the correct list and and set the current
- // chunk for that list.
- ChunkIndex index = chunk_manager()->list_index(new_chunk->word_size());
-
- if (make_current) {
- // If we are to make the chunk current, retire the old current chunk and replace
- // it with the new chunk.
- retire_current_chunk();
- set_current_chunk(new_chunk);
- }
-
- // Add the new chunk at the head of its respective chunk list.
- new_chunk->set_next(_chunk_list);
- _chunk_list = new_chunk;
-
- // Adjust counters.
- account_for_new_chunk(new_chunk);
-
- assert(new_chunk->is_empty(), "Not ready for reuse");
- Log(gc, metaspace, freelist) log;
- if (log.is_trace()) {
- log.trace("SpaceManager::added chunk: ");
- ResourceMark rm;
- LogStream ls(log.trace());
- new_chunk->print_on(&ls);
- chunk_manager()->locked_print_free_chunks(&ls);
- }
}
+// The current chunk is unable to service a request. The remainder of the chunk is
+// chopped into blocks and fed into the _block_freelists, in the hope of later reuse.
void SpaceManager::retire_current_chunk() {
- if (current_chunk() != NULL) {
- size_t remaining_words = current_chunk()->free_word_size();
+ Metachunk* c = _current_chunk;
+ assert(c != NULL, "Sanity");
+ assert(c->used_words() > 0, "Why do we retire an empty chunk?");
+ size_t remaining_words = c->free_below_committed_words();
if (remaining_words >= SmallBlocks::small_block_min_size()) {
- MetaWord* ptr = current_chunk()->allocate(remaining_words);
+ bool did_hit_limit = false;
+ MetaWord* ptr = c->allocate(remaining_words, &did_hit_limit);
+ assert(ptr != NULL && did_hit_limit == false, "Should have worked");
deallocate(ptr, remaining_words);
- account_for_allocation(remaining_words);
- }
}
}
-Metachunk* SpaceManager::get_new_chunk(size_t chunk_word_size) {
- // Get a chunk from the chunk freelist
- Metachunk* next = chunk_manager()->chunk_freelist_allocate(chunk_word_size);
+// Allocate memory from Metaspace.
+// 1) Attempt to allocate from the dictionary of deallocated blocks.
+// 2) Failing that, attempt to allocate from the current chunk. If this
+// fails because the chunk needed to be committed and we hit a commit limit, return NULL.
+// 3) Attempt to get a new chunk and allocate from that chunk. Again, we may hit a commit
+// limit, in which case we return NULL.
+MetaWord* SpaceManager::allocate(size_t requested_word_size) {
- if (next == NULL) {
- next = vs_list()->get_new_chunk(chunk_word_size,
- medium_chunk_bunch());
- }
-
- Log(gc, metaspace, alloc) log;
- if (log.is_trace() && next != NULL &&
- SpaceManager::is_humongous(next->word_size())) {
- log.trace(" new humongous chunk word size " PTR_FORMAT, next->word_size());
- }
+ MutexLocker cl(lock(), Mutex::_no_safepoint_check_flag);
- return next;
-}
+ const size_t word_size = align_up(requested_word_size, get_allocation_word_size(requested_word_size));
-MetaWord* SpaceManager::allocate(size_t word_size) {
- MutexLocker cl(lock(), Mutex::_no_safepoint_check_flag);
- size_t raw_word_size = get_allocation_word_size(word_size);
- BlockFreelist* fl = block_freelists();
MetaWord* p = NULL;
+ bool did_hit_limit = false;
+
+ // Allocate first chunk if needed.
+ if (_current_chunk == NULL) {
+ Metachunk* c = allocate_chunk_to_fit(requested_word_size);
+ assert(c != NULL && _chunks.size() == 1 && c == _current_chunk, "Should be");
+ }
+
+ // 1) Attempt to allocate from the dictionary of deallocated blocks.
+
// Allocation from the dictionary is expensive in the sense that
// the dictionary has to be searched for a size. Don't allocate
// from the dictionary until it starts to get fat. Is this
// a reasonable policy? Maybe an skinny dictionary is fast enough
// for allocations. Do some profiling. JJJ
- if (fl != NULL && fl->total_size() > allocation_from_dictionary_limit) {
- p = fl->get_block(raw_word_size);
+ if (_block_freelist != NULL && _block_freelist->total_size() > constants::allocation_from_dictionary_limit) {
+ p = _block_freelist->get_block(requested_word_size);
if (p != NULL) {
DEBUG_ONLY(Atomic::inc(&g_internal_statistics.num_allocs_from_deallocated_blocks));
}
}
- if (p == NULL) {
- p = allocate_work(raw_word_size);
+
+ // 2) Attempt to allocate from the current chunk.
+ if (p == NULL && !did_hit_limit) {
+ p = _current_chunk->allocate(requested_word_size, &did_hit_limit);
}
-#ifdef ASSERT
- EVERY_NTH(VerifyMetaspaceInterval)
- verify_metrics_locked();
- END_EVERY_NTH
-#endif
+ // 3) Attempt to get a new chunk and allocate from that chunk.
+ if (p == NULL && !did_hit_limit) {
- return p;
-}
+ // Old chunk is too small to hold requested size?
+ assert(_current_chunk->free_words() < requested_word_size, "Sanity");
-// Returns the address of spaced allocated for "word_size".
-// This methods does not know about blocks (Metablocks)
-MetaWord* SpaceManager::allocate_work(size_t word_size) {
- assert_lock_strong(lock());
-#ifdef ASSERT
- if (Metadebug::test_metadata_failure()) {
- return NULL;
- }
-#endif
- // Is there space in the current chunk?
- MetaWord* result = NULL;
+ // Retire the old chunk. This will put all remainder space (committed
+ // space only) into the block freelist.
+ retire_current_chunk();
+ assert(_current_chunk->free_below_committed_words() == 0, "Sanity");
- if (current_chunk() != NULL) {
- result = current_chunk()->allocate(word_size);
- }
+ // Allocate a new chunk.
+ Metachunk* c = allocate_chunk_to_fit(requested_word_size);
+ assert(c != NULL && _chunks.size() > 0 && c == _current_chunk, "Should be");
- if (result == NULL) {
- result = grow_and_allocate(word_size);
- }
+ p = _current_chunk->allocate(requested_word_size, &did_hit_limit);
- if (result != NULL) {
- account_for_allocation(word_size);
}
- return result;
-}
+ assert(p != NULL || (p == NULL && did_hit_limit), "Sanity");
+
+ return p;
-void SpaceManager::verify() {
- Metachunk* curr = chunk_list();
- while (curr != NULL) {
- DEBUG_ONLY(do_verify_chunk(curr);)
- assert(curr->is_tagged_free() == false, "Chunk should be tagged as in use.");
- curr = curr->next();
- }
}
-void SpaceManager::verify_chunk_size(Metachunk* chunk) {
- assert(is_humongous(chunk->word_size()) ||
- chunk->word_size() == medium_chunk_size() ||
- chunk->word_size() == small_chunk_size() ||
- chunk->word_size() == specialized_chunk_size(),
- "Chunk size is wrong");
- return;
+// Prematurely returns a metaspace allocation to the _block_freelists because it is not
+// needed anymore.
+void SpaceManager::deallocate(MetaWord* p, size_t word_size) {
+ _block_freelist->return_block(p, word_size);
}
-void SpaceManager::add_to_statistics_locked(SpaceManagerStatistics* out) const {
- assert_lock_strong(lock());
- Metachunk* chunk = chunk_list();
- while (chunk != NULL) {
- UsedChunksStatistics& chunk_stat = out->chunk_stats(chunk->get_chunk_type());
- chunk_stat.add_num(1);
- chunk_stat.add_cap(chunk->word_size());
- chunk_stat.add_overhead(Metachunk::overhead());
- chunk_stat.add_used(chunk->used_word_size() - Metachunk::overhead());
- if (chunk != current_chunk()) {
- chunk_stat.add_waste(chunk->free_word_size());
+// Update statistics. This walks all in-use chunks.
+void SpaceManager::add_to_statistics(SpaceManagerStatistics* out) const {
+
+ for (const Metachunk* c = _chunks.first(); c != NULL; c = c->next()) {
+ UsedChunksStatistics& ucs = out->chunk_stats[c->level()];
+ ucs.cap += c->word_size();
+ // Note: for free and waste, we only count what's committed.
+ if (c == _current_chunk) {
+ ucs.free += c->free_words();
} else {
- chunk_stat.add_free(chunk->free_word_size());
+ ucs.waste += c->free_words();
}
- chunk = chunk->next();
+
}
- if (block_freelists() != NULL) {
- out->add_free_blocks_info(block_freelists()->num_blocks(), block_freelists()->total_size());
+
+ if (block_freelist() != NULL) {
+ out->add_free_blocks_info(block_freelist()->num_blocks(), block_freelist()->total_size());
}
-}
-void SpaceManager::add_to_statistics(SpaceManagerStatistics* out) const {
- MutexLocker cl(lock(), Mutex::_no_safepoint_check_flag);
- add_to_statistics_locked(out);
}
#ifdef ASSERT
-void SpaceManager::verify_metrics_locked() const {
- assert_lock_strong(lock());
-
- SpaceManagerStatistics stat;
- add_to_statistics_locked(&stat);
-
- UsedChunksStatistics chunk_stats = stat.totals();
-
- DEBUG_ONLY(chunk_stats.check_sanity());
+void SpaceManager::verify(bool slow) const {
+ MutexLocker cl(lock(), Mutex::_no_safepoint_check_flag);
+ assert(_chunk_alloc_sequence != NULL && _chunk_manager != NULL, "Sanity");
- assert_counter(_capacity_words, chunk_stats.cap(), "SpaceManager::_capacity_words");
- assert_counter(_used_words, chunk_stats.used(), "SpaceManager::_used_words");
- assert_counter(_overhead_words, chunk_stats.overhead(), "SpaceManager::_overhead_words");
-}
+ const Metachunk* c = _chunks.first();
+ while (c != NULL) {
+ c->verify(slow);
+ c = c->next();
+ }
-void SpaceManager::verify_metrics() const {
- MutexLocker cl(lock(), Mutex::_no_safepoint_check_flag);
- verify_metrics_locked();
}
#endif // ASSERT
} // namespace metaspace
< prev index next >