Code Review for source

Prepared by:stuefe stuefe on Sun Jul 14 09:05:54 CEST 2019
Workspace:/shared/projects/openjdk/jdk-sandbox/source
Compare against: https://hg.openjdk.java.net/jdk/sandbox
Compare against version:57379
Summary of changes: 4844 lines changed: 1789 ins; 2638 del; 417 mod; 4297 unchg
Patch of changes: source.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace.cpp

rev 57380 : [mq]: metaspace-improvement
213 lines changed: 7 ins; 197 del; 9 mod; 1460 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace.hpp

rev 57380 : [mq]: metaspace-improvement
70 lines changed: 0 ins; 70 del; 0 mod; 413 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/chunkManager.cpp

rev 57380 : [mq]: metaspace-improvement
584 lines changed: 14 ins; 536 del; 34 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/chunkManager.hpp

rev 57380 : [mq]: metaspace-improvement
162 lines changed: 16 ins; 98 del; 48 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metachunk.cpp

rev 57380 : [mq]: metaspace-improvement
141 lines changed: 25 ins; 65 del; 51 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metachunk.hpp

rev 57380 : [mq]: metaspace-improvement
174 lines changed: 52 ins; 40 del; 82 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metaspaceCommon.cpp

rev 57380 : [mq]: metaspace-improvement
64 lines changed: 0 ins; 64 del; 0 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metaspaceCommon.hpp

rev 57380 : [mq]: metaspace-improvement
50 lines changed: 0 ins; 50 del; 0 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/spaceManager.cpp

rev 57380 : [mq]: metaspace-improvement
484 lines changed: 7 ins; 472 del; 5 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/spaceManager.hpp

rev 57380 : [mq]: metaspace-improvement
168 lines changed: 11 ins; 130 del; 27 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/virtualSpaceList.cpp

rev 57380 : [mq]: metaspace-improvement
1 line changed: 0 ins; 0 del; 1 mod; 446 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/virtualSpaceList.hpp

rev 57380 : [mq]: metaspace-improvement
124 lines changed: 13 ins; 94 del; 17 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp

rev 57380 : [mq]: metaspace-improvement
531 lines changed: 46 ins; 381 del; 104 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/virtualSpaceNode.hpp

rev 57380 : [mq]: metaspace-improvement
162 lines changed: 63 ins; 64 del; 35 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/bitMap.cpp

rev 57380 : [mq]: metaspace-improvement
1 line changed: 0 ins; 0 del; 1 mod; 701 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/bitMap.hpp

rev 57380 : [mq]: metaspace-improvement
7 lines changed: 4 ins; 0 del; 3 mod; 446 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/abstractPool.hpp

rev 57380 : [mq]: metaspace-improvement
132 lines changed: 132 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkAllocSequence.cpp

rev 57380 : [mq]: metaspace-improvement
176 lines changed: 176 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkAllocSequence.hpp

rev 57380 : [mq]: metaspace-improvement
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkLevel.cpp

rev 57380 : [mq]: metaspace-improvement
33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkLevel.hpp

rev 57380 : [mq]: metaspace-improvement
111 lines changed: 111 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkTree.cpp

rev 57380 : [mq]: metaspace-improvement
285 lines changed: 285 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkTree.hpp

rev 57380 : [mq]: metaspace-improvement
229 lines changed: 229 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/classLoaderMetaspace.cpp

rev 57380 : [mq]: metaspace-improvement
128 lines changed: 128 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/classLoaderMetaspace.hpp

rev 57380 : [mq]: metaspace-improvement
77 lines changed: 77 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/commitCounter.cpp

rev 57380 : [mq]: metaspace-improvement
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/commitCounter.hpp

rev 57380 : [mq]: metaspace-improvement
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/commitMask.hpp

rev 57380 : [mq]: metaspace-improvement
183 lines changed: 183 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/constants.hpp

rev 57380 : [mq]: metaspace-improvement
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/memory/metaspace/occupancyMap.cpp

rev 57380 : [mq]: metaspace-improvement
135 lines changed: 0 ins; 135 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/memory/metaspace/occupancyMap.hpp

rev 57380 : [mq]: metaspace-improvement
242 lines changed: 0 ins; 242 del; 0 mod; 0 unchg

This code review page was prepared using /shared/projects/openjdk/code-tools/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).