Code Review for source

Prepared by:stuefe stuefe on Mon Jul 22 11:08:23 CEST 2019
Workspace:/shared/projects/openjdk/jdk-sandbox/source
Compare against: https://hg.openjdk.java.net/jdk/sandbox
Compare against version:57379
Summary of changes: 8289 lines changed: 3910 ins; 3633 del; 746 mod; 3539 unchg
Patch of changes: source.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace.cpp

rev 57380 : [mq]: metaspace-improvement
866 lines changed: 8 ins; 850 del; 8 mod; 808 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace.hpp

rev 57380 : [mq]: metaspace-improvement
172 lines changed: 6 ins; 162 del; 4 mod; 317 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/chunkManager.cpp

rev 57380 : [mq]: metaspace-improvement
568 lines changed: 16 ins; 403 del; 149 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/chunkManager.hpp

rev 57380 : [mq]: metaspace-improvement
195 lines changed: 43 ins; 106 del; 46 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metachunk.cpp

rev 57380 : [mq]: metaspace-improvement
195 lines changed: 77 ins; 80 del; 38 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metachunk.hpp

rev 57380 : [mq]: metaspace-improvement
225 lines changed: 104 ins; 43 del; 78 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metaspaceCommon.cpp

rev 57380 : [mq]: metaspace-improvement
64 lines changed: 0 ins; 64 del; 0 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metaspaceCommon.hpp

rev 57380 : [mq]: metaspace-improvement
50 lines changed: 0 ins; 50 del; 0 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metaspaceStatistics.cpp

rev 57380 : [mq]: metaspace-improvement
115 lines changed: 4 ins; 61 del; 50 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metaspaceStatistics.hpp

rev 57380 : [mq]: metaspace-improvement
116 lines changed: 21 ins; 66 del; 29 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/spaceManager.cpp

rev 57380 : [mq]: metaspace-improvement
430 lines changed: 14 ins; 329 del; 87 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/spaceManager.hpp

rev 57380 : [mq]: metaspace-improvement
173 lines changed: 12 ins; 124 del; 37 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/virtualSpaceList.cpp

rev 57380 : [mq]: metaspace-improvement
427 lines changed: 42 ins; 328 del; 57 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/virtualSpaceList.hpp

rev 57380 : [mq]: metaspace-improvement
109 lines changed: 11 ins; 59 del; 39 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp

rev 57380 : [mq]: metaspace-improvement
627 lines changed: 145 ins; 389 del; 93 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/virtualSpaceNode.hpp

rev 57380 : [mq]: metaspace-improvement
267 lines changed: 159 ins; 91 del; 17 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspaceChunkFreeListSummary.hpp

rev 57380 : [mq]: metaspace-improvement
61 lines changed: 0 ins; 51 del; 10 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/bitMap.cpp

rev 57380 : [mq]: metaspace-improvement
1 line changed: 0 ins; 0 del; 1 mod; 701 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/bitMap.hpp

rev 57380 : [mq]: metaspace-improvement
7 lines changed: 4 ins; 0 del; 3 mod; 446 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/abstractPool.hpp

rev 57380 : [mq]: metaspace-improvement
183 lines changed: 183 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkAllocSequence.cpp

rev 57380 : [mq]: metaspace-improvement
190 lines changed: 190 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkAllocSequence.hpp

rev 57380 : [mq]: metaspace-improvement
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkLevel.cpp

rev 57380 : [mq]: metaspace-improvement
45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkLevel.hpp

rev 57380 : [mq]: metaspace-improvement
117 lines changed: 117 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkTree.cpp

rev 57380 : [mq]: metaspace-improvement
477 lines changed: 477 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkTree.hpp

rev 57380 : [mq]: metaspace-improvement
281 lines changed: 281 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/classLoaderMetaspace.cpp

rev 57380 : [mq]: metaspace-improvement
128 lines changed: 128 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/classLoaderMetaspace.hpp

rev 57380 : [mq]: metaspace-improvement
77 lines changed: 77 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/commitLimiter.cpp

rev 57380 : [mq]: metaspace-improvement
56 lines changed: 56 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/commitLimiter.hpp

rev 57380 : [mq]: metaspace-improvement
61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/commitMask.cpp

rev 57380 : [mq]: metaspace-improvement
76 lines changed: 76 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/commitMask.hpp

rev 57380 : [mq]: metaspace-improvement
191 lines changed: 191 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/constants.hpp

rev 57380 : [mq]: metaspace-improvement
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/counter.hpp

rev 57380 : [mq]: metaspace-improvement
101 lines changed: 101 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/metaspaceGC.cpp

rev 57380 : [mq]: metaspace-improvement
324 lines changed: 324 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/metaspaceGC.hpp

rev 57380 : [mq]: metaspace-improvement
87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/metaspaceReport.cpp

rev 57380 : [mq]: metaspace-improvement
406 lines changed: 406 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/metaspaceReport.hpp

rev 57380 : [mq]: metaspace-improvement
65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/runningCounters.cpp

rev 57380 : [mq]: metaspace-improvement
95 lines changed: 95 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/runningCounters.hpp

rev 57380 : [mq]: metaspace-improvement
87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/gtest/metaspace/test_pool.cpp

rev 57380 : [mq]: metaspace-improvement
85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/memory/metaspace/occupancyMap.cpp

rev 57380 : [mq]: metaspace-improvement
135 lines changed: 0 ins; 135 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/memory/metaspace/occupancyMap.hpp

rev 57380 : [mq]: metaspace-improvement
242 lines changed: 0 ins; 242 del; 0 mod; 0 unchg

This code review page was prepared using /shared/projects/openjdk/code-tools/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).