Code Review for nashorn

Prepared by:sundar on Mon Mar 17 14:06:07 IST 2014
Workspace:/home/sundar/src/jdk9-dev/nashorn
Summary of changes: 745 lines changed: 150 ins; 368 del; 227 mod; 26359 unchg
Patch of changes: nashorn.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/build.xml

2 lines changed: 2 ins; 0 del; 0 mod; 603 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/api/scripting/NashornScriptEngine.java

35 lines changed: 1 ins; 2 del; 32 mod; 614 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/api/scripting/ScriptObjectMirror.java

13 lines changed: 1 ins; 1 del; 11 mod; 753 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java

5 lines changed: 0 ins; 4 del; 1 mod; 219 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/ArrayBufferView.java

5 lines changed: 0 ins; 4 del; 1 mod; 392 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/DataPropertyDescriptor.java

5 lines changed: 0 ins; 4 del; 1 mod; 207 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/GenericPropertyDescriptor.java

5 lines changed: 0 ins; 4 del; 1 mod; 184 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/Global.java

144 lines changed: 115 ins; 3 del; 26 mod; 1832 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeArray.java

5 lines changed: 0 ins; 4 del; 1 mod; 1415 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeArrayBuffer.java

5 lines changed: 0 ins; 4 del; 1 mod; 139 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeBoolean.java

5 lines changed: 0 ins; 4 del; 1 mod; 188 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeDate.java

5 lines changed: 0 ins; 4 del; 1 mod; 1347 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeError.java

5 lines changed: 0 ins; 4 del; 1 mod; 404 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeEvalError.java

5 lines changed: 0 ins; 4 del; 1 mod; 103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeJSAdapter.java

5 lines changed: 0 ins; 4 del; 1 mod; 746 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeJavaImporter.java

5 lines changed: 0 ins; 4 del; 1 mod; 170 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeNumber.java

5 lines changed: 0 ins; 4 del; 1 mod; 388 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeRangeError.java

5 lines changed: 0 ins; 4 del; 1 mod; 103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeReferenceError.java

5 lines changed: 0 ins; 4 del; 1 mod; 103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeRegExp.java

5 lines changed: 0 ins; 4 del; 1 mod; 926 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java

5 lines changed: 0 ins; 4 del; 1 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeString.java

5 lines changed: 0 ins; 4 del; 1 mod; 1264 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeSyntaxError.java

5 lines changed: 0 ins; 4 del; 1 mod; 101 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeTypeError.java

5 lines changed: 0 ins; 4 del; 1 mod; 99 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeURIError.java

5 lines changed: 0 ins; 4 del; 1 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/PrototypeObject.java

4 lines changed: 0 ins; 4 del; 0 mod; 115 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java

28 lines changed: 0 ins; 20 del; 8 mod; 277 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/Context.java

53 lines changed: 9 ins; 19 del; 25 mod; 1005 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/DebuggerSupport.java

2 lines changed: 0 ins; 0 del; 2 mod; 328 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/ECMAErrors.java

29 lines changed: 1 ins; 0 del; 28 mod; 388 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/JSONFunctions.java

11 lines changed: 1 ins; 0 del; 10 mod; 212 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/JSType.java

5 lines changed: 1 ins; 0 del; 4 mod; 1070 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/ListAdapter.java

7 lines changed: 1 ins; 0 del; 6 mod; 448 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/NativeJavaPackage.java

2 lines changed: 0 ins; 1 del; 1 mod; 238 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/ParserException.java

2 lines changed: 1 ins; 0 del; 1 mod; 116 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/ScriptFunction.java

3 lines changed: 1 ins; 0 del; 2 mod; 652 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/ScriptFunctionData.java

3 lines changed: 1 ins; 0 del; 2 mod; 757 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/ScriptObject.java

10 lines changed: 0 ins; 0 del; 10 mod; 3380 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/ScriptRuntime.java

1 line changed: 0 ins; 0 del; 1 mod; 968 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/SetMethodCreator.java

1 line changed: 0 ins; 0 del; 1 mod; 197 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/UserAccessorProperty.java

3 lines changed: 1 ins; 0 del; 2 mod; 241 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/arrays/ArrayData.java

2 lines changed: 0 ins; 0 del; 2 mod; 554 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/arrays/ByteBufferArrayData.java

3 lines changed: 1 ins; 0 del; 2 mod; 201 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/arrays/FrozenArrayFilter.java

3 lines changed: 1 ins; 1 del; 1 mod; 80 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/arrays/SealedArrayFilter.java

3 lines changed: 1 ins; 1 del; 1 mod; 66 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java

13 lines changed: 4 ins; 0 del; 9 mod; 1000 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java

4 lines changed: 1 ins; 1 del; 2 mod; 341 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/linker/NashornPrimitiveLinker.java

3 lines changed: 1 ins; 1 del; 1 mod; 174 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/tools/Shell.java

10 lines changed: 1 ins; 0 del; 9 mod; 451 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/codegen/CompilerTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 194 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/performance/PerformanceWrapper.java

3 lines changed: 1 ins; 1 del; 1 mod; 153 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/ContextTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 112 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/test/framework/SharedContextEvaluator.java

4 lines changed: 1 ins; 1 del; 2 mod; 150 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/jdk/nashorn/internal/runtime/GlobalObject.java

228 lines changed: 0 ins; 228 del; 0 mod; 0 unchg

This code review page was prepared using /home/sundar/src/jdk8-tl/make/scripts/webrev.ksh (vers 25.1-hg+openjdk.java.net).