Code Review for nashorn

Prepared by:sundar on Thu May 21 10:09:27 IST 2015
Workspace:/home/sundar/src/jdk8u-dev/nashorn
Compare against: ssh://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn
Compare against version:1357
Summary of changes: 455 lines changed: 418 ins; 1 del; 36 mod; 8383 unchg
Changeset: nashorn.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/build.xml

rev 1358 : 8067636: ant javadoc target is broken
Reviewed-by: hannesw, lagergren
rev 1359 : 8080598: Javadoc warnings in Global.java after lazy initialization
Reviewed-by: lagergren, hannesw
2 lines changed: 0 ins; 0 del; 2 mod; 731 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw samples/browser_dom.js

rev 1358 : 8067636: ant javadoc target is broken
Reviewed-by: hannesw, lagergren
1 line changed: 0 ins; 1 del; 0 mod; 90 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/codegen/OptimisticTypesPersistence.java

rev 1358 : 8067636: ant javadoc target is broken
Reviewed-by: hannesw, lagergren
2 lines changed: 1 ins; 0 del; 1 mod; 548 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/ir/LexicalContext.java

rev 1359 : 8080598: Javadoc warnings in Global.java after lazy initialization
Reviewed-by: lagergren, hannesw
1 line changed: 0 ins; 0 del; 1 mod; 728 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/ir/TryNode.java

rev 1359 : 8080598: Javadoc warnings in Global.java after lazy initialization
Reviewed-by: lagergren, hannesw
1 line changed: 0 ins; 0 del; 1 mod; 323 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/Global.java

rev 1359 : 8080598: Javadoc warnings in Global.java after lazy initialization
Reviewed-by: lagergren, hannesw
227 lines changed: 201 ins; 0 del; 26 mod; 2755 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/CodeInstaller.java

rev 1358 : 8067636: ant javadoc target is broken
Reviewed-by: hannesw, lagergren
1 line changed: 0 ins; 0 del; 1 mod; 119 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/JSType.java

rev 1358 : 8067636: ant javadoc target is broken
Reviewed-by: hannesw, lagergren
2 lines changed: 0 ins; 0 del; 2 mod; 1989 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/StoredScript.java

rev 1358 : 8067636: ant javadoc target is broken
Reviewed-by: hannesw, lagergren
1 line changed: 0 ins; 0 del; 1 mod; 167 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/arrays/ArrayData.java

rev 1358 : 8067636: ant javadoc target is broken
Reviewed-by: hannesw, lagergren
1 line changed: 0 ins; 0 del; 1 mod; 933 unchg

------ ------ ------ ------ ------ --- New ----- Raw samples/time_color.fx

rev 1358 : 8067636: ant javadoc target is broken
Reviewed-by: hannesw, lagergren
89 lines changed: 89 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw samples/undefined_call.js

rev 1359 : 8080598: Javadoc warnings in Global.java after lazy initialization
Reviewed-by: lagergren, hannesw
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw samples/unzip.js

rev 1359 : 8080598: Javadoc warnings in Global.java after lazy initialization
Reviewed-by: lagergren, hannesw
79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/sundar/src/webrev/webrev.ksh (vers 25.10-hg+openjdk.java.net).