Code Review for nashorn

Prepared by:sundar on Thu Feb 5 23:46:17 IST 2015
Workspace:/home/sundar/src/jdk8u-dev/nashorn
Compare against version:1198
Summary of changes: 68 lines changed: 26 ins; 8 del; 34 mod; 8875 unchg
Changeset: nashorn.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw samples/javashell.js

rev 1199 : 8072595: nashorn should not use obj.getClass() for null checks
Reviewed-by: hannesw, attila
2 lines changed: 1 ins; 0 del; 1 mod; 145 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw samples/shell.js

rev 1199 : 8072595: nashorn should not use obj.getClass() for null checks
Reviewed-by: hannesw, attila
2 lines changed: 1 ins; 0 del; 1 mod; 80 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/internal/dynalink/DynamicLinker.java

rev 1199 : 8072595: nashorn should not use obj.getClass() for null checks
Reviewed-by: hannesw, attila
2 lines changed: 1 ins; 0 del; 1 mod; 323 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/internal/dynalink/beans/StaticClass.java

rev 1199 : 8072595: nashorn should not use obj.getClass() for null checks
Reviewed-by: hannesw, attila
3 lines changed: 1 ins; 1 del; 1 mod; 136 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/internal/dynalink/linker/GuardedInvocation.java

rev 1199 : 8072595: nashorn should not use obj.getClass() for null checks
Reviewed-by: hannesw, attila
5 lines changed: 1 ins; 2 del; 2 mod; 438 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/internal/dynalink/support/CallSiteDescriptorFactory.java

rev 1199 : 8072595: nashorn should not use obj.getClass() for null checks
Reviewed-by: hannesw, attila
4 lines changed: 1 ins; 0 del; 3 mod; 270 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/api/scripting/NashornScriptEngine.java

rev 1199 : 8072595: nashorn should not use obj.getClass() for null checks
Reviewed-by: hannesw, attila
2 lines changed: 1 ins; 0 del; 1 mod; 555 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java

rev 1199 : 8072595: nashorn should not use obj.getClass() for null checks
Reviewed-by: hannesw, attila
6 lines changed: 1 ins; 0 del; 5 mod; 282 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/api/scripting/ScriptObjectMirror.java

rev 1199 : 8072595: nashorn should not use obj.getClass() for null checks
Reviewed-by: hannesw, attila
12 lines changed: 1 ins; 2 del; 9 mod; 813 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/api/scripting/URLReader.java

rev 1199 : 8072595: nashorn should not use obj.getClass() for null checks
Reviewed-by: hannesw, attila
3 lines changed: 1 ins; 1 del; 1 mod; 121 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/codegen/CompileUnit.java

rev 1199 : 8072595: nashorn should not use obj.getClass() for null checks
Reviewed-by: hannesw, attila
2 lines changed: 1 ins; 0 del; 1 mod; 169 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/Global.java

rev 1199 : 8072595: nashorn should not use obj.getClass() for null checks
Reviewed-by: hannesw, attila
4 lines changed: 1 ins; 1 del; 2 mod; 2384 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/Context.java

rev 1199 : 8072595: nashorn should not use obj.getClass() for null checks
Reviewed-by: hannesw, attila
2 lines changed: 1 ins; 0 del; 1 mod; 1486 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/ScriptLoader.java

rev 1199 : 8072595: nashorn should not use obj.getClass() for null checks
Reviewed-by: hannesw, attila
3 lines changed: 1 ins; 1 del; 1 mod; 74 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/linker/JavaSuperAdapter.java

rev 1199 : 8072595: nashorn should not use obj.getClass() for null checks
Reviewed-by: hannesw, attila
3 lines changed: 2 ins; 0 del; 1 mod; 43 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/options/Options.java

rev 1199 : 8072595: nashorn should not use obj.getClass() for null checks
Reviewed-by: hannesw, attila
4 lines changed: 1 ins; 0 del; 3 mod; 696 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

rev 1199 : 8072595: nashorn should not use obj.getClass() for null checks
Reviewed-by: hannesw, attila
9 lines changed: 9 ins; 0 del; 0 mod; 860 unchg

This code review page was prepared using /home/sundar/src/webrev/webrev.ksh (vers 25.5-hg+openjdk.java.net).