Code Review for panama-dev

Prepared by:sundar on Wed May 23 19:46:10 IST 2018
Workspace:/Users/SATHIJEG/src/panama-dev
Branch:foreign
Summary of changes: 512 lines changed: 151 ins; 139 del; 222 mod; 5819 unchg
Patch of changes: panama-dev.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nicl/metadata/NativeHeader.java

6 lines changed: 5 ins; 0 del; 1 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nicl/metadata/NativeType.java

4 lines changed: 0 ins; 3 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nicl/types/LayoutType.java

4 lines changed: 0 ins; 0 del; 4 mod; 228 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nicl/types/Struct.java

1 line changed: 0 ins; 0 del; 1 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/nicl/HeaderImplGenerator.java

14 lines changed: 3 ins; 1 del; 10 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/nicl/LibrariesHelper.java

6 lines changed: 1 ins; 3 del; 2 mod; 221 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/nicl/StructImplGenerator.java

1 line changed: 0 ins; 0 del; 1 mod; 368 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/nicl/UpcallHandler.java

1 line changed: 0 ins; 0 del; 1 mod; 315 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/nicl/Util.java

37 lines changed: 19 ins; 13 del; 5 mod; 280 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/nicl/types/References.java

4 lines changed: 0 ins; 0 del; 4 mod; 660 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jextract/share/classes/com/sun/tools/jextract/AsmCodeFactory.java

63 lines changed: 22 ins; 30 del; 11 mod; 688 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/com/sun/tools/jextract/JTypeTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/com/sun/tools/jextract/JextractToolProviderTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 579 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/com/sun/tools/jextract/Runner.java

14 lines changed: 2 ins; 4 del; 8 mod; 308 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/com/sun/tools/jextract/recursive.java

15 lines changed: 4 ins; 2 del; 9 mod; 29 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/com/sun/tools/jextract/simple.java

50 lines changed: 4 ins; 3 del; 43 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nicl/BindLookupTest.java

3 lines changed: 0 ins; 1 del; 2 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nicl/GlobalVariable.java

23 lines changed: 0 ins; 1 del; 22 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nicl/Hello.java

3 lines changed: 0 ins; 1 del; 2 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nicl/System/UnixSystem.java

27 lines changed: 0 ins; 5 del; 22 mod; 245 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nicl/Upcall/CallbackSort.java

10 lines changed: 2 ins; 4 del; 4 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nicl/Upcall/DoubleUpcall.java

10 lines changed: 2 ins; 4 del; 4 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nicl/Upcall/StructUpcall.java

25 lines changed: 3 ins; 4 del; 18 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nicl/Upcall/Upcall.java

10 lines changed: 2 ins; 4 del; 4 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nicl/getpid/unistd.java

7 lines changed: 1 ins; 3 del; 3 mod; 30 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nicl/printf/stdio.java

19 lines changed: 1 ins; 7 del; 11 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nicl/qsort/stdlib.java

9 lines changed: 2 ins; 3 del; 4 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nicl/security/BindTest.java

3 lines changed: 0 ins; 1 del; 2 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nicl/types/PointerTest.java

18 lines changed: 0 ins; 4 del; 14 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nicl/types/StructTest.java

5 lines changed: 1 ins; 0 del; 4 mod; 158 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/nicl/metadata/NativeCallback.java

38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nicl/metadata/NativeLocation.java (was src/java.base/share/classes/java/nicl/metadata/C.java)

1 line changed: 0 ins; 0 del; 1 mod; 33 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/nicl/metadata/NativeStruct.java

38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/java/nicl/metadata/CallingConvention.java

38 lines changed: 0 ins; 38 del; 0 mod; 0 unchg

This code review page was prepared using ../webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).