Code Review for nashorn

Prepared by:sundar on Wed Mar 19 21:34:46 IST 2014
Workspace:/home/sundar/src/jdk8u-dev/nashorn
Compare against: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn
Compare against version:735
Summary of changes: 6777 lines changed: 4934 ins; 1219 del; 624 mod; 52281 unchg
Changeset: nashorn.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ClassGenerator.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
4 lines changed: 0 ins; 4 del; 0 mod; 369 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ConstructorGenerator.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
6 lines changed: 0 ins; 6 del; 0 mod; 271 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/MemberInfo.java

rev 745 : 8029332: Do not require nasgen-generated functions to return Object
Reviewed-by: lagergren, jlaskey, hannesw
4 lines changed: 0 ins; 4 del; 0 mod; 373 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/MethodGenerator.java

rev 736 : 8029031: "ant clean jar" on nashorn repo results in number of ASM deprecated warnings
Reviewed-by: lagergren, jlaskey, hannesw
6 lines changed: 0 ins; 0 del; 6 mod; 425 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/PrototypeGenerator.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
4 lines changed: 0 ins; 4 del; 0 mod; 182 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInstrumentor.java

rev 736 : 8029031: "ant clean jar" on nashorn repo results in number of ASM deprecated warnings
Reviewed-by: lagergren, jlaskey, hannesw
5 lines changed: 0 ins; 0 del; 5 mod; 297 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/StringConstants.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
6 lines changed: 0 ins; 6 del; 0 mod; 140 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/BuildNashorn.gmk

rev 756 : 8033951: nasgen needs the newly build nasgen and nashorn classes in the bootclasspath
Reviewed-by: erikj
1 line changed: 0 ins; 0 del; 1 mod; 111 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/build.xml

rev 751 : 8033763: Add tests to assert map identity of certain objects
Reviewed-by: hannesw, lagergren
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
11 lines changed: 11 ins; 0 del; 0 mod; 556 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/project.properties

rev 751 : 8033763: Add tests to assert map identity of certain objects
Reviewed-by: hannesw, lagergren
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
4 lines changed: 1 ins; 0 del; 3 mod; 295 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/api/scripting/NashornException.java

rev 737 : 8029364: NashornException to expose thrown object
Reviewed-by: lagergren, jlaskey
rev 739 : 8030809: Anonymous functions should not be shown with internal names in script stack trace
Reviewed-by: lagergren, hannesw, jlaskey
rev 747 : 8031983: Error objects should capture stack at the constructor
Reviewed-by: jlaskey, hannesw
78 lines changed: 74 ins; 0 del; 4 mod; 187 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/api/scripting/NashornScriptEngine.java

rev 737 : 8029364: NashornException to expose thrown object
Reviewed-by: lagergren, jlaskey
rev 744 : 8031359: Invocable.getInterface() works incorrectly if interface has default methods
Reviewed-by: attila, hannesw
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
47 lines changed: 11 ins; 2 del; 34 mod; 602 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/api/scripting/ScriptObjectMirror.java

rev 737 : 8029364: NashornException to expose thrown object
Reviewed-by: lagergren, jlaskey
rev 752 : 8011964: need indexed access to externally-managed ByteBuffer
Reviewed-by: lagergren, hannesw
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
38 lines changed: 27 ins; 1 del; 10 mod; 728 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/codegen/Attr.java

rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
6 lines changed: 3 ins; 0 del; 3 mod; 1941 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/codegen/CodeGenerator.java

rev 747 : 8031983: Error objects should capture stack at the constructor
Reviewed-by: jlaskey, hannesw
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
5 lines changed: 0 ins; 2 del; 3 mod; 3279 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/codegen/CodeGeneratorLexicalContext.java

rev 738 : 8030182: scopeCall with -1 as line number
Reviewed-by: hannesw, jlaskey
2 lines changed: 0 ins; 0 del; 2 mod; 233 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/codegen/Compiler.java

rev 750 : 8032068: implement @sourceURL and #sourceURL directives
Reviewed-by: hannesw, lagergren
4 lines changed: 3 ins; 0 del; 1 mod; 629 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/codegen/CompilerConstants.java

rev 738 : 8030182: scopeCall with -1 as line number
Reviewed-by: hannesw, jlaskey
rev 739 : 8030809: Anonymous functions should not be shown with internal names in script stack trace
Reviewed-by: lagergren, hannesw, jlaskey
13 lines changed: 6 ins; 0 del; 7 mod; 661 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/codegen/ConstantData.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
48 lines changed: 47 ins; 0 del; 1 mod; 164 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/codegen/MethodEmitter.java

rev 736 : 8029031: "ant clean jar" on nashorn repo results in number of ASM deprecated warnings
Reviewed-by: lagergren, jlaskey, hannesw
5 lines changed: 4 ins; 0 del; 1 mod; 2191 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/codegen/SharedScopeCall.java

rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
1 line changed: 0 ins; 0 del; 1 mod; 194 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/codegen/types/Type.java

rev 736 : 8029031: "ant clean jar" on nashorn repo results in number of ASM deprecated warnings
Reviewed-by: lagergren, jlaskey, hannesw
1 line changed: 0 ins; 0 del; 1 mod; 878 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/ir/FunctionNode.java

rev 750 : 8032068: implement @sourceURL and #sourceURL directives
Reviewed-by: hannesw, lagergren
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
67 lines changed: 54 ins; 0 del; 13 mod; 874 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java

rev 754 : 8030197: Nashorn: Object.defineProperty() can be lured to change fixed NaN property
Reviewed-by: attila, jlaskey
rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
17 lines changed: 12 ins; 4 del; 1 mod; 207 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/ArrayBufferView.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
5 lines changed: 0 ins; 4 del; 1 mod; 392 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/DataPropertyDescriptor.java

rev 754 : 8030197: Nashorn: Object.defineProperty() can be lured to change fixed NaN property
Reviewed-by: attila, jlaskey
rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
18 lines changed: 13 ins; 4 del; 1 mod; 194 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/GenericPropertyDescriptor.java

rev 754 : 8030197: Nashorn: Object.defineProperty() can be lured to change fixed NaN property
Reviewed-by: attila, jlaskey
rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
22 lines changed: 17 ins; 4 del; 1 mod; 167 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/Global.java

rev 749 : 8032060: PropertyMap of Error objects is not stable
Reviewed-by: jlaskey, hannesw
rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
rev 759 : 8015958: DataView constructor is not defined
Reviewed-by: attila, hannesw, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
445 lines changed: 144 ins; 261 del; 40 mod; 1789 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeArguments.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
3 lines changed: 0 ins; 0 del; 3 mod; 343 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeArray.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
5 lines changed: 0 ins; 4 del; 1 mod; 1415 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeArrayBuffer.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 759 : 8015958: DataView constructor is not defined
Reviewed-by: attila, hannesw, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
18 lines changed: 13 ins; 4 del; 1 mod; 126 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeBoolean.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
18 lines changed: 9 ins; 4 del; 5 mod; 175 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeDate.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
5 lines changed: 0 ins; 4 del; 1 mod; 1347 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeDebug.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
5 lines changed: 0 ins; 1 del; 4 mod; 222 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeError.java

rev 747 : 8031983: Error objects should capture stack at the constructor
Reviewed-by: jlaskey, hannesw
rev 748 : 8032004: instance property "message" of Error objects should be non-enumerable
Reviewed-by: hannesw, jlaskey
rev 749 : 8032060: PropertyMap of Error objects is not stable
Reviewed-by: jlaskey, hannesw
rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
47 lines changed: 29 ins; 5 del; 13 mod; 363 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeEvalError.java

rev 747 : 8031983: Error objects should capture stack at the constructor
Reviewed-by: jlaskey, hannesw
rev 748 : 8032004: instance property "message" of Error objects should be non-enumerable
Reviewed-by: hannesw, jlaskey
rev 749 : 8032060: PropertyMap of Error objects is not stable
Reviewed-by: jlaskey, hannesw
rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
11 lines changed: 5 ins; 3 del; 3 mod; 96 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeJSAdapter.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
11 lines changed: 0 ins; 4 del; 7 mod; 740 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeJavaImporter.java

rev 746 : 8031715: Indexed access to java package not working
Reviewed-by: lagergren, hannesw
rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
10 lines changed: 5 ins; 4 del; 1 mod; 165 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeMath.java

rev 745 : 8029332: Do not require nasgen-generated functions to return Object
Reviewed-by: lagergren, jlaskey, hannesw
18 lines changed: 0 ins; 0 del; 18 mod; 685 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeNumber.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
18 lines changed: 9 ins; 4 del; 5 mod; 375 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeObject.java

rev 752 : 8011964: need indexed access to externally-managed ByteBuffer
Reviewed-by: lagergren, hannesw
23 lines changed: 23 ins; 0 del; 0 mod; 756 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeRangeError.java

rev 747 : 8031983: Error objects should capture stack at the constructor
Reviewed-by: jlaskey, hannesw
rev 748 : 8032004: instance property "message" of Error objects should be non-enumerable
Reviewed-by: hannesw, jlaskey
rev 749 : 8032060: PropertyMap of Error objects is not stable
Reviewed-by: jlaskey, hannesw
rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
11 lines changed: 5 ins; 3 del; 3 mod; 96 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeReferenceError.java

rev 747 : 8031983: Error objects should capture stack at the constructor
Reviewed-by: jlaskey, hannesw
rev 748 : 8032004: instance property "message" of Error objects should be non-enumerable
Reviewed-by: hannesw, jlaskey
rev 749 : 8032060: PropertyMap of Error objects is not stable
Reviewed-by: jlaskey, hannesw
rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
11 lines changed: 5 ins; 3 del; 3 mod; 96 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeRegExp.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
5 lines changed: 0 ins; 4 del; 1 mod; 926 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
5 lines changed: 0 ins; 4 del; 1 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeStrictArguments.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
3 lines changed: 0 ins; 0 del; 3 mod; 150 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeString.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
18 lines changed: 9 ins; 4 del; 5 mod; 1251 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeSyntaxError.java

rev 747 : 8031983: Error objects should capture stack at the constructor
Reviewed-by: jlaskey, hannesw
rev 748 : 8032004: instance property "message" of Error objects should be non-enumerable
Reviewed-by: hannesw, jlaskey
rev 749 : 8032060: PropertyMap of Error objects is not stable
Reviewed-by: jlaskey, hannesw
rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
11 lines changed: 5 ins; 3 del; 3 mod; 94 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeTypeError.java

rev 747 : 8031983: Error objects should capture stack at the constructor
Reviewed-by: jlaskey, hannesw
rev 748 : 8032004: instance property "message" of Error objects should be non-enumerable
Reviewed-by: hannesw, jlaskey
rev 749 : 8032060: PropertyMap of Error objects is not stable
Reviewed-by: jlaskey, hannesw
rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
11 lines changed: 5 ins; 3 del; 3 mod; 92 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/NativeURIError.java

rev 747 : 8031983: Error objects should capture stack at the constructor
Reviewed-by: jlaskey, hannesw
rev 748 : 8032004: instance property "message" of Error objects should be non-enumerable
Reviewed-by: hannesw, jlaskey
rev 749 : 8032060: PropertyMap of Error objects is not stable
Reviewed-by: jlaskey, hannesw
rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
11 lines changed: 5 ins; 3 del; 3 mod; 91 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/PrototypeObject.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
7 lines changed: 0 ins; 5 del; 2 mod; 113 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
55 lines changed: 8 ins; 28 del; 19 mod; 258 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/parser/AbstractParser.java

rev 750 : 8032068: implement @sourceURL and #sourceURL directives
Reviewed-by: hannesw, lagergren
27 lines changed: 25 ins; 0 del; 2 mod; 469 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/parser/Lexer.java

rev 750 : 8032068: implement @sourceURL and #sourceURL directives
Reviewed-by: hannesw, lagergren
10 lines changed: 9 ins; 0 del; 1 mod; 1730 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/parser/Parser.java

rev 739 : 8030809: Anonymous functions should not be shown with internal names in script stack trace
Reviewed-by: lagergren, hannesw, jlaskey
rev 743 : 8031317: SyntaxError when property setter has no parameter
Reviewed-by: lagergren, hannesw
rev 750 : 8032068: implement @sourceURL and #sourceURL directives
Reviewed-by: hannesw, lagergren
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
24 lines changed: 17 ins; 0 del; 7 mod; 2991 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/parser/TokenType.java

rev 750 : 8032068: implement @sourceURL and #sourceURL directives
Reviewed-by: hannesw, lagergren
8 lines changed: 4 ins; 0 del; 4 mod; 289 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/AccessorProperty.java

rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
8 lines changed: 4 ins; 0 del; 4 mod; 507 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/Context.java

rev 749 : 8032060: PropertyMap of Error objects is not stable
Reviewed-by: jlaskey, hannesw
rev 753 : 8033924: Default permissions are not given for eval code
Reviewed-by: lagergren, jlaskey
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
rev 759 : 8015958: DataView constructor is not defined
Reviewed-by: attila, hannesw, lagergren
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
143 lines changed: 81 ins; 28 del; 34 mod; 925 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/DebuggerSupport.java

rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
2 lines changed: 0 ins; 0 del; 2 mod; 328 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/ECMAErrors.java

rev 738 : 8030182: scopeCall with -1 as line number
Reviewed-by: hannesw, jlaskey
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
31 lines changed: 2 ins; 0 del; 29 mod; 386 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/ECMAException.java

rev 737 : 8029364: NashornException to expose thrown object
Reviewed-by: lagergren, jlaskey
rev 747 : 8031983: Error objects should capture stack at the constructor
Reviewed-by: jlaskey, hannesw
rev 749 : 8032060: PropertyMap of Error objects is not stable
Reviewed-by: jlaskey, hannesw
40 lines changed: 32 ins; 2 del; 6 mod; 254 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/FinalScriptFunctionData.java

rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
17 lines changed: 0 ins; 4 del; 13 mod; 84 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/FindProperty.java

rev 742 : 8029667: Prototype linking is incorrect
Reviewed-by: jlaskey, sundar
16 lines changed: 15 ins; 0 del; 1 mod; 175 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/JSONFunctions.java

rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
11 lines changed: 1 ins; 0 del; 10 mod; 212 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/JSType.java

rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
5 lines changed: 1 ins; 0 del; 4 mod; 1070 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/ListAdapter.java

rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
7 lines changed: 1 ins; 0 del; 6 mod; 448 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/NativeJavaPackage.java

rev 746 : 8031715: Indexed access to java package not working
Reviewed-by: lagergren, hannesw
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
34 lines changed: 19 ins; 9 del; 6 mod; 214 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/ParserException.java

rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
2 lines changed: 1 ins; 0 del; 1 mod; 116 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/Property.java

rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
15 lines changed: 14 ins; 0 del; 1 mod; 535 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/PropertyDescriptor.java

rev 754 : 8030197: Nashorn: Object.defineProperty() can be lured to change fixed NaN property
Reviewed-by: attila, jlaskey
7 lines changed: 7 ins; 0 del; 0 mod; 155 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/PropertyMap.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
322 lines changed: 106 ins; 173 del; 43 mod; 790 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
75 lines changed: 33 ins; 14 del; 28 mod; 393 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/ScriptFunction.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
42 lines changed: 15 ins; 10 del; 17 mod; 623 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/ScriptFunctionData.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
70 lines changed: 41 ins; 8 del; 21 mod; 698 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/ScriptLoader.java

rev 753 : 8033924: Default permissions are not given for eval code
Reviewed-by: lagergren, jlaskey
3 lines changed: 0 ins; 1 del; 2 mod; 75 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/ScriptObject.java

rev 741 : 8029003: setField in ScriptObject is incorrect for non extensible objects
Reviewed-by: lagergren, jlaskey
rev 742 : 8029667: Prototype linking is incorrect
Reviewed-by: jlaskey, sundar
rev 746 : 8031715: Indexed access to java package not working
Reviewed-by: lagergren, hannesw
rev 754 : 8030197: Nashorn: Object.defineProperty() can be lured to change fixed NaN property
Reviewed-by: attila, jlaskey
rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
213 lines changed: 107 ins; 55 del; 51 mod; 3232 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/ScriptRuntime.java

rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
1 line changed: 0 ins; 0 del; 1 mod; 968 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/SetMethodCreator.java

rev 742 : 8029667: Prototype linking is incorrect
Reviewed-by: jlaskey, sundar
rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
24 lines changed: 3 ins; 14 del; 7 mod; 188 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/UserAccessorProperty.java

rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
3 lines changed: 1 ins; 0 del; 2 mod; 241 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/WithObject.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
16 lines changed: 6 ins; 3 del; 7 mod; 320 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/arrays/ArrayData.java

rev 752 : 8011964: need indexed access to externally-managed ByteBuffer
Reviewed-by: lagergren, hannesw
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
13 lines changed: 11 ins; 0 del; 2 mod; 543 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/arrays/FrozenArrayFilter.java

rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
3 lines changed: 1 ins; 1 del; 1 mod; 80 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/arrays/SealedArrayFilter.java

rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
3 lines changed: 1 ins; 1 del; 1 mod; 66 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java

rev 736 : 8029031: "ant clean jar" on nashorn repo results in number of ASM deprecated warnings
Reviewed-by: lagergren, jlaskey, hannesw
rev 744 : 8031359: Invocable.getInterface() works incorrectly if interface has default methods
Reviewed-by: attila, hannesw
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
35 lines changed: 10 ins; 0 del; 25 mod; 978 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java

rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
4 lines changed: 1 ins; 1 del; 2 mod; 341 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/linker/NashornGuards.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
75 lines changed: 71 ins; 0 del; 4 mod; 108 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/linker/NashornPrimitiveLinker.java

rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
3 lines changed: 1 ins; 1 del; 1 mod; 174 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java

rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
21 lines changed: 17 ins; 0 del; 4 mod; 110 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/linker/ReflectionCheckLinker.java

rev 740 : 8031106: Nashorn: IndexOutOfBoundsException in NashornCallSiteDescriptor.getNameToken()
Reviewed-by: hannesw, jlaskey
2 lines changed: 1 ins; 0 del; 1 mod; 111 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/resources/Messages.properties

rev 752 : 8011964: need indexed access to externally-managed ByteBuffer
Reviewed-by: lagergren, hannesw
rev 759 : 8015958: DataView constructor is not defined
Reviewed-by: attila, hannesw, lagergren
5 lines changed: 5 ins; 0 del; 0 mod; 157 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/scripts/JO.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
1 line changed: 0 ins; 0 del; 1 mod; 74 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/tools/Shell.java

rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
10 lines changed: 1 ins; 0 del; 9 mod; 451 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/script/basic/JDK-8025515.js

rev 739 : 8030809: Anonymous functions should not be shown with internal names in script stack trace
Reviewed-by: lagergren, hannesw, jlaskey
16 lines changed: 10 ins; 0 del; 6 mod; 52 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/script/basic/NASHORN-111.js.EXPECTED

rev 748 : 8032004: instance property "message" of Error objects should be non-enumerable
Reviewed-by: hannesw, jlaskey
1 line changed: 0 ins; 0 del; 1 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/script/basic/NASHORN-441.js.EXPECTED

rev 747 : 8031983: Error objects should capture stack at the constructor
Reviewed-by: jlaskey, hannesw
1 line changed: 0 ins; 0 del; 1 mod; 16 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/src/jdk/nashorn/api/scripting/InvocableTest.java

rev 744 : 8031359: Invocable.getInterface() works incorrectly if interface has default methods
Reviewed-by: attila, hannesw
13 lines changed: 13 ins; 0 del; 0 mod; 525 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/src/jdk/nashorn/api/scripting/ScopeTest.java

rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
316 lines changed: 316 ins; 0 del; 0 mod; 248 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

rev 753 : 8033924: Default permissions are not given for eval code
Reviewed-by: lagergren, jlaskey
41 lines changed: 41 ins; 0 del; 0 mod; 570 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/src/jdk/nashorn/api/scripting/ScriptObjectMirrorTest.java

rev 752 : 8011964: need indexed access to externally-managed ByteBuffer
Reviewed-by: lagergren, hannesw
24 lines changed: 24 ins; 0 del; 0 mod; 255 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/src/jdk/nashorn/internal/codegen/CompilerTest.java

rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
3 lines changed: 1 ins; 0 del; 2 mod; 194 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/src/jdk/nashorn/internal/performance/PerformanceWrapper.java

rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
3 lines changed: 1 ins; 1 del; 1 mod; 153 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/src/jdk/nashorn/internal/runtime/ContextTest.java

rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
3 lines changed: 1 ins; 0 del; 2 mod; 112 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/src/jdk/nashorn/internal/test/framework/SharedContextEvaluator.java

rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
4 lines changed: 1 ins; 1 del; 2 mod; 150 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/jdk/nashorn/internal/objects/NativeDataView.java

rev 759 : 8015958: DataView constructor is not defined
Reviewed-by: attila, hannesw, lagergren
1015 lines changed: 1015 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/jdk/nashorn/internal/runtime/PropertyListeners.java

rev 755 : 8035948: Redesign property listeners for shared classes
Reviewed-by: sundar, lagergren
222 lines changed: 222 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/jdk/nashorn/internal/runtime/arrays/ByteBufferArrayData.java

rev 752 : 8011964: need indexed access to externally-managed ByteBuffer
Reviewed-by: lagergren, hannesw
rev 760 : 8037400: Remove getInitialMap getters and GlobalObject interface
Reviewed-by: lagergren, jlaskey, attila
204 lines changed: 204 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8011964.js

rev 752 : 8011964: need indexed access to externally-managed ByteBuffer
Reviewed-by: lagergren, hannesw
60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8011964.js.EXPECTED

rev 752 : 8011964: need indexed access to externally-managed ByteBuffer
Reviewed-by: lagergren, hannesw
20 lines changed: 20 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8029364.js

rev 737 : 8029364: NashornException to expose thrown object
Reviewed-by: lagergren, jlaskey
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8029364.js.EXPECTED

rev 737 : 8029364: NashornException to expose thrown object
Reviewed-by: lagergren, jlaskey
7 lines changed: 7 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8029667.js

rev 742 : 8029667: Prototype linking is incorrect
Reviewed-by: jlaskey, sundar
91 lines changed: 91 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8029667.js.EXPECTED

rev 742 : 8029667: Prototype linking is incorrect
Reviewed-by: jlaskey, sundar
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8030182.js

rev 738 : 8030182: scopeCall with -1 as line number
Reviewed-by: hannesw, jlaskey
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8030182.js.EXPECTED

rev 738 : 8030182: scopeCall with -1 as line number
Reviewed-by: hannesw, jlaskey
3 lines changed: 3 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8030182_2.js

rev 738 : 8030182: scopeCall with -1 as line number
Reviewed-by: hannesw, jlaskey
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8030182_2.js.EXPECTED

rev 738 : 8030182: scopeCall with -1 as line number
Reviewed-by: hannesw, jlaskey
3 lines changed: 3 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8030197.js

rev 754 : 8030197: Nashorn: Object.defineProperty() can be lured to change fixed NaN property
Reviewed-by: attila, jlaskey
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8030809.js

rev 739 : 8030809: Anonymous functions should not be shown with internal names in script stack trace
Reviewed-by: lagergren, hannesw, jlaskey
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8030809.js.EXPECTED

rev 739 : 8030809: Anonymous functions should not be shown with internal names in script stack trace
Reviewed-by: lagergren, hannesw, jlaskey
4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8031317.js

rev 743 : 8031317: SyntaxError when property setter has no parameter
Reviewed-by: lagergren, hannesw
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8031317.js.EXPECTED

rev 743 : 8031317: SyntaxError when property setter has no parameter
Reviewed-by: lagergren, hannesw
2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8031359.js

rev 744 : 8031359: Invocable.getInterface() works incorrectly if interface has default methods
Reviewed-by: attila, hannesw
62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8031359.js.EXPECTED

rev 744 : 8031359: Invocable.getInterface() works incorrectly if interface has default methods
Reviewed-by: attila, hannesw
6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8031715.js

rev 746 : 8031715: Indexed access to java package not working
Reviewed-by: lagergren, hannesw
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8031715.js.EXPECTED

rev 746 : 8031715: Indexed access to java package not working
Reviewed-by: lagergren, hannesw
11 lines changed: 11 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8031983.js

rev 747 : 8031983: Error objects should capture stack at the constructor
Reviewed-by: jlaskey, hannesw
55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8031983.js.EXPECTED

rev 747 : 8031983: Error objects should capture stack at the constructor
Reviewed-by: jlaskey, hannesw
9 lines changed: 9 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8032004.js

rev 748 : 8032004: instance property "message" of Error objects should be non-enumerable
Reviewed-by: hannesw, jlaskey
43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8032068.js

rev 750 : 8032068: implement @sourceURL and #sourceURL directives
Reviewed-by: hannesw, lagergren
56 lines changed: 56 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8032068.js.EXPECTED

rev 750 : 8032068: implement @sourceURL and #sourceURL directives
Reviewed-by: hannesw, lagergren
14 lines changed: 14 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8034055.js

rev 757 : 8034055: delete on global object not properly guarded
Reviewed-by: sundar, lagergren
55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8034055.js.EXPECTED

rev 757 : 8034055: delete on global object not properly guarded
Reviewed-by: sundar, lagergren
16 lines changed: 16 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/dataview_endian.js

rev 759 : 8015958: DataView constructor is not defined
Reviewed-by: attila, hannesw, lagergren
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/dataview_getset.js

rev 759 : 8015958: DataView constructor is not defined
Reviewed-by: attila, hannesw, lagergren
93 lines changed: 93 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/basic/dataview_new.js

rev 759 : 8015958: DataView constructor is not defined
Reviewed-by: attila, hannesw, lagergren
71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/currently-failing/gettersetter.js

rev 751 : 8033763: Add tests to assert map identity of certain objects
Reviewed-by: hannesw, lagergren
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/maptests/builtins.js

rev 751 : 8033763: Add tests to assert map identity of certain objects
Reviewed-by: hannesw, lagergren
58 lines changed: 58 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/maptests/constructor.js

rev 751 : 8033763: Add tests to assert map identity of certain objects
Reviewed-by: hannesw, lagergren
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/maptests/maputil.js

rev 751 : 8033763: Add tests to assert map identity of certain objects
Reviewed-by: hannesw, lagergren
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/maptests/object_create.js

rev 751 : 8033763: Add tests to assert map identity of certain objects
Reviewed-by: hannesw, lagergren
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/maptests/object_literals.js

rev 751 : 8033763: Add tests to assert map identity of certain objects
Reviewed-by: hannesw, lagergren
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/maptests/point.js

rev 751 : 8033763: Add tests to assert map identity of certain objects
Reviewed-by: hannesw, lagergren
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/maptests/property_add.js

rev 751 : 8033763: Add tests to assert map identity of certain objects
Reviewed-by: hannesw, lagergren
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/maptests/property_delete.js

rev 751 : 8033763: Add tests to assert map identity of certain objects
Reviewed-by: hannesw, lagergren
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/maptests/proto.js

rev 751 : 8033763: Add tests to assert map identity of certain objects
Reviewed-by: hannesw, lagergren
56 lines changed: 56 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/sandbox/JDK-8031106.js

rev 740 : 8031106: Nashorn: IndexOutOfBoundsException in NashornCallSiteDescriptor.getNameToken()
Reviewed-by: hannesw, jlaskey
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/sandbox/safeprops.js

rev 753 : 8033924: Default permissions are not given for eval code
Reviewed-by: lagergren, jlaskey
65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/script/trusted/JDK-8032060.js

rev 749 : 8032060: PropertyMap of Error objects is not stable
Reviewed-by: jlaskey, hannesw
72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/src/jdk/nashorn/api/scripting/resources/func.js

rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/src/jdk/nashorn/api/scripting/resources/gettersetter.js

rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/src/jdk/nashorn/api/scripting/resources/witheval.js

rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- ----- --- src/jdk/nashorn/internal/runtime/GlobalObject.java

rev 758 : 8021350: Share script classes between threads/globals within context
Reviewed-by: lagergren, sundar
244 lines changed: 0 ins; 244 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- ----- --- src/jdk/nashorn/internal/runtime/PropertyListener.java

66 lines changed: 0 ins; 66 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- ----- --- src/jdk/nashorn/internal/runtime/PropertyListenerManager.java

179 lines changed: 0 ins; 179 del; 0 mod; 0 unchg

This code review page was prepared using /home/sundar/src/jdk8-tl/make/scripts/webrev.ksh (vers 25.1-hg+openjdk.java.net).