Code Review for open

Prepared by:thartmann on Tue Dec 18 11:43:17 CET 2018
Workspace:/oracle/valhallaL/open
Compare against: ssh://hg.openjdk.java.net/valhalla/valhalla
Branch:lworld
Summary of changes: 1941 lines changed: 891 ins; 322 del; 728 mod; 144463 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/frame_x86.cpp

28 lines changed: 23 ins; 2 del; 3 mod; 701 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/frame_x86.hpp

3 lines changed: 3 ins; 0 del; 0 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/globals_x86.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/interp_masm_x86.cpp

20 lines changed: 11 ins; 6 del; 3 mod; 2065 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/interp_masm_x86.hpp

2 lines changed: 0 ins; 1 del; 1 mod; 300 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/macroAssembler_x86.cpp

278 lines changed: 277 ins; 0 del; 1 mod; 9826 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/macroAssembler_x86.hpp

14 lines changed: 13 ins; 0 del; 1 mod; 1777 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/methodHandles_x86.cpp

5 lines changed: 4 ins; 0 del; 1 mod; 641 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp

142 lines changed: 57 ins; 39 del; 46 mod; 4354 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp

12 lines changed: 2 ins; 7 del; 3 mod; 1935 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/templateTable_x86.cpp

1 line changed: 0 ins; 0 del; 1 mod; 4838 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/x86_32.ad

4 lines changed: 0 ins; 3 del; 1 mod; 13617 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/x86_64.ad

48 lines changed: 22 ins; 23 del; 3 mod; 13115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/aot/aotCompiledMethod.hpp

1 line changed: 1 ins; 0 del; 0 mod; 316 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/asm/codeBuffer.hpp

2 lines changed: 2 ins; 0 del; 0 mod; 673 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/c1/c1_LIRAssembler.cpp

1 line changed: 1 ins; 0 del; 0 mod; 865 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciEnv.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1332 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classFileParser.cpp

14 lines changed: 4 ins; 7 del; 3 mod; 6775 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/code/codeBlob.cpp

6 lines changed: 0 ins; 0 del; 6 mod; 697 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/code/codeBlob.hpp

4 lines changed: 1 ins; 0 del; 3 mod; 755 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/code/compiledMethod.cpp

20 lines changed: 0 ins; 15 del; 5 mod; 607 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/code/compiledMethod.hpp

1 line changed: 1 ins; 0 del; 0 mod; 413 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/code/nmethod.cpp

16 lines changed: 7 ins; 6 del; 3 mod; 3014 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/code/nmethod.hpp

2 lines changed: 2 ins; 0 del; 0 mod; 662 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/compiler/compileBroker.cpp

12 lines changed: 0 ins; 12 del; 0 mod; 2746 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciCodeInstaller.cpp

1 line changed: 1 ins; 0 del; 0 mod; 1362 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/method.cpp

15 lines changed: 8 ins; 1 del; 6 mod; 2440 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/method.hpp

7 lines changed: 4 ins; 1 del; 2 mod; 1185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/valueKlass.cpp

68 lines changed: 4 ins; 31 del; 33 mod; 547 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/valueKlass.hpp

8 lines changed: 0 ins; 4 del; 4 mod; 250 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/callGenerator.cpp

42 lines changed: 14 ins; 13 del; 15 mod; 1441 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/callnode.hpp

3 lines changed: 0 ins; 0 del; 3 mod; 1168 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/chaitin.cpp

3 lines changed: 3 ins; 0 del; 0 mod; 2411 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/compile.cpp

30 lines changed: 29 ins; 0 del; 1 mod; 4754 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/compile.hpp

10 lines changed: 10 ins; 0 del; 0 mod; 1376 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/connode.cpp

1 line changed: 0 ins; 1 del; 0 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/escape.cpp

3 lines changed: 0 ins; 2 del; 1 mod; 3602 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/graphKit.cpp

31 lines changed: 16 ins; 10 del; 5 mod; 4388 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/machnode.hpp

20 lines changed: 19 ins; 0 del; 1 mod; 1105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/macro.cpp

11 lines changed: 2 ins; 3 del; 6 mod; 2900 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/matcher.cpp

11 lines changed: 11 ins; 0 del; 0 mod; 2720 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/memnode.cpp

1 line changed: 0 ins; 1 del; 0 mod; 4913 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/node.hpp

3 lines changed: 3 ins; 0 del; 0 mod; 1751 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/output.cpp

24 lines changed: 23 ins; 0 del; 1 mod; 2909 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/parse1.cpp

85 lines changed: 22 ins; 32 del; 31 mod; 2509 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/type.cpp

49 lines changed: 23 ins; 13 del; 13 mod; 5687 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/type.hpp

2 lines changed: 0 ins; 1 del; 1 mod; 1926 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/valuetypenode.cpp

49 lines changed: 33 ins; 4 del; 12 mod; 884 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/valuetypenode.hpp

3 lines changed: 0 ins; 1 del; 2 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/arguments.cpp

14 lines changed: 8 ins; 4 del; 2 mod; 4214 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/deoptimization.cpp

12 lines changed: 0 ins; 3 del; 9 mod; 2452 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/globals.hpp

6 lines changed: 3 ins; 0 del; 3 mod; 2791 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/safepoint.cpp

17 lines changed: 7 ins; 0 del; 10 mod; 1407 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/sharedRuntime.cpp

199 lines changed: 78 ins; 59 del; 62 mod; 3396 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/sharedRuntime.hpp

32 lines changed: 21 ins; 2 del; 9 mod; 723 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/signature.cpp

60 lines changed: 41 ins; 0 del; 19 mod; 532 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/signature.hpp

11 lines changed: 7 ins; 0 del; 4 mod; 476 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/globalDefinitions.cpp

10 lines changed: 0 ins; 5 del; 5 mod; 367 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/globalDefinitions.hpp

8 lines changed: 0 ins; 6 del; 2 mod; 1347 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/valhalla/valuetypes/TestBasicFunctionality.java

19 lines changed: 12 ins; 0 del; 7 mod; 752 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/valhalla/valuetypes/TestCallingConvention.java

418 lines changed: 51 ins; 0 del; 367 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/valhalla/valuetypes/TestMethodHandles.java

4 lines changed: 4 ins; 0 del; 0 mod; 500 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/valhalla/valuetypes/TestUnresolvedValueClass.java

5 lines changed: 0 ins; 4 del; 1 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/valhalla/valuetypes/ValueTypeTest.java

7 lines changed: 3 ins; 0 del; 4 mod; 528 unchg

This code review page was prepared using /home/tobias/programs/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).