< prev index next >

test/compiler/jvmci/compilerToVM/AllocateCompileIdTest.java

Print this page
rev 9252 : 8138810: rework tests for CompilerToVM::allocateCompiledId

*** 32,77 **** * sun.hotspot.WhiteBox$WhiteBoxPermission * jdk.vm.ci.hotspot.CompilerToVMHelper * @run main/othervm -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI * -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xbootclasspath/a:. * -XX:-BackgroundCompilation - -XX:+LogCompilation * compiler.jvmci.compilerToVM.AllocateCompileIdTest */ package compiler.jvmci.compilerToVM; import compiler.jvmci.common.CTVMUtilities; import java.lang.reflect.Executable; import java.lang.reflect.Method; import java.util.ArrayList; - import java.util.HashMap; import java.util.List; - import java.util.Map; import java.util.HashSet; - import compiler.jvmci.common.testcases.TestCase; import jdk.vm.ci.hotspot.CompilerToVMHelper; import jdk.vm.ci.hotspot.HotSpotResolvedJavaMethod; import jdk.test.lib.Asserts; import jdk.test.lib.Pair; import jdk.test.lib.Utils; - import sun.hotspot.WhiteBox; import sun.hotspot.code.NMethod; public class AllocateCompileIdTest { private final HashSet<Integer> ids = new HashSet<>(); public static void main(String[] args) { AllocateCompileIdTest test = new AllocateCompileIdTest(); createTestCasesCorrectBci().forEach(test::runSanityCorrectTest); createTestCasesIncorrectBci().forEach(test::runSanityIncorrectTest); } - private static List<CompileCodeTestCase> createTestCasesCorrectBci() { List<CompileCodeTestCase> result = new ArrayList<>(); try { Class<?> aClass = DummyClass.class; Method method = aClass.getMethod("withLoop"); --- 32,74 ---- * sun.hotspot.WhiteBox$WhiteBoxPermission * jdk.vm.ci.hotspot.CompilerToVMHelper * @run main/othervm -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI * -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xbootclasspath/a:. * -XX:-BackgroundCompilation * compiler.jvmci.compilerToVM.AllocateCompileIdTest */ package compiler.jvmci.compilerToVM; import compiler.jvmci.common.CTVMUtilities; import java.lang.reflect.Executable; import java.lang.reflect.Method; import java.util.ArrayList; import java.util.List; import java.util.HashSet; + import java.util.stream.Collectors; + import java.util.stream.Stream; import jdk.vm.ci.hotspot.CompilerToVMHelper; import jdk.vm.ci.hotspot.HotSpotResolvedJavaMethod; import jdk.test.lib.Asserts; import jdk.test.lib.Pair; import jdk.test.lib.Utils; import sun.hotspot.code.NMethod; public class AllocateCompileIdTest { + private static final int SOME_REPEAT_VALUE = 5; private final HashSet<Integer> ids = new HashSet<>(); public static void main(String[] args) { AllocateCompileIdTest test = new AllocateCompileIdTest(); createTestCasesCorrectBci().forEach(test::runSanityCorrectTest); createTestCasesIncorrectBci().forEach(test::runSanityIncorrectTest); } private static List<CompileCodeTestCase> createTestCasesCorrectBci() { List<CompileCodeTestCase> result = new ArrayList<>(); try { Class<?> aClass = DummyClass.class; Method method = aClass.getMethod("withLoop");
*** 82,145 **** throw new Error("TEST BUG : " + e, e); } return result; } - private static List<Pair<CompileCodeTestCase, Class<? extends Throwable>>> createTestCasesIncorrectBci() { List<Pair<CompileCodeTestCase, Class<? extends Throwable>>> result = new ArrayList<>(); - try { Class<?> aClass = DummyClass.class; Object receiver = new DummyClass(); Method method = aClass.getMethod("dummyInstanceFunction"); // greater than bytecode.length ! int[] bcis = new int[] {30, 50, 200}; ! for (int bci : bcis) { ! result.add(new Pair<>( ! new CompileCodeTestCase(receiver, method, bci), ! IllegalArgumentException.class)); ! } ! bcis = new int[] {-4, -50, -200}; ! for (int bci : bcis) { ! result.add(new Pair<>( new CompileCodeTestCase(receiver, method, bci), ! IllegalArgumentException.class)); ! } } catch (NoSuchMethodException e) { throw new Error("TEST BUG : " + e.getMessage(), e); } return result; } private void runSanityCorrectTest(CompileCodeTestCase testCase) { System.out.println(testCase); Executable aMethod = testCase.executable; // to generate ciTypeFlow ! System.out.println(testCase.invoke(Utils.getNullValues(aMethod.getParameterTypes()))); int bci = testCase.bci; HotSpotResolvedJavaMethod method = CTVMUtilities .getResolvedMethod(aMethod); int wbCompileID = getWBCompileID(testCase); int id = CompilerToVMHelper.allocateCompileId(method, bci); Asserts.assertNE(id, 0, testCase + " : zero compile id"); - - if (wbCompileID > 0) { Asserts.assertGT(id, wbCompileID, testCase + " : allocated 'compile id' not greater than existed"); ! if (!ids.add(wbCompileID)) { ! throw new AssertionError(String.format( ! "%s : vm compilation allocated existed id -- %d", ! testCase, id)); ! } ! } ! if (!ids.add(id)) { ! throw new AssertionError(String.format( ! "%s : allocateCompileId returned existed id %d", ! testCase, id)); } } private void runSanityIncorrectTest( Pair<CompileCodeTestCase, Class<? extends Throwable>> testCase) { --- 79,135 ---- throw new Error("TEST BUG : " + e, e); } return result; } private static List<Pair<CompileCodeTestCase, Class<? extends Throwable>>> createTestCasesIncorrectBci() { List<Pair<CompileCodeTestCase, Class<? extends Throwable>>> result = new ArrayList<>(); try { Class<?> aClass = DummyClass.class; Object receiver = new DummyClass(); Method method = aClass.getMethod("dummyInstanceFunction"); // greater than bytecode.length ! byte[] bytecode = CompilerToVMHelper.getBytecode(CTVMUtilities ! .getResolvedMethod(method)); ! Stream.of( ! // greater than bytecode.length ! bytecode.length + 4, ! bytecode.length + 50, ! bytecode.length + 200, ! // negative cases ! -4, -50, -200) ! .map(bci -> new Pair<CompileCodeTestCase, ! Class<? extends Throwable>>( new CompileCodeTestCase(receiver, method, bci), ! IllegalArgumentException.class)) ! .collect(Collectors.toList()); } catch (NoSuchMethodException e) { throw new Error("TEST BUG : " + e.getMessage(), e); } return result; } private void runSanityCorrectTest(CompileCodeTestCase testCase) { System.out.println(testCase); Executable aMethod = testCase.executable; // to generate ciTypeFlow ! testCase.invoke(Utils.getNullValues(aMethod.getParameterTypes())); int bci = testCase.bci; HotSpotResolvedJavaMethod method = CTVMUtilities .getResolvedMethod(aMethod); + for (int i = 0; i < SOME_REPEAT_VALUE; ++i) { int wbCompileID = getWBCompileID(testCase); int id = CompilerToVMHelper.allocateCompileId(method, bci); Asserts.assertNE(id, 0, testCase + " : zero compile id"); Asserts.assertGT(id, wbCompileID, testCase + " : allocated 'compile id' not greater than existed"); ! Asserts.assertTrue(ids.add(wbCompileID), testCase ! + " : vm compilation allocated existed id " + id); ! Asserts.assertTrue(ids.add(id), testCase ! + " : allocateCompileId returned existed id " + id); } } private void runSanityIncorrectTest( Pair<CompileCodeTestCase, Class<? extends Throwable>> testCase) {
*** 154,164 **** exception); } private int getWBCompileID(CompileCodeTestCase testCase) { NMethod nm = testCase.deoptimizeAndCompile(); ! if (nm == null) { ! throw new Error("[TEST BUG] cannot compile method " + testCase); } return nm.compile_id; } } --- 144,154 ---- exception); } private int getWBCompileID(CompileCodeTestCase testCase) { NMethod nm = testCase.deoptimizeAndCompile(); ! if (nm == null || nm.compile_id <= 0) { ! throw new Error("TEST BUG : cannot compile method " + testCase); } return nm.compile_id; } }
< prev index next >