--- old/src/share/classes/java/lang/ref/ReferenceQueue.java 2013-06-19 13:10:09.392217543 +0200 +++ new/src/share/classes/java/lang/ref/ReferenceQueue.java 2013-06-19 13:10:09.292217544 +0200 @@ -58,6 +58,13 @@ synchronized (r) { if (r.queue == ENQUEUED) return false; synchronized (lock) { + // There is a race between this method and the polling: it may occur + // that one thread just successfully removed a Reference from the queue, + // making it inactive, and another thread calling this method on this + // queue with the same Reference instance. Filter out those attempts. + if (r.queue != this) { + return false; + } r.queue = ENQUEUED; r.next = (head == null) ? r : head; head = r; --- /dev/null 2013-06-19 08:52:55.996443996 +0200 +++ new/test/java/lang/ref/EnqueuePollRace.java 2013-06-19 13:10:09.696217540 +0200 @@ -0,0 +1,72 @@ +/* + * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* @test + * @bug 8014890 + * @summary Verify that a race between ReferenceQueue.enqueue() and poll() does not occur. + * @author thomas.schatzl@oracle.com + */ + +import java.lang.ref.*; + +public class EnqueuePollRace { + + public static void main(String args[]) throws Exception { + new WeakRef().run(); + System.out.println("Test passed."); + } + + static class WeakRef { + ReferenceQueue queue = new ReferenceQueue(); + final int numReferences = 100; + final Reference refs[] = new Reference[numReferences]; + final int iterations = 1000; + + void run() throws InterruptedException { + for (int i = 0; i < iterations; i++) { + queue = new ReferenceQueue(); + + for (int j = 0; j < refs.length; j++) { + refs[j] = new WeakReference(new Object(), queue); + } + + System.gc(); // enqueues references into the list of discovered references + + // now manually enqueue all of them + for (int j = 0; j < refs.length; j++) { + refs[j].enqueue(); + } + // and get them back. There should be exactly numReferences + // entries in the queue now. + int foundReferences = 0; + while (queue.poll() != null) { + foundReferences++; + } + + if (foundReferences != refs.length) { + throw new RuntimeException("Got " + foundReferences + " references in the queue, but expected " + refs.length); + } + } + } + } +}