src/share/vm/gc_implementation/g1/dirtyCardQueue.hpp

Print this page
rev 6283 : 8019342: G1: High "Other" time most likely due to card redirtying
Summary: Parallelize card redirtying to decrease the time it takes.
Reviewed-by: tbd, tbd
rev 6284 : [mq]: fixes-cleanup


  56                      uint worker_i = 0);
  57 
  58   // Apply the closure to all elements of "buf", down to "index"
  59   // (inclusive.)  If returns "false", then a closure application returned
  60   // "false", and we return immediately.  If "consume" is true, entries are
  61   // set to NULL as they are processed, so they will not be processed again
  62   // later.
  63   static bool apply_closure_to_buffer(CardTableEntryClosure* cl,
  64                                       void** buf, size_t index, size_t sz,
  65                                       bool consume = true,
  66                                       uint worker_i = 0);
  67   void **get_buf() { return _buf;}
  68   void set_buf(void **buf) {_buf = buf;}
  69   size_t get_index() { return _index;}
  70   void reinitialize() { _buf = 0; _sz = 0; _index = 0;}
  71 };
  72 
  73 
  74 
  75 class DirtyCardQueueSet: public PtrQueueSet {
  76   CardTableEntryClosure* _closure;

  77 
  78   DirtyCardQueue _shared_dirty_card_queue;
  79 
  80   // Override.
  81   bool mut_process_buffer(void** buf);
  82 
  83   // Protected by the _cbl_mon.
  84   FreeIdSet* _free_ids;
  85 
  86   // The number of completed buffers processed by mutator and rs thread,
  87   // respectively.
  88   jint _processed_buffers_mut;
  89   jint _processed_buffers_rs_thread;
  90 


  91 public:
  92   DirtyCardQueueSet(bool notify_when_complete = true);
  93 
  94   void initialize(Monitor* cbl_mon, Mutex* fl_lock,
  95                   int process_completed_threshold,
  96                   int max_completed_queue,
  97                   Mutex* lock, PtrQueueSet* fl_owner = NULL);
  98 
  99   // The number of parallel ids that can be claimed to allow collector or
 100   // mutator threads to do card-processing work.
 101   static uint num_par_ids();
 102 
 103   static void handle_zero_index_for_thread(JavaThread* t);
 104 
 105   // Register "blk" as "the closure" for all queues.  Only one such closure
 106   // is allowed.  The "apply_closure_to_completed_buffer" method will apply
 107   // this closure to a completed buffer, and "iterate_closure_all_threads"
 108   // applies it to partially-filled buffers (the latter should only be done
 109   // with the world stopped).
 110   void set_closure(CardTableEntryClosure* closure);
 111 
 112   // If there is a registered closure for buffers, apply it to all entries
 113   // in all currently-active buffers.  This should only be applied at a
 114   // safepoint.  (Currently must not be called in parallel; this should
 115   // change in the future.)  If "consume" is true, processed entries are
 116   // discarded.
 117   void iterate_closure_all_threads(bool consume = true,
 118                                    uint worker_i = 0);
 119 
 120   // If there exists some completed buffer, pop it, then apply the
 121   // registered closure to all its elements, nulling out those elements
 122   // processed.  If all elements are processed, returns "true".  If no
 123   // completed buffers exist, returns false.  If a completed buffer exists,
 124   // but is only partially completed before a "yield" happens, the
 125   // partially completed buffer (with its processed elements set to NULL)
 126   // is returned to the completed buffer set, and this call returns false.
 127   bool apply_closure_to_completed_buffer(uint worker_i = 0,
 128                                          int stop_at = 0,
 129                                          bool during_pause = false);
 130 
 131   // If there exists some completed buffer, pop it, then apply the
 132   // specified closure to all its elements, nulling out those elements
 133   // processed.  If all elements are processed, returns "true".  If no
 134   // completed buffers exist, returns false.  If a completed buffer exists,
 135   // but is only partially completed before a "yield" happens, the
 136   // partially completed buffer (with its processed elements set to NULL)
 137   // is returned to the completed buffer set, and this call returns false.
 138   bool apply_closure_to_completed_buffer(CardTableEntryClosure* cl,
 139                                          uint worker_i = 0,
 140                                          int stop_at = 0,
 141                                          bool during_pause = false);
 142 
 143   // Helper routine for the above.
 144   bool apply_closure_to_completed_buffer_helper(CardTableEntryClosure* cl,
 145                                                 uint worker_i,
 146                                                 BufferNode* nd);
 147 
 148   BufferNode* get_completed_buffer(int stop_at);
 149 
 150   // Applies the current closure to all completed buffers,
 151   // non-consumptively.
 152   void apply_closure_to_all_completed_buffers();





 153 
 154   DirtyCardQueue* shared_dirty_card_queue() {
 155     return &_shared_dirty_card_queue;
 156   }
 157 
 158   // Deallocate any completed log buffers
 159   void clear();
 160 
 161   // If a full collection is happening, reset partial logs, and ignore
 162   // completed ones: the full collection will make them all irrelevant.
 163   void abandon_logs();
 164 
 165   // If any threads have partial logs, add them to the global list of logs.
 166   void concatenate_logs();
 167   void clear_n_completed_buffers() { _n_completed_buffers = 0;}
 168 
 169   jint processed_buffers_mut() {
 170     return _processed_buffers_mut;
 171   }
 172   jint processed_buffers_rs_thread() {


  56                      uint worker_i = 0);
  57 
  58   // Apply the closure to all elements of "buf", down to "index"
  59   // (inclusive.)  If returns "false", then a closure application returned
  60   // "false", and we return immediately.  If "consume" is true, entries are
  61   // set to NULL as they are processed, so they will not be processed again
  62   // later.
  63   static bool apply_closure_to_buffer(CardTableEntryClosure* cl,
  64                                       void** buf, size_t index, size_t sz,
  65                                       bool consume = true,
  66                                       uint worker_i = 0);
  67   void **get_buf() { return _buf;}
  68   void set_buf(void **buf) {_buf = buf;}
  69   size_t get_index() { return _index;}
  70   void reinitialize() { _buf = 0; _sz = 0; _index = 0;}
  71 };
  72 
  73 
  74 
  75 class DirtyCardQueueSet: public PtrQueueSet {
  76   // The closure used for 
  77   CardTableEntryClosure* _mut_process_closure;
  78 
  79   DirtyCardQueue _shared_dirty_card_queue;
  80 
  81   // Override.
  82   bool mut_process_buffer(void** buf);
  83 
  84   // Protected by the _cbl_mon.
  85   FreeIdSet* _free_ids;
  86 
  87   // The number of completed buffers processed by mutator and rs thread,
  88   // respectively.
  89   jint _processed_buffers_mut;
  90   jint _processed_buffers_rs_thread;
  91 
  92   // Current buffer node used for parallel iteration.
  93   BufferNode* volatile _cur_par_buffer_node;
  94 public:
  95   DirtyCardQueueSet(bool notify_when_complete = true);
  96 
  97   void initialize(CardTableEntryClosure* cl, Monitor* cbl_mon, Mutex* fl_lock,
  98                   int process_completed_threshold,
  99                   int max_completed_queue,
 100                   Mutex* lock, PtrQueueSet* fl_owner = NULL);
 101 
 102   // The number of parallel ids that can be claimed to allow collector or
 103   // mutator threads to do card-processing work.
 104   static uint num_par_ids();
 105 
 106   static void handle_zero_index_for_thread(JavaThread* t);
 107 
 108   // Apply the given closure to all entries in all currently-active buffers.
 109   // This should only be applied at a safepoint. (Currently must not be called
 110   // in parallel; this should change in the future.)  If "consume" is true,
 111   // processed entries are discarded.
 112   void iterate_closure_all_threads(CardTableEntryClosure* cl,
 113                                    bool consume = true,







 114                                    uint worker_i = 0);
 115 
 116   // If there exists some completed buffer, pop it, then apply the











 117   // specified closure to all its elements, nulling out those elements
 118   // processed.  If all elements are processed, returns "true".  If no
 119   // completed buffers exist, returns false.  If a completed buffer exists,
 120   // but is only partially completed before a "yield" happens, the
 121   // partially completed buffer (with its processed elements set to NULL)
 122   // is returned to the completed buffer set, and this call returns false.
 123   bool apply_closure_to_completed_buffer(CardTableEntryClosure* cl,
 124                                          uint worker_i = 0,
 125                                          int stop_at = 0,
 126                                          bool during_pause = false);
 127 
 128   // Helper routine for the above.
 129   bool apply_closure_to_completed_buffer_helper(CardTableEntryClosure* cl,
 130                                                 uint worker_i,
 131                                                 BufferNode* nd);
 132 
 133   BufferNode* get_completed_buffer(int stop_at);
 134 
 135   // Applies the current closure to all completed buffers,
 136   // non-consumptively.
 137   void apply_closure_to_all_completed_buffers(CardTableEntryClosure* cl);
 138 
 139   void reset_for_par_iteration() { _cur_par_buffer_node = _completed_buffers_head; }
 140   // Applies the current closure to all completed buffers, non-consumptively.
 141   // Parallel version.
 142   void par_apply_closure_to_all_completed_buffers(CardTableEntryClosure* cl);
 143 
 144   DirtyCardQueue* shared_dirty_card_queue() {
 145     return &_shared_dirty_card_queue;
 146   }
 147 
 148   // Deallocate any completed log buffers
 149   void clear();
 150 
 151   // If a full collection is happening, reset partial logs, and ignore
 152   // completed ones: the full collection will make them all irrelevant.
 153   void abandon_logs();
 154 
 155   // If any threads have partial logs, add them to the global list of logs.
 156   void concatenate_logs();
 157   void clear_n_completed_buffers() { _n_completed_buffers = 0;}
 158 
 159   jint processed_buffers_mut() {
 160     return _processed_buffers_mut;
 161   }
 162   jint processed_buffers_rs_thread() {