--- old/src/share/vm/gc_implementation/g1/g1PageBasedVirtualSpace.hpp 2015-01-29 10:54:37.278570302 +0100 +++ new/src/share/vm/gc_implementation/g1/g1PageBasedVirtualSpace.hpp 2015-01-29 10:54:37.196567907 +0100 @@ -34,6 +34,11 @@ // granularity. // (De-)Allocation requests are always OS page aligned by passing a page index // and multiples of pages. +// We only support reservations which base address is aligned to a given commit +// size. The length of the area managed need not commit size aligned (but OS default +// page size aligned) because some OSes cannot provide a an os_commit_size aligned +// reservation without also being size-aligned. Any tail area is committed using OS +// small pages. // The implementation gives an error when trying to commit or uncommit pages that // have already been committed or uncommitted. class G1PageBasedVirtualSpace VALUE_OBJ_CLASS_SPEC { @@ -43,8 +48,8 @@ char* _low_boundary; char* _high_boundary; - // The commit/uncommit granularity in bytes. - size_t _page_size; + // The preferred commit/uncommit granularity in bytes. + size_t _commit_size; // Bitmap used for verification of commit/uncommit operations. BitMap _committed; @@ -62,12 +67,19 @@ // Indicates whether the committed space should be executable. bool _executable; + // Commit the given memory range by using _commit_size pages as much as possible + // and the remainder with small sized pages. The start address must be _commit_size + // aligned. + void commit_int(char* start, char* end); + // Uncommit the given memory range. + void uncommit_int(char* start, char* end); + // Returns the index of the page which contains the given address. uintptr_t addr_to_page_index(char* addr) const; // Returns the address of the given page index. char* page_start(uintptr_t index); - // Returns the byte size of the given number of pages. - size_t byte_size_for_pages(size_t num); + // Returns the address of the given page index ranging from 0..size_in_pages-1. + char* page_end(uintptr_t index); // Returns true if the entire area is backed by committed memory. bool is_area_committed(uintptr_t start, size_t size_in_pages) const; @@ -85,7 +97,9 @@ // Initialization G1PageBasedVirtualSpace(); - bool initialize_with_granularity(ReservedSpace rs, size_t page_size); + // Initialize the given reserved space with the given base address and actual size. + // Prefer to commit in commit_size chunks. + bool initialize_with_granularity(ReservedSpace rs, size_t actual_size, size_t commit_size); // Destruction ~G1PageBasedVirtualSpace();