Code Review for hotspot

Prepared by:tschatzl on Mon Oct 6 14:22:22 CEST 2014
Workspace:/home/tschatzl/Downloads/vmshare/8056956/hs-gc/hotspot
Compare against: http://hg.openjdk.java.net/jdk9/hs-gc/hotspot
Compare against version:-2
Summary of changes: 28 lines changed: 13 ins; 0 del; 15 mod; 16137 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/concurrentMark.cpp

rev 7147 : 8059758: Startup benchmark performance and footprint regressions with JDK-8038423
Summary: Changes in JDK-8038423 always initialize (zeroes out) virtual memory used for auxiliary data structures. This causes a footprint and performance regression for G1 in startup benchmarks. This is because they do not touch that memory at all, so the operating system does not actually commit these pages. The fix is to, if the initialization value of the data structures matches the default value of just committed memory (=0), do not do anything.
Reviewed-by: tbd
4 lines changed: 3 ins; 0 del; 1 mod; 4817 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/concurrentMark.hpp

rev 7147 : 8059758: Startup benchmark performance and footprint regressions with JDK-8038423
Summary: Changes in JDK-8038423 always initialize (zeroes out) virtual memory used for auxiliary data structures. This causes a footprint and performance regression for G1 in startup benchmarks. This is because they do not touch that memory at all, so the operating system does not actually commit these pages. The fix is to, if the initialization value of the data structures matches the default value of just committed memory (=0), do not do anything.
Reviewed-by: tbd
1 line changed: 0 ins; 0 del; 1 mod; 1261 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1BlockOffsetTable.hpp

rev 7147 : 8059758: Startup benchmark performance and footprint regressions with JDK-8038423
Summary: Changes in JDK-8038423 always initialize (zeroes out) virtual memory used for auxiliary data structures. This causes a footprint and performance regression for G1 in startup benchmarks. This is because they do not touch that memory at all, so the operating system does not actually commit these pages. The fix is to, if the initialization value of the data structures matches the default value of just committed memory (=0), do not do anything.
Reviewed-by: tbd
1 line changed: 0 ins; 0 del; 1 mod; 372 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1CardCounts.cpp

rev 7147 : 8059758: Startup benchmark performance and footprint regressions with JDK-8038423
Summary: Changes in JDK-8038423 always initialize (zeroes out) virtual memory used for auxiliary data structures. This causes a footprint and performance regression for G1 in startup benchmarks. This is because they do not touch that memory at all, so the operating system does not actually commit these pages. The fix is to, if the initialization value of the data structures matches the default value of just committed memory (=0), do not do anything.
Reviewed-by: tbd
4 lines changed: 3 ins; 0 del; 1 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1CardCounts.hpp

rev 7147 : 8059758: Startup benchmark performance and footprint regressions with JDK-8038423
Summary: Changes in JDK-8038423 always initialize (zeroes out) virtual memory used for auxiliary data structures. This causes a footprint and performance regression for G1 in startup benchmarks. This is because they do not touch that memory at all, so the operating system does not actually commit these pages. The fix is to, if the initialization value of the data structures matches the default value of just committed memory (=0), do not do anything.
Reviewed-by: tbd
1 line changed: 0 ins; 0 del; 1 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp

3 lines changed: 2 ins; 0 del; 1 mod; 7025 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp

rev 7147 : 8059758: Startup benchmark performance and footprint regressions with JDK-8038423
Summary: Changes in JDK-8038423 always initialize (zeroes out) virtual memory used for auxiliary data structures. This causes a footprint and performance regression for G1 in startup benchmarks. This is because they do not touch that memory at all, so the operating system does not actually commit these pages. The fix is to, if the initialization value of the data structures matches the default value of just committed memory (=0), do not do anything.
Reviewed-by: tbd
1 line changed: 0 ins; 0 del; 1 mod; 1721 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1RegionToSpaceMapper.cpp

rev 7147 : 8059758: Startup benchmark performance and footprint regressions with JDK-8038423
Summary: Changes in JDK-8038423 always initialize (zeroes out) virtual memory used for auxiliary data structures. This causes a footprint and performance regression for G1 in startup benchmarks. This is because they do not touch that memory at all, so the operating system does not actually commit these pages. The fix is to, if the initialization value of the data structures matches the default value of just committed memory (=0), do not do anything.
Reviewed-by: tbd
6 lines changed: 2 ins; 0 del; 4 mod; 155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1RegionToSpaceMapper.hpp

rev 7147 : 8059758: Startup benchmark performance and footprint regressions with JDK-8038423
Summary: Changes in JDK-8038423 always initialize (zeroes out) virtual memory used for auxiliary data structures. This causes a footprint and performance regression for G1 in startup benchmarks. This is because they do not touch that memory at all, so the operating system does not actually commit these pages. The fix is to, if the initialization value of the data structures matches the default value of just committed memory (=0), do not do anything.
Reviewed-by: tbd
4 lines changed: 2 ins; 0 del; 2 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp

2 lines changed: 1 ins; 0 del; 1 mod; 256 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.hpp

rev 7147 : 8059758: Startup benchmark performance and footprint regressions with JDK-8038423
Summary: Changes in JDK-8038423 always initialize (zeroes out) virtual memory used for auxiliary data structures. This causes a footprint and performance regression for G1 in startup benchmarks. This is because they do not touch that memory at all, so the operating system does not actually commit these pages. The fix is to, if the initialization value of the data structures matches the default value of just committed memory (=0), do not do anything.
Reviewed-by: tbd
1 line changed: 0 ins; 0 del; 1 mod; 180 unchg

This code review page was prepared using ../../../tools/webrev.sh (vers 23.18-hg).