< prev index next >

src/share/vm/gc/g1/concurrentMarkThread.cpp

Print this page
rev 10464 : imported patch 8151126-clean-up-duplicate-code-for-clearing-bitmaps
rev 10465 : [mq]: 8151614-improve-concurrent-mark-logging


  75   CMCleanUp(G1ConcurrentMark* cm) :
  76     _cm(cm) {}
  77 
  78   void do_void(){
  79     _cm->cleanup();
  80   }
  81 };
  82 
  83 // Marking pauses can be scheduled flexibly, so we might delay marking to meet MMU.
  84 void ConcurrentMarkThread::delay_to_keep_mmu(G1CollectorPolicy* g1_policy, bool remark) {
  85   if (g1_policy->adaptive_young_list_length()) {
  86     double now = os::elapsedTime();
  87     double prediction_ms = remark ? g1_policy->predict_remark_time_ms()
  88                                   : g1_policy->predict_cleanup_time_ms();
  89     G1MMUTracker *mmu_tracker = g1_policy->mmu_tracker();
  90     jlong sleep_time_ms = mmu_tracker->when_ms(now, prediction_ms);
  91     os::sleep(this, sleep_time_ms, false);
  92   }
  93 }
  94 
  95 class GCConcPhaseTimer : StackObj {
  96   G1ConcurrentMark* _cm;
  97 
  98  public:
  99   GCConcPhaseTimer(G1ConcurrentMark* cm, const char* title) : _cm(cm) {


 100     _cm->register_concurrent_phase_start(title);
 101   }
 102 
 103   ~GCConcPhaseTimer() {
 104     _cm->register_concurrent_phase_end();
 105   }
 106 };
 107 
 108 void ConcurrentMarkThread::run() {
 109   initialize_in_thread();
 110   wait_for_universe_init();
 111 
 112   run_service();
 113 
 114   terminate();
 115 }
 116 
 117 void ConcurrentMarkThread::run_service() {
 118   _vtime_start = os::elapsedVTime();
 119 
 120   G1CollectedHeap* g1h = G1CollectedHeap::heap();
 121   G1CollectorPolicy* g1_policy = g1h->g1_policy();
 122 
 123   while (!_should_terminate) {
 124     // wait until started is set.
 125     sleepBeforeNextCycle();
 126     if (_should_terminate) {
 127       _cm->root_regions()->cancel_scan();
 128       break;
 129     }
 130 
 131     assert(GCId::current() != GCId::undefined(), "GC id should have been set up by the initial mark GC.");
 132     {
 133       ResourceMark rm;
 134       HandleMark   hm;
 135       double cycle_start = os::elapsedVTime();
 136 
 137       {
 138         GCConcPhaseTimer(_cm, "Concurrent Clearing of Claimed Marks");
 139         ClassLoaderDataGraph::clear_claimed_marks();
 140       }
 141 
 142       // We have to ensure that we finish scanning the root regions
 143       // before the next GC takes place. To ensure this we have to
 144       // make sure that we do not join the STS until the root regions
 145       // have been scanned. If we did then it's possible that a
 146       // subsequent GC could block us from joining the STS and proceed
 147       // without the root regions have been scanned which would be a
 148       // correctness issue.
 149 
 150       {
 151         GCConcPhaseTimer(_cm, "Concurrent Root Region Scanning");
 152         _cm->scanRootRegions();
 153       }
 154 
 155       // It would be nice to use the GCTraceConcTime class here but
 156       // the "end" logging is inside the loop and not at the end of
 157       // a scope. Mimicking the same log output as GCTraceConcTime instead.
 158       jlong mark_start = os::elapsed_counter();
 159       log_info(gc)("Concurrent Mark (%.3fs)", TimeHelper::counter_to_seconds(mark_start));
 160 
 161       int iter = 0;
 162       do {
 163         iter++;
 164         if (!cm()->has_aborted()) {
 165           GCConcPhaseTimer(_cm, "Concurrent Mark");
 166           _cm->markFromRoots();
 167         }
 168 
 169         double mark_end_time = os::elapsedVTime();
 170         jlong mark_end = os::elapsed_counter();
 171         _vtime_mark_accum += (mark_end_time - cycle_start);
 172         if (!cm()->has_aborted()) {
 173           delay_to_keep_mmu(g1_policy, true /* remark */);
 174           log_info(gc)("Concurrent Mark (%.3fs, %.3fs) %.3fms",
 175                        TimeHelper::counter_to_seconds(mark_start),
 176                        TimeHelper::counter_to_seconds(mark_end),
 177                        TimeHelper::counter_to_millis(mark_end - mark_start));
 178 
 179           CMCheckpointRootsFinalClosure final_cl(_cm);
 180           VM_CGC_Operation op(&final_cl, "Pause Remark", true /* needs_pll */);
 181           VMThread::execute(&op);
 182         }
 183         if (cm()->restart_for_overflow()) {
 184           log_debug(gc)("Restarting conc marking because of MS overflow in remark (restart #%d).", iter);
 185           log_info(gc)("Concurrent Mark restart for overflow");
 186         }
 187       } while (cm()->restart_for_overflow());
 188 
 189       double end_time = os::elapsedVTime();
 190       // Update the total virtual time before doing this, since it will try
 191       // to measure it to get the vtime for this marking.  We purposely
 192       // neglect the presumably-short "completeCleanup" phase here.
 193       _vtime_accum = (end_time - _vtime_start);
 194 
 195       if (!cm()->has_aborted()) {
 196         delay_to_keep_mmu(g1_policy, false /* cleanup */);
 197 
 198         CMCleanUp cl_cl(_cm);
 199         VM_CGC_Operation op(&cl_cl, "Pause Cleanup", false /* needs_pll */);
 200         VMThread::execute(&op);
 201       } else {
 202         // We don't want to update the marking status if a GC pause
 203         // is already underway.
 204         SuspendibleThreadSetJoiner sts_join;
 205         g1h->collector_state()->set_mark_in_progress(false);
 206       }
 207 
 208       // Check if cleanup set the free_regions_coming flag. If it
 209       // hasn't, we can just skip the next step.
 210       if (g1h->free_regions_coming()) {
 211         // The following will finish freeing up any regions that we
 212         // found to be empty during cleanup. We'll do this part
 213         // without joining the suspendible set. If an evacuation pause
 214         // takes place, then we would carry on freeing regions in
 215         // case they are needed by the pause. If a Full GC takes
 216         // place, it would wait for us to process the regions
 217         // reclaimed by cleanup.
 218 
 219         GCTraceConcTime(Info, gc) tt("Concurrent Cleanup");
 220         GCConcPhaseTimer(_cm, "Concurrent Cleanup");
 221 
 222         // Now do the concurrent cleanup operation.
 223         _cm->completeCleanup();
 224 
 225         // Notify anyone who's waiting that there are no more free
 226         // regions coming. We have to do this before we join the STS
 227         // (in fact, we should not attempt to join the STS in the
 228         // interval between finishing the cleanup pause and clearing
 229         // the free_regions_coming flag) otherwise we might deadlock:
 230         // a GC worker could be blocked waiting for the notification
 231         // whereas this thread will be blocked for the pause to finish
 232         // while it's trying to join the STS, which is conditional on
 233         // the GC workers finishing.
 234         g1h->reset_free_regions_coming();
 235       }
 236       guarantee(cm()->cleanup_list_is_empty(),
 237                 "at this point there should be no regions on the cleanup list");
 238 
 239       // There is a tricky race before recording that the concurrent
 240       // cleanup has completed and a potential Full GC starting around
 241       // the same time. We want to make sure that the Full GC calls
 242       // abort() on concurrent mark after
 243       // record_concurrent_mark_cleanup_completed(), since abort() is


 248       // the STS allows the correct ordering of the two methods. There
 249       // are two scenarios:
 250       //
 251       // a) If we reach here before the Full GC, the fact that we have
 252       // joined the STS means that the Full GC cannot start until we
 253       // leave the STS, so record_concurrent_mark_cleanup_completed()
 254       // will complete before abort() is called.
 255       //
 256       // b) If we reach here during the Full GC, we'll be held up from
 257       // joining the STS until the Full GC is done, which means that
 258       // abort() will have completed and has_aborted() will return
 259       // true to prevent us from calling
 260       // record_concurrent_mark_cleanup_completed() (and, in fact, it's
 261       // not needed any more as the concurrent mark state has been
 262       // already reset).
 263       {
 264         SuspendibleThreadSetJoiner sts_join;
 265         if (!cm()->has_aborted()) {
 266           g1_policy->record_concurrent_mark_cleanup_completed();
 267         } else {
 268           log_info(gc)("Concurrent Mark abort");
 269         }
 270       }
 271 
 272       // We now want to allow clearing of the marking bitmap to be
 273       // suspended by a collection pause.
 274       // We may have aborted just before the remark. Do not bother clearing the
 275       // bitmap then, as it has been done during mark abort.
 276       if (!cm()->has_aborted()) {
 277         GCConcPhaseTimer(_cm, "Concurrent Bitmap Clearing");
 278         _cm->cleanup_for_next_mark();
 279       } else {
 280         assert(!G1VerifyBitmaps || _cm->nextMarkBitmapIsClear(), "Next mark bitmap must be clear");
 281       }
 282     }
 283 
 284     // Update the number of full collections that have been
 285     // completed. This will also notify the FullGCCount_lock in case a
 286     // Java thread is waiting for a full GC to happen (e.g., it
 287     // called System.gc() with +ExplicitGCInvokesConcurrent).
 288     {
 289       SuspendibleThreadSetJoiner sts_join;
 290       g1h->increment_old_marking_cycles_completed(true /* concurrent */);
 291       g1h->register_concurrent_cycle_end();
 292     }
 293   }
 294 }
 295 
 296 void ConcurrentMarkThread::stop() {
 297   {




  75   CMCleanUp(G1ConcurrentMark* cm) :
  76     _cm(cm) {}
  77 
  78   void do_void(){
  79     _cm->cleanup();
  80   }
  81 };
  82 
  83 // Marking pauses can be scheduled flexibly, so we might delay marking to meet MMU.
  84 void ConcurrentMarkThread::delay_to_keep_mmu(G1CollectorPolicy* g1_policy, bool remark) {
  85   if (g1_policy->adaptive_young_list_length()) {
  86     double now = os::elapsedTime();
  87     double prediction_ms = remark ? g1_policy->predict_remark_time_ms()
  88                                   : g1_policy->predict_cleanup_time_ms();
  89     G1MMUTracker *mmu_tracker = g1_policy->mmu_tracker();
  90     jlong sleep_time_ms = mmu_tracker->when_ms(now, prediction_ms);
  91     os::sleep(this, sleep_time_ms, false);
  92   }
  93 }
  94 
  95 class G1ConcPhaseTimer : public GCTraceConcTimeImpl<LogLevel::Info, LogTag::_gc, LogTag::_marking> {
  96   G1ConcurrentMark* _cm;
  97 
  98  public:
  99   G1ConcPhaseTimer(G1ConcurrentMark* cm, const char* title) :
 100      GCTraceConcTimeImpl<LogLevel::Info,  LogTag::_gc, LogTag::_marking>(title),
 101      _cm(cm) {
 102     _cm->register_concurrent_phase_start(title);
 103   }
 104 
 105   ~G1ConcPhaseTimer() {
 106     _cm->register_concurrent_phase_end();
 107   }
 108 };
 109 
 110 void ConcurrentMarkThread::run() {
 111   initialize_in_thread();
 112   wait_for_universe_init();
 113 
 114   run_service();
 115 
 116   terminate();
 117 }
 118 
 119 void ConcurrentMarkThread::run_service() {
 120   _vtime_start = os::elapsedVTime();
 121 
 122   G1CollectedHeap* g1h = G1CollectedHeap::heap();
 123   G1CollectorPolicy* g1_policy = g1h->g1_policy();
 124 
 125   while (!_should_terminate) {
 126     // wait until started is set.
 127     sleepBeforeNextCycle();
 128     if (_should_terminate) {
 129       _cm->root_regions()->cancel_scan();
 130       break;
 131     }
 132 
 133     assert(GCId::current() != GCId::undefined(), "GC id should have been set up by the initial mark GC.");
 134     {
 135       ResourceMark rm;
 136       HandleMark   hm;
 137       double cycle_start = os::elapsedVTime();
 138 
 139       {
 140         G1ConcPhaseTimer t(_cm, "Concurrent Clear Claimed Marks");
 141         ClassLoaderDataGraph::clear_claimed_marks();
 142       }
 143 
 144       // We have to ensure that we finish scanning the root regions
 145       // before the next GC takes place. To ensure this we have to
 146       // make sure that we do not join the STS until the root regions
 147       // have been scanned. If we did then it's possible that a
 148       // subsequent GC could block us from joining the STS and proceed
 149       // without the root regions have been scanned which would be a
 150       // correctness issue.
 151 
 152       {
 153         G1ConcPhaseTimer t(_cm, "Concurrent Scan Root Regions");
 154         _cm->scan_root_regions();
 155       }
 156 
 157       // It would be nice to use the GCTraceConcTime class here but
 158       // the "end" logging is inside the loop and not at the end of
 159       // a scope. Mimicking the same log output as GCTraceConcTime instead.
 160       jlong mark_start = os::elapsed_counter();
 161       log_info(gc, marking)("Concurrent Mark (%.3fs)", TimeHelper::counter_to_seconds(mark_start));
 162 
 163       int iter = 0;
 164       do {
 165         iter++;
 166         if (!cm()->has_aborted()) {
 167           G1ConcPhaseTimer t(_cm, "Concurrent Mark From Roots");
 168           _cm->mark_from_roots();
 169         }
 170 
 171         double mark_end_time = os::elapsedVTime();
 172         jlong mark_end = os::elapsed_counter();
 173         _vtime_mark_accum += (mark_end_time - cycle_start);
 174         if (!cm()->has_aborted()) {
 175           delay_to_keep_mmu(g1_policy, true /* remark */);
 176           log_info(gc, marking)("Concurrent Mark (%.3fs, %.3fs) %.3fms",
 177                                 TimeHelper::counter_to_seconds(mark_start),
 178                                 TimeHelper::counter_to_seconds(mark_end),
 179                                 TimeHelper::counter_to_millis(mark_end - mark_start));
 180 
 181           CMCheckpointRootsFinalClosure final_cl(_cm);
 182           VM_CGC_Operation op(&final_cl, "Pause Remark", true /* needs_pll */);
 183           VMThread::execute(&op);
 184         }
 185         if (cm()->restart_for_overflow()) {
 186           log_debug(gc, marking)("Restarting Concurrent Marking because of Mark Stack Overflow in Remark (Iteration #%d).", iter);
 187           log_info(gc, marking)("Concurrent Mark Restart due to overflow");
 188         }
 189       } while (cm()->restart_for_overflow());
 190 
 191       double end_time = os::elapsedVTime();
 192       // Update the total virtual time before doing this, since it will try
 193       // to measure it to get the vtime for this marking.  We purposely
 194       // neglect the presumably-short "completeCleanup" phase here.
 195       _vtime_accum = (end_time - _vtime_start);
 196 
 197       if (!cm()->has_aborted()) {
 198         delay_to_keep_mmu(g1_policy, false /* cleanup */);
 199 
 200         CMCleanUp cl_cl(_cm);
 201         VM_CGC_Operation op(&cl_cl, "Pause Cleanup", false /* needs_pll */);
 202         VMThread::execute(&op);
 203       } else {
 204         // We don't want to update the marking status if a GC pause
 205         // is already underway.
 206         SuspendibleThreadSetJoiner sts_join;
 207         g1h->collector_state()->set_mark_in_progress(false);
 208       }
 209 
 210       // Check if cleanup set the free_regions_coming flag. If it
 211       // hasn't, we can just skip the next step.
 212       if (g1h->free_regions_coming()) {
 213         // The following will finish freeing up any regions that we
 214         // found to be empty during cleanup. We'll do this part
 215         // without joining the suspendible set. If an evacuation pause
 216         // takes place, then we would carry on freeing regions in
 217         // case they are needed by the pause. If a Full GC takes
 218         // place, it would wait for us to process the regions
 219         // reclaimed by cleanup.
 220 
 221         G1ConcPhaseTimer t(_cm, "Concurrent Complete Cleanup");

 222 
 223         // Now do the concurrent cleanup operation.
 224         _cm->complete_cleanup();
 225 
 226         // Notify anyone who's waiting that there are no more free
 227         // regions coming. We have to do this before we join the STS
 228         // (in fact, we should not attempt to join the STS in the
 229         // interval between finishing the cleanup pause and clearing
 230         // the free_regions_coming flag) otherwise we might deadlock:
 231         // a GC worker could be blocked waiting for the notification
 232         // whereas this thread will be blocked for the pause to finish
 233         // while it's trying to join the STS, which is conditional on
 234         // the GC workers finishing.
 235         g1h->reset_free_regions_coming();
 236       }
 237       guarantee(cm()->cleanup_list_is_empty(),
 238                 "at this point there should be no regions on the cleanup list");
 239 
 240       // There is a tricky race before recording that the concurrent
 241       // cleanup has completed and a potential Full GC starting around
 242       // the same time. We want to make sure that the Full GC calls
 243       // abort() on concurrent mark after
 244       // record_concurrent_mark_cleanup_completed(), since abort() is


 249       // the STS allows the correct ordering of the two methods. There
 250       // are two scenarios:
 251       //
 252       // a) If we reach here before the Full GC, the fact that we have
 253       // joined the STS means that the Full GC cannot start until we
 254       // leave the STS, so record_concurrent_mark_cleanup_completed()
 255       // will complete before abort() is called.
 256       //
 257       // b) If we reach here during the Full GC, we'll be held up from
 258       // joining the STS until the Full GC is done, which means that
 259       // abort() will have completed and has_aborted() will return
 260       // true to prevent us from calling
 261       // record_concurrent_mark_cleanup_completed() (and, in fact, it's
 262       // not needed any more as the concurrent mark state has been
 263       // already reset).
 264       {
 265         SuspendibleThreadSetJoiner sts_join;
 266         if (!cm()->has_aborted()) {
 267           g1_policy->record_concurrent_mark_cleanup_completed();
 268         } else {
 269           log_info(gc, marking)("Concurrent Mark Abort");
 270         }
 271       }
 272 
 273       // We now want to allow clearing of the marking bitmap to be
 274       // suspended by a collection pause.
 275       // We may have aborted just before the remark. Do not bother clearing the
 276       // bitmap then, as it has been done during mark abort.
 277       if (!cm()->has_aborted()) {
 278         G1ConcPhaseTimer t(_cm, "Concurrent Cleanup for Next Mark");
 279         _cm->cleanup_for_next_mark();
 280       } else {
 281         assert(!G1VerifyBitmaps || _cm->nextMarkBitmapIsClear(), "Next mark bitmap must be clear");
 282       }
 283     }
 284 
 285     // Update the number of full collections that have been
 286     // completed. This will also notify the FullGCCount_lock in case a
 287     // Java thread is waiting for a full GC to happen (e.g., it
 288     // called System.gc() with +ExplicitGCInvokesConcurrent).
 289     {
 290       SuspendibleThreadSetJoiner sts_join;
 291       g1h->increment_old_marking_cycles_completed(true /* concurrent */);
 292       g1h->register_concurrent_cycle_end();
 293     }
 294   }
 295 }
 296 
 297 void ConcurrentMarkThread::stop() {
 298   {


< prev index next >