Code Review for open

Prepared by:tschatzl on Fri Jan 11 12:32:49 CET 2019
Workspace:/home/tschatzl/Downloads/vmshare/jdk10/hs/open
Compare against: http://hg.openjdk.java.net/jdk/jdk
Compare against version:-2
Summary of changes: 582 lines changed: 70 ins; 380 del; 132 mod; 34394 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/stringTable.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
40 lines changed: 0 ins; 39 del; 1 mod; 839 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/stringTable.hpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
11 lines changed: 0 ins; 10 del; 1 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/cmsHeap.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
6 lines changed: 0 ins; 4 del; 2 mod; 265 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/cmsHeap.hpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
3 lines changed: 0 ins; 1 del; 2 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
11 lines changed: 0 ins; 8 del; 3 mod; 8134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/parNewGeneration.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
3 lines changed: 0 ins; 1 del; 2 mod; 1444 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
69 lines changed: 47 ins; 7 del; 15 mod; 4854 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.hpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
7 lines changed: 3 ins; 1 del; 3 mod; 1451 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1ConcurrentMark.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
3 lines changed: 0 ins; 0 del; 3 mod; 3056 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullCollector.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
4 lines changed: 0 ins; 0 del; 4 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullGCAdjustTask.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
11 lines changed: 0 ins; 5 del; 6 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullGCAdjustTask.hpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
3 lines changed: 1 ins; 0 del; 2 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullGCMarkTask.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
9 lines changed: 0 ins; 2 del; 7 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
11 lines changed: 1 ins; 3 del; 7 mod; 586 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
8 lines changed: 0 ins; 3 del; 5 mod; 420 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1HeapVerifier.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
4 lines changed: 0 ins; 2 del; 2 mod; 849 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RootProcessor.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
30 lines changed: 0 ins; 28 del; 2 mod; 288 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RootProcessor.hpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
18 lines changed: 0 ins; 16 del; 2 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1StringDedup.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
51 lines changed: 0 ins; 50 del; 1 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1StringDedup.hpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
30 lines changed: 0 ins; 29 del; 1 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psMarkSweep.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
8 lines changed: 0 ins; 7 del; 1 mod; 666 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psParallelCompact.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
8 lines changed: 0 ins; 7 del; 1 mod; 3159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psScavenge.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
7 lines changed: 0 ins; 6 del; 1 mod; 757 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/genMarkSweep.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
7 lines changed: 0 ins; 6 del; 1 mod; 337 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/genCollectedHeap.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
30 lines changed: 0 ins; 27 del; 3 mod; 1381 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/genCollectedHeap.hpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
9 lines changed: 0 ins; 6 del; 3 mod; 499 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/parallelCleaning.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
40 lines changed: 2 ins; 13 del; 25 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/parallelCleaning.hpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
28 lines changed: 3 ins; 13 del; 12 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/stringdedup/stringDedup.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
6 lines changed: 3 ins; 1 del; 2 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/stringdedup/stringDedup.hpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
19 lines changed: 1 ins; 13 del; 5 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/weakProcessorPhases.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
4 lines changed: 3 ins; 0 del; 1 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/weakProcessorPhases.hpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
2 lines changed: 1 ins; 0 del; 1 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
2 lines changed: 0 ins; 1 del; 1 mod; 2794 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
8 lines changed: 0 ins; 8 del; 0 mod; 268 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/logging/logPrefix.hpp

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
2 lines changed: 0 ins; 1 del; 1 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/TestGCLogMessages.java

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
8 lines changed: 5 ins; 1 del; 2 mod; 288 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/jfr/event/gc/collection/TestG1ParallelPhases.java

rev 53197 : [mq]: 8213229-strings-as-weak-during-young-gc
2 lines changed: 0 ins; 1 del; 1 mod; 181 unchg

------ ------ ------ ------ Old --- Patch --- test/hotspot/jtreg/gc/g1/TestStringTableStats.java

60 lines changed: 0 ins; 60 del; 0 mod; 0 unchg

This code review page was prepared using /home/tschatzl/Downloads/vmshare/tools/webrev.sh (vers 25.6-hg+openjdk.java.net).