Code Review for open

Prepared by:tschatzl on Wed Mar 13 14:03:17 CET 2019
Workspace:/home/tschatzl/Downloads/vmshare/jdk10/hs/open
Compare against: http://hg.openjdk.java.net/jdk/jdk
Compare against version:-2
Summary of changes: 1122 lines changed: 446 ins; 441 del; 235 mod; 17388 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 54081 : imported patch 8220301-remove-jbyte-use-cardtable
rev 54086 : imported patch 8219100-cleanup-young-collection-prologue
rev 54087 : imported patch 8218668-reorganize-collection-set
307 lines changed: 92 ins; 143 del; 72 mod; 4633 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.hpp

rev 54086 : imported patch 8219100-cleanup-young-collection-prologue
rev 54087 : imported patch 8218668-reorganize-collection-set
9 lines changed: 3 ins; 1 del; 5 mod; 1452 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectionSet.cpp

rev 54087 : imported patch 8218668-reorganize-collection-set
256 lines changed: 35 ins; 160 del; 61 mod; 479 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectionSet.hpp

rev 54087 : imported patch 8218668-reorganize-collection-set
168 lines changed: 57 ins; 88 del; 23 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectionSetCandidates.cpp

rev 54087 : imported patch 8218668-reorganize-collection-set
26 lines changed: 0 ins; 19 del; 7 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectionSetCandidates.hpp

rev 54087 : imported patch 8218668-reorganize-collection-set
11 lines changed: 0 ins; 4 del; 7 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1ConcurrentMark.cpp

rev 54086 : imported patch 8219100-cleanup-young-collection-prologue
rev 54087 : imported patch 8218668-reorganize-collection-set
8 lines changed: 1 ins; 0 del; 7 mod; 3048 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1EvacFailure.cpp

rev 54081 : imported patch 8220301-remove-jbyte-use-cardtable
rev 54087 : imported patch 8218668-reorganize-collection-set
2 lines changed: 2 ins; 0 del; 0 mod; 261 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp

rev 54087 : imported patch 8218668-reorganize-collection-set
35 lines changed: 24 ins; 0 del; 11 mod; 585 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp

rev 54087 : imported patch 8218668-reorganize-collection-set
34 lines changed: 16 ins; 9 del; 9 mod; 418 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1HeapVerifier.cpp

rev 54087 : imported patch 8218668-reorganize-collection-set
1 line changed: 1 ins; 0 del; 0 mod; 851 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1OopStarChunkedList.cpp

rev 54087 : imported patch 8218668-reorganize-collection-set
7 lines changed: 2 ins; 0 del; 5 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1OopStarChunkedList.hpp

rev 54087 : imported patch 8218668-reorganize-collection-set
3 lines changed: 0 ins; 0 del; 3 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1OopStarChunkedList.inline.hpp

rev 54087 : imported patch 8218668-reorganize-collection-set
4 lines changed: 3 ins; 0 del; 1 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1ParScanThreadState.cpp

rev 54087 : imported patch 8218668-reorganize-collection-set
1 line changed: 0 ins; 0 del; 1 mod; 429 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Policy.cpp

rev 54086 : imported patch 8219100-cleanup-young-collection-prologue
rev 54087 : imported patch 8218668-reorganize-collection-set
131 lines changed: 125 ins; 0 del; 6 mod; 1220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Policy.hpp

rev 54086 : imported patch 8219100-cleanup-young-collection-prologue
rev 54087 : imported patch 8218668-reorganize-collection-set
22 lines changed: 20 ins; 0 del; 2 mod; 442 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RemSet.cpp

rev 54081 : imported patch 8220301-remove-jbyte-use-cardtable
rev 54083 : imported patch 8220301-kbarrett-review
rev 54084 : imported patch 8220345-use-bool-for-IsDirtyRegionState
rev 54085 : imported patch 8220345-kbarrett-review
rev 54087 : imported patch 8218668-reorganize-collection-set
51 lines changed: 34 ins; 8 del; 9 mod; 1007 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RemSet.hpp

rev 54081 : imported patch 8220301-remove-jbyte-use-cardtable
rev 54083 : imported patch 8220301-kbarrett-review
rev 54087 : imported patch 8218668-reorganize-collection-set
27 lines changed: 15 ins; 9 del; 3 mod; 170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegion.cpp

rev 54087 : imported patch 8218668-reorganize-collection-set
2 lines changed: 1 ins; 0 del; 1 mod; 893 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegion.hpp

rev 54087 : imported patch 8218668-reorganize-collection-set
8 lines changed: 7 ins; 0 del; 1 mod; 723 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/workerDataArray.hpp

rev 54087 : imported patch 8218668-reorganize-collection-set
2 lines changed: 1 ins; 0 del; 1 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/workerDataArray.inline.hpp

rev 54087 : imported patch 8218668-reorganize-collection-set
7 lines changed: 7 ins; 0 del; 0 mod; 180 unchg

This code review page was prepared using /home/tschatzl/Downloads/vmshare/tools/webrev.sh (vers 25.6-hg+openjdk.java.net).