--- old/test/jdk/java/util/stream/test/org/openjdk/tests/java/util/stream/CollectorsTest.java 2018-09-24 17:22:36.491009000 +0700 +++ new/test/jdk/java/util/stream/test/org/openjdk/tests/java/util/stream/CollectorsTest.java 2018-09-24 17:22:36.151009000 +0700 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012, 2015, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2012, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,6 +29,7 @@ import java.util.Comparator; import java.util.HashMap; import java.util.HashSet; +import java.util.IntSummaryStatistics; import java.util.Iterator; import java.util.List; import java.util.Map; @@ -39,6 +40,7 @@ import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentSkipListMap; import java.util.concurrent.atomic.AtomicInteger; +import java.util.function.BiFunction; import java.util.function.BinaryOperator; import java.util.function.Function; import java.util.function.Predicate; @@ -96,7 +98,7 @@ @Override void assertValue(R value, Supplier> source, boolean ordered) throws ReflectiveOperationException { downstream.assertValue(value, - () -> source.get().map(mapper::apply), + () -> source.get().map(mapper), ordered); } } @@ -114,7 +116,7 @@ @Override void assertValue(R value, Supplier> source, boolean ordered) throws ReflectiveOperationException { downstream.assertValue(value, - () -> source.get().flatMap(mapper::apply), + () -> source.get().flatMap(mapper), ordered); } } @@ -287,6 +289,27 @@ } } + static class TeeingAssertion extends CollectorAssertion { + private final Collector c1; + private final Collector c2; + private final BiFunction finisher; + + TeeingAssertion(Collector c1, Collector c2, + BiFunction finisher) { + this.c1 = c1; + this.c2 = c2; + this.finisher = finisher; + } + + @Override + void assertValue(RR value, Supplier> source, boolean ordered) { + R1 r1 = source.get().collect(c1); + R2 r2 = source.get().collect(c2); + RR expected = finisher.apply(r1, r2); + assertEquals(value, expected); + } + } + private ResultAsserter mapTabulationAsserter(boolean ordered) { return (act, exp, ord, par) -> { if (par && (!ordered || !ord)) { @@ -746,4 +769,42 @@ catch (UnsupportedOperationException ignored) { } } + @Test(dataProvider = "StreamTestData", dataProviderClass = StreamTestDataProvider.class) + public void testTeeing(String name, TestData.OfRef data) throws ReflectiveOperationException { + Collector summing = Collectors.summingLong(Integer::valueOf); + Collector counting = Collectors.counting(); + Collector min = collectingAndThen(Collectors.minBy(Comparator.naturalOrder()), + opt -> opt.orElse(Integer.MAX_VALUE)); + Collector max = collectingAndThen(Collectors.maxBy(Comparator.naturalOrder()), + opt -> opt.orElse(Integer.MIN_VALUE)); + Collector joining = mapping(String::valueOf, Collectors.joining(", ", "[", "]")); + + Collector> sumAndCount = Collectors.teeing(summing, counting, Map::entry); + Collector> minAndMax = Collectors.teeing(min, max, Map::entry); + Collector averaging = Collectors.teeing(summing, counting, + (sum, count) -> ((double)sum) / count); + Collector summaryStatistics = Collectors.teeing(sumAndCount, minAndMax, + (sumCountEntry, minMaxEntry) -> new IntSummaryStatistics( + sumCountEntry.getValue(), minMaxEntry.getKey(), + minMaxEntry.getValue(), sumCountEntry.getKey()).toString()); + Collector countAndContent = Collectors.teeing(counting, joining, + (count, content) -> count+": "+content); + + assertCollect(data, sumAndCount, stream -> { + List list = stream.collect(toList()); + return Map.entry(list.stream().mapToLong(Integer::intValue).sum(), (long) list.size()); + }); + assertCollect(data, averaging, stream -> stream.mapToInt(Integer::intValue).average().orElse(Double.NaN)); + assertCollect(data, summaryStatistics, + stream -> stream.mapToInt(Integer::intValue).summaryStatistics().toString()); + assertCollect(data, countAndContent, stream -> { + List list = stream.collect(toList()); + return list.size()+": "+list; + }); + + Function classifier = i -> i % 3; + exerciseMapCollection(data, groupingBy(classifier, sumAndCount), + new GroupingByAssertion<>(classifier, Map.class, + new TeeingAssertion<>(summing, counting, Map::entry))); + } }