6839872

Code Review for 6839872

Prepared by:	twisti on Thu Mar 3 02:25:31 PST 2011
Workspace:	/home/twisti/hotspot-comp/6839872
Compare against:	/home/twisti/hotspot-comp/hotspot
Compare against version:	2142
Summary of changes:	354 lines changed: 233 ins; 48 del; 73 mod; 24835 unchg
Patch of changes:	6839872.patch
Printable review:	6839872.pdf
Author comments:	6839872: remove implementation inheritance from JSR 292 APIs Summary: Move all JSR 292 classes into the java.dyn package. Reviewed-by: Initial versions (including the preview in 7/M3) of the JSR 292 API use an undesirable technique for data structure factoring, implementation inheritance. The types MethodHandle and JavaMethodHandle both inherit from JVM-internal supertypes. The solution is to remove those private supertypes from those public types. This is the JVM part of 6839872. It adds support to the JVM to handle both namespaces, java.dyn/sun.dyn and java.dyn only. The support for the old namespace (AllowTransitionalJSR292) will be removed as soon as the related JDK changes appear in the repositories.
Bug id:	6839872 remove implementation inheritance from JSR 292 APIs
Legend:	Modified file Deleted file New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/classFileParser.cpp

rev 2143 : 6839872: remove implementation inheritance from JSR 292 APIs
Summary: Move all JSR 292 classes into the java.dyn package.
Reviewed-by:

26 lines changed: 14 ins; 3 del; 9 mod; 4628 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/javaClasses.cpp

rev 2143 : 6839872: remove implementation inheritance from JSR 292 APIs
Summary: Move all JSR 292 classes into the java.dyn package.
Reviewed-by:

49 lines changed: 24 ins; 20 del; 5 mod; 3081 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionary.cpp

rev 2143 : 6839872: remove implementation inheritance from JSR 292 APIs
Summary: Move all JSR 292 classes into the java.dyn package.
Reviewed-by:

84 lines changed: 78 ins; 0 del; 6 mod; 2902 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionary.hpp

rev 2143 : 6839872: remove implementation inheritance from JSR 292 APIs
Summary: Move all JSR 292 classes into the java.dyn package.
Reviewed-by:

19 lines changed: 7 ins; 0 del; 12 mod; 670 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/vmSymbols.cpp

rev 2143 : 6839872: remove implementation inheritance from JSR 292 APIs
Summary: Move all JSR 292 classes into the java.dyn package.
Reviewed-by:

7 lines changed: 6 ins; 0 del; 1 mod; 549 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/vmSymbols.hpp

rev 2143 : 6839872: remove implementation inheritance from JSR 292 APIs
Summary: Move all JSR 292 classes into the java.dyn package.
Reviewed-by:

17 lines changed: 8 ins; 0 del; 9 mod; 1085 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/linkResolver.cpp

rev 2143 : 6839872: remove implementation inheritance from JSR 292 APIs
Summary: Move all JSR 292 classes into the java.dyn package.
Reviewed-by:

4 lines changed: 2 ins; 0 del; 2 mod; 1125 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/instanceKlass.hpp

rev 2143 : 6839872: remove implementation inheritance from JSR 292 APIs
Summary: Move all JSR 292 classes into the java.dyn package.
Reviewed-by:

3 lines changed: 0 ins; 0 del; 3 mod; 1037 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/methodOop.cpp

rev 2143 : 6839872: remove implementation inheritance from JSR 292 APIs
Summary: Move all JSR 292 classes into the java.dyn package.
Reviewed-by:

3 lines changed: 1 ins; 0 del; 2 mod; 1588 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/methodHandleWalk.cpp

rev 2143 : 6839872: remove implementation inheritance from JSR 292 APIs
Summary: Move all JSR 292 classes into the java.dyn package.
Reviewed-by:

8 lines changed: 7 ins; 1 del; 0 mod; 1406 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/methodHandles.cpp

rev 2143 : 6839872: remove implementation inheritance from JSR 292 APIs
Summary: Move all JSR 292 classes into the java.dyn package.
Reviewed-by:

92 lines changed: 65 ins; 10 del; 17 mod; 2638 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/nativeLookup.cpp

rev 2143 : 6839872: remove implementation inheritance from JSR 292 APIs
Summary: Move all JSR 292 classes into the java.dyn package.
Reviewed-by:

35 lines changed: 14 ins; 14 del; 7 mod; 298 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/globals.hpp

rev 2143 : 6839872: remove implementation inheritance from JSR 292 APIs
Summary: Move all JSR 292 classes into the java.dyn package.
Reviewed-by:

7 lines changed: 7 ins; 0 del; 0 mod; 3828 unchg

This code review page was prepared using /home/twisti/bin/webrev (vers 23.18-hg-never).