Code Review for 6893081

Prepared by:twisti on Tue Oct 20 22:07:07 CEST 2009
Workspace:/export/home/twisti/mlvm/6893081
Summary of changes: 223 lines changed: 161 ins; 8 del; 54 mod; 36600 unchg
Patch of changes: 6893081.patch
Printable review: 6893081.pdf
Author comments:
During the work for 6829187 we have fixed a number of basic bugs which
are logically grouped with 6815692 and 6858164 but which must be
reviewed and pushed separately.

The changes for this bug will be culled from these patches:
http://hg.openjdk.java.net/mlvm/mlvm/hotspot/file/tip/indy.compiler.patch
http://hg.openjdk.java.net/mlvm/mlvm/hotspot/file/tip/indy.compiler.inline.patch

This patch must be applied on top of:
6815692: method handle code needs some cleanup (post-6655638)
6858164: invokedynamic code needs some cleanup (post-6655638)
meth.walker.patch

Bug id: 6893081 method handle & invokedynamic code needs additional cleanup (post 6815692, 6858164)
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/frame_x86.cpp

22 lines changed: 20 ins; 0 del; 2 mod; 577 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/methodHandles_x86.cpp

8 lines changed: 0 ins; 1 del; 7 mod; 1171 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/runtime_x86_32.cpp

10 lines changed: 3 ins; 3 del; 4 mod; 143 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/sharedRuntime_x86_64.cpp

29 lines changed: 16 ins; 4 del; 9 mod; 3336 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/templateInterpreter_x86_32.cpp

4 lines changed: 3 ins; 0 del; 1 mod; 1823 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/templateInterpreter_x86_64.cpp

9 lines changed: 6 ins; 0 del; 3 mod; 1847 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/c1/c1_IR.hpp

3 lines changed: 1 ins; 0 del; 2 mod; 379 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/ci/ciStreams.cpp

1 line changed: 0 ins; 0 del; 1 mod; 371 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/javaClasses.hpp

8 lines changed: 8 ins; 0 del; 0 mod; 1261 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionary.cpp

3 lines changed: 2 ins; 0 del; 1 mod; 2759 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionary.hpp

1 line changed: 0 ins; 0 del; 1 mod; 661 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/vmSymbols.hpp

1 line changed: 0 ins; 0 del; 1 mod; 1030 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/codeBlob.hpp

4 lines changed: 3 ins; 0 del; 1 mod; 512 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/debugInfoRec.cpp

3 lines changed: 2 ins; 0 del; 1 mod; 413 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/debugInfoRec.hpp

1 line changed: 1 ins; 0 del; 0 mod; 183 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/nmethod.cpp

20 lines changed: 20 ins; 0 del; 0 mod; 2519 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/nmethod.hpp

18 lines changed: 7 ins; 0 del; 11 mod; 628 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/pcDesc.hpp

4 lines changed: 4 ins; 0 del; 0 mod; 80 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/methodLiveness.cpp

1 line changed: 1 ins; 0 del; 0 mod; 1064 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/bytecode.cpp

3 lines changed: 2 ins; 0 del; 1 mod; 203 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/bytecode.hpp

2 lines changed: 1 ins; 0 del; 1 mod; 386 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/bytecodes.cpp

1 line changed: 0 ins; 0 del; 1 mod; 446 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/interpreter.cpp

1 line changed: 0 ins; 0 del; 1 mod; 434 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/linkResolver.cpp

20 lines changed: 20 ins; 0 del; 0 mod; 1041 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/linkResolver.hpp

1 line changed: 1 ins; 0 del; 0 mod; 173 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/doCall.cpp

1 line changed: 0 ins; 0 del; 1 mod; 873 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/runtime.cpp

4 lines changed: 3 ins; 0 del; 1 mod; 1207 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/arguments.cpp

18 lines changed: 18 ins; 0 del; 0 mod; 2914 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/sharedRuntime.cpp

12 lines changed: 9 ins; 0 del; 3 mod; 2325 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/thread.cpp

6 lines changed: 6 ins; 0 del; 0 mod; 4048 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/thread.hpp

4 lines changed: 4 ins; 0 del; 0 mod; 1793 unchg

This code review page was prepared using /export/home/twisti/bin/webrev (vers 23.18-hg-never).