Code Review for 6893081

Prepared by:twisti on Wed Oct 28 19:31:01 CET 2009
Workspace:/export/home/twisti/mlvm/6893081
Compare against: /export/home/twisti/hotspot-comp/hotspot
Compare against version:-2
Summary of changes: 226 lines changed: 162 ins; 8 del; 56 mod; 39384 unchg
Patch of changes: 6893081.patch
Printable review: 6893081.pdf
Author comments:
During the work for 6829187 we have fixed a number of basic bugs which
are logically grouped with 6815692 and 6858164 but which must be
reviewed and pushed separately.

The changes for this bug will be culled from these patches:
http://hg.openjdk.java.net/mlvm/mlvm/hotspot/file/tip/indy.compiler.patch
http://hg.openjdk.java.net/mlvm/mlvm/hotspot/file/tip/indy.compiler.inline.patch

This patch must be applied on top of:
6858164: invokedynamic code needs some cleanup (post-6655638)
6894206: JVM needs a way to traverse method handle structures

Bug id: 6893081 method handle & invokedynamic code needs additional cleanup (post 6815692, 6858164)
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/frame_x86.cpp

rev 1024 : imported patch indy-cleanup-6893081.patch
22 lines changed: 20 ins; 0 del; 2 mod; 577 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/methodHandles_x86.cpp

rev 1022 : 6829192: JSR 292 needs to support 64-bit x86
Summary: changes for method handles and invokedynamic
Reviewed-by: ?, ?
rev 1023 : [mq]: meth.walker.patch
rev 1024 : imported patch indy-cleanup-6893081.patch
8 lines changed: 0 ins; 1 del; 7 mod; 1171 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/runtime_x86_32.cpp

rev 1024 : imported patch indy-cleanup-6893081.patch
10 lines changed: 3 ins; 3 del; 4 mod; 143 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/sharedRuntime_x86_64.cpp

rev 1024 : imported patch indy-cleanup-6893081.patch
29 lines changed: 16 ins; 4 del; 9 mod; 3336 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/templateInterpreter_x86_32.cpp

rev 1021 : 6858164: invokedynamic code needs some cleanup (post-6655638)
Note: The bug ID for this change set was erroneously used to call for review of 6815692.
Summary: Fix several crashers, remove needless paths for boxed-style bootstrap method call, refactor & simplify APIs for rewriter constantPoolOop, remove sun.dyn.CallSiteImpl
Reviewed-by: ?
rev 1024 : imported patch indy-cleanup-6893081.patch
4 lines changed: 3 ins; 0 del; 1 mod; 1823 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/templateInterpreter_x86_64.cpp

rev 1021 : 6858164: invokedynamic code needs some cleanup (post-6655638)
Note: The bug ID for this change set was erroneously used to call for review of 6815692.
Summary: Fix several crashers, remove needless paths for boxed-style bootstrap method call, refactor & simplify APIs for rewriter constantPoolOop, remove sun.dyn.CallSiteImpl
Reviewed-by: ?
rev 1022 : 6829192: JSR 292 needs to support 64-bit x86
Summary: changes for method handles and invokedynamic
Reviewed-by: ?, ?
rev 1024 : imported patch indy-cleanup-6893081.patch
9 lines changed: 6 ins; 0 del; 3 mod; 1866 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/c1/c1_IR.hpp

rev 1024 : imported patch indy-cleanup-6893081.patch
3 lines changed: 1 ins; 0 del; 2 mod; 379 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/ci/ciStreams.cpp

rev 1024 : imported patch indy-cleanup-6893081.patch
2 lines changed: 0 ins; 0 del; 2 mod; 370 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/javaClasses.hpp

rev 1021 : 6858164: invokedynamic code needs some cleanup (post-6655638)
Note: The bug ID for this change set was erroneously used to call for review of 6815692.
Summary: Fix several crashers, remove needless paths for boxed-style bootstrap method call, refactor & simplify APIs for rewriter constantPoolOop, remove sun.dyn.CallSiteImpl
Reviewed-by: ?
rev 1023 : [mq]: meth.walker.patch
rev 1024 : imported patch indy-cleanup-6893081.patch
8 lines changed: 8 ins; 0 del; 0 mod; 1261 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionary.cpp

rev 1021 : 6858164: invokedynamic code needs some cleanup (post-6655638)
Note: The bug ID for this change set was erroneously used to call for review of 6815692.
Summary: Fix several crashers, remove needless paths for boxed-style bootstrap method call, refactor & simplify APIs for rewriter constantPoolOop, remove sun.dyn.CallSiteImpl
Reviewed-by: ?
rev 1024 : imported patch indy-cleanup-6893081.patch
3 lines changed: 2 ins; 0 del; 1 mod; 2759 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionary.hpp

rev 1021 : 6858164: invokedynamic code needs some cleanup (post-6655638)
Note: The bug ID for this change set was erroneously used to call for review of 6815692.
Summary: Fix several crashers, remove needless paths for boxed-style bootstrap method call, refactor & simplify APIs for rewriter constantPoolOop, remove sun.dyn.CallSiteImpl
Reviewed-by: ?
rev 1024 : imported patch indy-cleanup-6893081.patch
1 line changed: 0 ins; 0 del; 1 mod; 661 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/vmSymbols.hpp

rev 1021 : 6858164: invokedynamic code needs some cleanup (post-6655638)
Note: The bug ID for this change set was erroneously used to call for review of 6815692.
Summary: Fix several crashers, remove needless paths for boxed-style bootstrap method call, refactor & simplify APIs for rewriter constantPoolOop, remove sun.dyn.CallSiteImpl
Reviewed-by: ?
rev 1023 : [mq]: meth.walker.patch
rev 1024 : imported patch indy-cleanup-6893081.patch
1 line changed: 0 ins; 0 del; 1 mod; 1030 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/codeBlob.hpp

rev 1024 : imported patch indy-cleanup-6893081.patch
4 lines changed: 3 ins; 0 del; 1 mod; 512 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/debugInfoRec.cpp

rev 1024 : imported patch indy-cleanup-6893081.patch
3 lines changed: 2 ins; 0 del; 1 mod; 413 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/debugInfoRec.hpp

rev 1024 : imported patch indy-cleanup-6893081.patch
1 line changed: 1 ins; 0 del; 0 mod; 183 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/nmethod.cpp

rev 1024 : imported patch indy-cleanup-6893081.patch
20 lines changed: 20 ins; 0 del; 0 mod; 2519 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/nmethod.hpp

rev 1024 : imported patch indy-cleanup-6893081.patch
18 lines changed: 7 ins; 0 del; 11 mod; 628 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/pcDesc.hpp

rev 1024 : imported patch indy-cleanup-6893081.patch
4 lines changed: 4 ins; 0 del; 0 mod; 80 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/methodLiveness.cpp

rev 1024 : imported patch indy-cleanup-6893081.patch
1 line changed: 1 ins; 0 del; 0 mod; 1064 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/bytecode.cpp

rev 1024 : imported patch indy-cleanup-6893081.patch
3 lines changed: 2 ins; 0 del; 1 mod; 203 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/bytecode.hpp

rev 1024 : imported patch indy-cleanup-6893081.patch
2 lines changed: 1 ins; 0 del; 1 mod; 386 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/bytecodes.cpp

rev 1024 : imported patch indy-cleanup-6893081.patch
1 line changed: 0 ins; 0 del; 1 mod; 446 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/interpreter.cpp

rev 1021 : 6858164: invokedynamic code needs some cleanup (post-6655638)
Note: The bug ID for this change set was erroneously used to call for review of 6815692.
Summary: Fix several crashers, remove needless paths for boxed-style bootstrap method call, refactor & simplify APIs for rewriter constantPoolOop, remove sun.dyn.CallSiteImpl
Reviewed-by: ?
rev 1024 : imported patch indy-cleanup-6893081.patch
1 line changed: 0 ins; 0 del; 1 mod; 434 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/linkResolver.cpp

rev 1021 : 6858164: invokedynamic code needs some cleanup (post-6655638)
Note: The bug ID for this change set was erroneously used to call for review of 6815692.
Summary: Fix several crashers, remove needless paths for boxed-style bootstrap method call, refactor & simplify APIs for rewriter constantPoolOop, remove sun.dyn.CallSiteImpl
Reviewed-by: ?
rev 1024 : imported patch indy-cleanup-6893081.patch
20 lines changed: 20 ins; 0 del; 0 mod; 1041 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/linkResolver.hpp

rev 1024 : imported patch indy-cleanup-6893081.patch
1 line changed: 1 ins; 0 del; 0 mod; 173 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/doCall.cpp

rev 1024 : imported patch indy-cleanup-6893081.patch
1 line changed: 0 ins; 0 del; 1 mod; 873 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/output.cpp

rev 1024 : imported patch indy-cleanup-6893081.patch
3 lines changed: 1 ins; 0 del; 2 mod; 2765 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/runtime.cpp

rev 1024 : imported patch indy-cleanup-6893081.patch
4 lines changed: 3 ins; 0 del; 1 mod; 1207 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/arguments.cpp

rev 1024 : imported patch indy-cleanup-6893081.patch
18 lines changed: 18 ins; 0 del; 0 mod; 2914 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/sharedRuntime.cpp

rev 1024 : imported patch indy-cleanup-6893081.patch
11 lines changed: 9 ins; 0 del; 2 mod; 2326 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/thread.cpp

rev 1024 : imported patch indy-cleanup-6893081.patch
6 lines changed: 6 ins; 0 del; 0 mod; 4048 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/thread.hpp

rev 1024 : imported patch indy-cleanup-6893081.patch
4 lines changed: 4 ins; 0 del; 0 mod; 1793 unchg

This code review page was prepared using /export/home/twisti/bin/webrev (vers 23.18-hg-never).