Code Review for 6894206

Prepared by:twisti on Tue Dec 1 18:28:37 CET 2009
Workspace:/export/home/twisti/mlvm/6894206
Compare against: /export/home/twisti/hotspot-comp/hotspot
Compare against version:-2
Summary of changes: 1242 lines changed: 1194 ins; 19 del; 29 mod; 11937 unchg
Patch of changes: 6894206.patch
Printable review: 6894206.pdf
Author comments:
The method handle walker is used in the JVM to walk method handle
chains. Different method handles define different actions. In
6829187 we use the method handle walker to generate bytecode adapters
for these actions and to call the ultimate call target.

This patch must be applied on top of:
6858164: invokedynamic code needs some cleanup (post-6655638)

Bug id: 6894206 JVM needs a way to traverse method handle structures
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/methodHandles_x86.cpp

rev 1071 : 6829192: JSR 292 needs to support 64-bit x86
Summary: changes for method handles and invokedynamic
Reviewed-by: ?, ?
rev 1072 : [mq]: meth.walker.patch
2 lines changed: 2 ins; 0 del; 0 mod; 1177 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/javaClasses.cpp

rev 1072 : [mq]: meth.walker.patch
4 lines changed: 4 ins; 0 del; 0 mod; 3032 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/javaClasses.hpp

rev 1072 : [mq]: meth.walker.patch
1 line changed: 1 ins; 0 del; 0 mod; 1260 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/vmSymbols.cpp

rev 1072 : [mq]: meth.walker.patch
91 lines changed: 46 ins; 19 del; 26 mod; 453 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/vmSymbols.hpp

rev 1072 : [mq]: meth.walker.patch
57 lines changed: 54 ins; 0 del; 3 mod; 979 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/includeDB_core

rev 1072 : [mq]: meth.walker.patch
4 lines changed: 4 ins; 0 del; 0 mod; 4692 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/growableArray.hpp

rev 1072 : [mq]: meth.walker.patch
11 lines changed: 11 ins; 0 del; 0 mod; 344 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/share/vm/prims/methodHandleWalk.cpp

rev 1072 : [mq]: meth.walker.patch
804 lines changed: 804 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/share/vm/prims/methodHandleWalk.hpp

rev 1072 : [mq]: meth.walker.patch
268 lines changed: 268 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /export/home/twisti/bin/webrev (vers 23.18-hg-never).