Code Review for 6894206

Prepared by:twisti on Fri Dec 4 16:06:36 CET 2009
Workspace:/export/home/twisti/mlvm/6894206
Compare against: /export/home/twisti/hotspot-comp/hotspot
Compare against version:-2
Summary of changes: 1279 lines changed: 1211 ins; 30 del; 38 mod; 11969 unchg
Patch of changes: 6894206.patch
Printable review: 6894206.pdf
Author comments:
The method handle walker is used in the JVM to walk method handle
chains. Different method handles define different actions. In
6829187 we use the method handle walker to generate bytecode adapters
for these actions and to call the ultimate call target.

This patch must be applied on top of:
6858164: invokedynamic code needs some cleanup (post-6655638)

Bug id: 6894206 JVM needs a way to traverse method handle structures
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/methodHandles_x86.cpp

rev 1079 : 6829192: JSR 292 needs to support 64-bit x86
Summary: changes for method handles and invokedynamic
Reviewed-by: ?, ?
rev 1080 : [mq]: meth.walker.patch
3 lines changed: 2 ins; 0 del; 1 mod; 1176 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/javaClasses.cpp

rev 1080 : [mq]: meth.walker.patch
4 lines changed: 4 ins; 0 del; 0 mod; 3032 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/javaClasses.hpp

rev 1080 : [mq]: meth.walker.patch
1 line changed: 1 ins; 0 del; 0 mod; 1260 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/vmSymbols.cpp

rev 1080 : [mq]: meth.walker.patch
98 lines changed: 46 ins; 19 del; 33 mod; 452 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/vmSymbols.hpp

rev 1080 : [mq]: meth.walker.patch
75 lines changed: 71 ins; 0 del; 4 mod; 1012 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/includeDB_core

rev 1080 : [mq]: meth.walker.patch
4 lines changed: 4 ins; 0 del; 0 mod; 4693 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/growableArray.hpp

rev 1080 : [mq]: meth.walker.patch
22 lines changed: 11 ins; 11 del; 0 mod; 344 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/share/vm/prims/methodHandleWalk.cpp

rev 1080 : [mq]: meth.walker.patch
804 lines changed: 804 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/share/vm/prims/methodHandleWalk.hpp

rev 1080 : [mq]: meth.walker.patch
268 lines changed: 268 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /export/home/twisti/bin/webrev (vers 23.18-hg-never).