Code Review for 6914206

Prepared by:twisti on Thu Jan 7 15:24:32 CET 2010
Workspace:/export/home/twisti/mlvm/6914206
Summary of changes: 68 lines changed: 52 ins; 2 del; 14 mod; 18207 unchg
Patch of changes: 6914206.patch
Printable review: 6914206.pdf
Author comments:
Currently generated MH adapters are faked to be in the same class as
the callee to overcome permission problems. I would be better, also
for inlining heuristics, to put these adapters in the
InvokeDynamic/MethodHandle classes to be able to indentify them easily
in the compiler.
Bug id: 6914206 change way of permission checking for generated MethodHandle adapters
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/ci/ciMethod.cpp

7 lines changed: 6 ins; 0 del; 1 mod; 1075 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/ci/ciMethod.hpp

5 lines changed: 3 ins; 0 del; 2 mod; 260 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionary.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 660 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/includeDB_core

2 lines changed: 1 ins; 0 del; 1 mod; 4724 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/methodOop.cpp

13 lines changed: 12 ins; 0 del; 1 mod; 1401 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/methodOop.hpp

5 lines changed: 4 ins; 0 del; 1 mod; 750 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/library_call.cpp

9 lines changed: 6 ins; 0 del; 3 mod; 5253 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/methodHandleWalk.cpp

10 lines changed: 7 ins; 2 del; 1 mod; 1393 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/methodHandleWalk.hpp

6 lines changed: 6 ins; 0 del; 0 mod; 407 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/reflection.cpp

6 lines changed: 5 ins; 0 del; 1 mod; 1625 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/vframe.cpp

3 lines changed: 2 ins; 0 del; 1 mod; 659 unchg

This code review page was prepared using /export/home/twisti/bin/webrev (vers 23.18-hg-never).