Prepared by: | twisti on Mon Sep 27 04:35:19 PDT 2010 |
---|---|
Workspace: | /home/twisti/hotspot-comp/6987555 |
Compare against: | /home/twisti/hotspot-comp/hotspot |
Summary of changes: | 74 lines changed: 46 ins; 22 del; 6 mod; 924 unchg |
Patch of changes: | 6987555.patch |
Printable review: | 6987555.pdf |
Author comments: |
6987555: JSR 292 unboxing to a boolean value fails on big-endian SPARC Reviewed-by: On a big-endian SPARC machine an unboxed true boolean value looks like 0x01000000 but the shift is 31 bits, which results in a wrong value. The fix is to check for a boolean destination type before we do the shift and adjust the shift value. Tested with test.java.dyn.MethodHandlesTest. Additionally this change includes some SPARC-specific changes which were part of 6984311. |
Bug id: | Bug Database |
Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/cpu/sparc/vm/methodHandles_sparc.cpp
74 lines changed: 46 ins; 22 del; 6 mod; 924 unchg
This code review page was prepared using /home/twisti/bin/webrev (vers 23.18-hg-never).