Code Review for 6997459

Prepared by:twisti on Thu Nov 4 03:50:15 PDT 2010
Workspace:/home/twisti/hotspot-comp/6997459
Compare against: /home/twisti/hotspot-comp/hotspot
Summary of changes: 19 lines changed: 1 ins; 2 del; 16 mod; 1013 unchg
Patch of changes: 6997459.patch
Printable review: 6997459.pdf
Author comments:
6997459: JSR 292 after 6994093 getting: on return to interpreted call, restored SP is corrupted
Reviewed-by:

After 6994093 running a testcase on SPARC that should throw a
WrongMethodTypeException results in an assert. The problem is that
the change of 6994093 destroys O5 which is the saved sender SP and
that leads to bogus FP values.

The fix is to change temporary register usage in
MethodHandles::generate_method_handle_interpreter_entry to preserve
O5.

Tested with failing testcase.
Bug id: Bug Database
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/methodHandles_sparc.cpp

19 lines changed: 1 ins; 2 del; 16 mod; 1013 unchg

This code review page was prepared using /home/twisti/bin/webrev (vers 23.18-hg-never).