Code Review for 6998541

Prepared by:twisti on Thu May 12 14:03:36 PDT 2011
Workspace:/home/twisti/hotspot-comp/6998541
Compare against: /home/twisti/hotspot-comp/hotspot
Summary of changes: 437 lines changed: 240 ins; 82 del; 115 mod; 10357 unchg
Patch of changes: 6998541.patch
Printable review: 6998541.pdf
Author comments:
6998541: JSR 292 implement missing return-type conversion for OP_RETYPE_RAW
Reviewed-by: jrose, kvn, never

There is an unimplemented path in the MethodHandleWalker for
OP_RETYPE_RAW return-type conversions.

This change also includes a couple of x86 fixes found by John Rose,
removes the check for genericInvoker on x86 and SPARC and some
miscellaneous fixes (e.g. MethodHandlePrinter output).

There is also a test for the type conversions which will be pushed
later into the JDK 7 repository.

Bug id: 6998541 JSR 292 implement missing return-type conversion for OP_RETYPE_RAW
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/methodHandles_sparc.cpp

18 lines changed: 0 ins; 16 del; 2 mod; 1015 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/methodHandles_x86.cpp

43 lines changed: 12 ins; 15 del; 16 mod; 2377 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/ci/ciMethodData.hpp

5 lines changed: 3 ins; 0 del; 2 mod; 323 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/ci/ciMethodHandle.cpp

19 lines changed: 17 ins; 0 del; 2 mod; 67 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/ci/ciMethodHandle.hpp

20 lines changed: 7 ins; 6 del; 7 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/doCall.cpp

12 lines changed: 5 ins; 1 del; 6 mod; 953 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/methodHandleWalk.cpp

237 lines changed: 150 ins; 38 del; 49 mod; 1350 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/methodHandleWalk.hpp

21 lines changed: 14 ins; 0 del; 7 mod; 424 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/methodHandles.cpp

60 lines changed: 30 ins; 6 del; 24 mod; 2956 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/methodHandles.hpp

2 lines changed: 2 ins; 0 del; 0 mod; 836 unchg

This code review page was prepared using /home/twisti/bin/webrev (vers 23.18-hg-never).