Code Review for 7010180

Prepared by:twisti on Tue Jan 4 04:53:55 PST 2011
Workspace:/home/twisti/hotspot-comp/7010180
Compare against: /home/twisti/hotspot-comp/hotspot
Summary of changes: 30 lines changed: 12 ins; 5 del; 13 mod; 5437 unchg
Patch of changes: 7010180.patch
Printable review: 7010180.pdf
Author comments:
7010180: JSR 292 InvokeDynamicPrintArgs fails with: assert(_adapter == NULL) failed: init'd to NULL
Reviewed-by:

Since 7007377 during method handles adapter generation the adapters
for sun.dyn.MethodHandleImpl::raiseException are also generated.
Later when the Rewriter wants to link the method the adapter entry
already exists and the assert triggers.

The fix is to link sun.dyn.MethodHandleImpl class before generating
the method handle adapters. This ensures that the required
c2i-adapter exists.

Bug id: Bug Database
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/methodHandles_sparc.cpp

4 lines changed: 1 ins; 0 del; 3 mod; 1033 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/methodHandles_x86.cpp

4 lines changed: 1 ins; 0 del; 3 mod; 1226 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/methodHandles.cpp

19 lines changed: 10 ins; 5 del; 4 mod; 2645 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/methodHandles.hpp

3 lines changed: 0 ins; 0 del; 3 mod; 533 unchg

This code review page was prepared using /home/twisti/bin/webrev (vers 23.18-hg-never).