Code Review for 7108383

Prepared by:twisti on Wed Nov 16 05:39:51 PST 2011
Workspace:/home/twisti/hsx/hotspot-comp/7108383
Compare against: /home/twisti/hsx/hotspot-comp/hotspot
Summary of changes: 73 lines changed: 33 ins; 30 del; 10 mod; 2607 unchg
Patch of changes: 7108383.patch
Printable review: 7108383.pdf
Author comments:
7108383: JSR 292: JRuby bench_define_method_methods.rb: assert(slow_jvms != NULL) failed: miss path must not
Reviewed-by:

The problem is that the code in
PredictedDynamicCallGenerator::generate assumes that the generation of
the slow path always succeeds. This might not be the case when we hit
the node limit while generating the slow path.

The suggested fix is to remove the assert and return on failed slow
path generations.

I also applied the fix to PredictedCallGenerator::generate because I
think it can also happen there.

Additionally I removed an unused and unsafe method from ciMethod.

Bug id: 7108383 JSR 292: JRuby bench_define_method_methods.rb: assert(slow_jvms != NULL) failed: miss path must not
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/callGenerator.cpp

38 lines changed: 29 ins; 5 del; 4 mod; 1089 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/callGenerator.hpp

5 lines changed: 4 ins; 1 del; 0 mod; 307 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/doCall.cpp

24 lines changed: 0 ins; 18 del; 6 mod; 911 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/ci/ciMethod.hpp

6 lines changed: 0 ins; 6 del; 0 mod; 300 unchg

This code review page was prepared using /home/twisti/bin/webrev (vers 23.18-hg-never).