| Prepared by: | twisti on Tue May 22 19:11:05 PDT 2012 |
|---|---|
| Workspace: | /home/twisti/hsx/hotspot-comp/7170145 |
| Compare against: | /net/hs-usca-06.sfbay.sun.com/export/home2/16/twisti/hsx/hotspot-comp/hotspot |
| Summary of changes: | 7 lines changed: 3 ins; 0 del; 4 mod; 237 unchg |
| Patch of changes: | 7170145.patch |
| Printable review: | 7170145.pdf |
| Author comments: |
7170145: C1 doesn't respect the JMM with volatile field loads Reviewed-by: ValueNumberingVisitor::do_LoadField does not include logic for volatile fields which allows CSE of normal field loads across volatile field loads. That's explicitly prohibited by the JMM. This patch also kills the memory across volatile field stores even it is too strict for now because of volatile field stores and possible future optimizations. |
| Bug id: | 7170145 C1 doesn't respect the JMM with volatile field loads |
| Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/c1/c1_ValueMap.hpp
7 lines changed: 3 ins; 0 del; 4 mod; 237 unchg
This code review page was prepared using /home/twisti/bin/webrev (vers 23.18-hg-never).