Code Review for 8000821

Prepared by:twisti on Wed Oct 17 14:41:19 PDT 2012
Compare against: ssh://
Summary of changes: 32 lines changed: 16 ins; 7 del; 9 mod; 4184 unchg
Patch of changes: 8000821.patch
Author comments:
8000821: JSR 292: C1 fails to call virtual method (JRUBY-6920)

GraphBuilder::try_method_handle_inline calls GraphBuilder::try_inline
to inline the target of method handle calls. But try_inline doesn't
do CHA; GraphBuilder::invoke does that.

The easy fix for now without refactoring the whole logic in C1 (which
is not trivial, I tried) is to only inline static and statically
bindable methods for method handle calls. This shouldn't affect
performance since most methods are statically bindable and C2 doesn't
have this problem.

Bug id: Bug Database
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/c1/c1_GraphBuilder.cpp

32 lines changed: 16 ins; 7 del; 9 mod; 4184 unchg

This code review page was prepared using /home/twisti/bin/webrev (vers 23.18-hg-twisti).