Code Review for 8022956

Prepared by:twisti on Mon Aug 19 16:52:02 PDT 2013
Workspace:/Users/twisti/ws/8022956
Compare against: /Users/twisti/ws/hotspot
Summary of changes: 66 lines changed: 51 ins; 12 del; 3 mod; 4455 unchg
Patch of changes: 8022956.patch
Author comments:
8022956: Clang: enable return type warnings on BSD
Reviewed-by:

While implementing a new feature I noticed that Clang isn't complaining about wrong return types while Sun Studio does. The reason is that we turned it off. Turning it on only needs one small code change (plus a bunch of fixes for Zero). We probably should do the same on Linux but I don't have a Linux machine with Clang installed available.

Bug id: 8022956
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/bsd/makefiles/gcc.make

1 line changed: 0 ins; 0 del; 1 mod; 435 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/zero/vm/assembler_zero.cpp

2 lines changed: 2 ins; 0 del; 0 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/zero/vm/cppInterpreter_zero.cpp

1 line changed: 1 ins; 0 del; 0 mod; 1055 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/zero/vm/frame_zero.cpp

5 lines changed: 3 ins; 2 del; 0 mod; 440 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/zero/vm/frame_zero.inline.hpp

5 lines changed: 4 ins; 0 del; 1 mod; 170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/zero/vm/icBuffer_zero.cpp

2 lines changed: 2 ins; 0 del; 0 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/zero/vm/interp_masm_zero.hpp

1 line changed: 1 ins; 0 del; 0 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/zero/vm/interpreter_zero.cpp

1 line changed: 1 ins; 0 del; 0 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/zero/vm/nativeInst_zero.hpp

19 lines changed: 19 ins; 0 del; 0 mod; 196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/zero/vm/register_zero.cpp

2 lines changed: 2 ins; 0 del; 0 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/zero/vm/relocInfo_zero.cpp

2 lines changed: 2 ins; 0 del; 0 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/zero/vm/sharedRuntime_zero.cpp

3 lines changed: 3 ins; 0 del; 0 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/zero/vm/vtableStubs_zero.cpp

4 lines changed: 4 ins; 0 del; 0 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp

1 line changed: 1 ins; 0 del; 0 mod; 1000 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp

16 lines changed: 5 ins; 10 del; 1 mod; 461 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os_cpu/bsd_zero/vm/thread_bsd_zero.hpp

1 line changed: 1 ins; 0 del; 0 mod; 121 unchg

This code review page was prepared using /Users/twisti/bin/webrev (vers 23.18-hg-never-dev).