Code Review for 8024545

Prepared by:twisti on Wed Sep 25 13:58:13 PDT 2013
Workspace:/Users/twisti/ws/8024545
Compare against: ssh://hg.openjdk.java.net/hsx/hotspot-comp-gate/hotspot
Summary of changes: 697 lines changed: 281 ins; 106 del; 310 mod; 21508 unchg
Patch of changes: 8024545.patch
Author comments:
8024545: make develop and notproduct flag values available in product builds
Reviewed-by: dholmes, kvn

Right now the internal flag table only contains flags which are defined in a product build. This does not include develop and notproduct flags. Sometimes it is useful to have access to these values for post-mortem core file analysis or to read these values for compiler settings for a Java-based compiler.

Bug id: 8024545
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java

20 lines changed: 0 ins; 9 del; 11 mod; 882 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/jvm.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 4668 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/arguments.cpp

13 lines changed: 0 ins; 0 del; 13 mod; 3917 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/arguments.hpp

3 lines changed: 0 ins; 0 del; 3 mod; 575 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/globals.cpp

383 lines changed: 220 ins; 39 del; 124 mod; 462 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/globals.hpp

131 lines changed: 52 ins; 11 del; 68 mod; 3705 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/globals_extension.hpp

106 lines changed: 1 ins; 45 del; 60 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/vmStructs.cpp

7 lines changed: 0 ins; 1 del; 6 mod; 3302 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/services/attachListener.cpp

5 lines changed: 0 ins; 0 del; 5 mod; 502 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/services/classLoadingService.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 243 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/services/dtraceAttacher.cpp

1 line changed: 0 ins; 0 del; 1 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/services/management.cpp

22 lines changed: 8 ins; 0 del; 14 mod; 2336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/services/memoryService.cpp

2 lines changed: 0 ins; 1 del; 1 mod; 619 unchg

This code review page was prepared using /Users/twisti/bin/webrev (vers 23.18-hg-never-dev).