Code Review for jdk

Prepared by:valeriep on Fri May 22 02:35:22 UTC 2015
Workspace:/net/sca00bkv.us.oracle.com/export/home/vpeng/tlJDK9_SL/jdk
Compare against: ssh://hg.openjdk.java.net/jdk9/dev/jdk
Summary of changes: 2298 lines changed: 1314 ins; 550 del; 434 mod; 15666 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/Provider.java

7191662: JCE providers should be located via ServiceLoader
119 lines changed: 58 ins; 51 del; 10 mod; 1789 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/jca/ProviderConfig.java

7191662: JCE providers should be located via ServiceLoader
203 lines changed: 137 ins; 41 del; 25 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/jca/Providers.java

7191662: JCE providers should be located via ServiceLoader
18 lines changed: 8 ins; 2 del; 8 mod; 237 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/tools/keytool/Main.java

7191662: JCE providers should be located via ServiceLoader
10 lines changed: 3 ins; 6 del; 1 mod; 4265 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/conf/security/java.policy

7191662: JCE providers should be located via ServiceLoader
1 line changed: 1 ins; 0 del; 0 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/conf/security/java.security

7191662: JCE providers should be located via ServiceLoader
1 line changed: 1 ins; 0 del; 0 mod; 538 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.jgss/share/classes/sun/security/jgss/SunProvider.java

7191662: JCE providers should be located via ServiceLoader
50 lines changed: 39 ins; 2 del; 9 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.sasl/share/classes/com/sun/security/sasl/Provider.java

7191662: JCE providers should be located via ServiceLoader
78 lines changed: 52 ins; 11 del; 15 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.sasl/share/classes/javax/security/sasl/Sasl.java

7191662: JCE providers should be located via ServiceLoader
87 lines changed: 14 ins; 33 del; 40 mod; 548 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.smartcardio/share/classes/sun/security/smartcardio/SunPCSC.java

7191662: JCE providers should be located via ServiceLoader
30 lines changed: 28 ins; 0 del; 2 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XMLDSigRI.java

7191662: JCE providers should be located via ServiceLoader
158 lines changed: 78 ins; 24 del; 56 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ec/share/classes/sun/security/ec/SunEC.java

7191662: JCE providers should be located via ServiceLoader
203 lines changed: 191 ins; 1 del; 11 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/SunMSCAPI.java

7191662: JCE providers should be located via ServiceLoader
162 lines changed: 78 ins; 17 del; 67 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.pkcs11/share/classes/sun/security/pkcs11/Config.java

7191662: JCE providers should be located via ServiceLoader
55 lines changed: 18 ins; 27 del; 10 mod; 979 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.pkcs11/share/classes/sun/security/pkcs11/Secmod.java

7191662: JCE providers should be located via ServiceLoader
3 lines changed: 0 ins; 1 del; 2 mod; 779 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.pkcs11/share/classes/sun/security/pkcs11/SunPKCS11.java

7191662: JCE providers should be located via ServiceLoader
88 lines changed: 54 ins; 15 del; 19 mod; 1441 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ucrypto/solaris/classes/com/oracle/security/ucrypto/NativeCipher.java

7191662: JCE providers should be located via ServiceLoader
40 lines changed: 6 ins; 32 del; 2 mod; 554 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ucrypto/solaris/classes/com/oracle/security/ucrypto/NativeGCMCipher.java

7191662: JCE providers should be located via ServiceLoader
15 lines changed: 0 ins; 12 del; 3 mod; 407 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ucrypto/solaris/classes/com/oracle/security/ucrypto/NativeRSASignature.java

7191662: JCE providers should be located via ServiceLoader
2 lines changed: 0 ins; 1 del; 1 mod; 443 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ucrypto/solaris/classes/com/oracle/security/ucrypto/UcryptoMech.java

7191662: JCE providers should be located via ServiceLoader
78 lines changed: 4 ins; 13 del; 61 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.ucrypto/solaris/classes/com/oracle/security/ucrypto/UcryptoProvider.java

7191662: JCE providers should be located via ServiceLoader
191 lines changed: 118 ins; 13 del; 60 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.naming/share/classes/sun/security/provider/certpath/ldap/JdkLDAP.java

7191662: JCE providers should be located via ServiceLoader
21 lines changed: 6 ins; 4 del; 11 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.deploy.osx/macosx/classes/apple/security/AppleProvider.java

7191662: JCE providers should be located via ServiceLoader
40 lines changed: 31 ins; 3 del; 6 mod; 51 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.crypto.ec/share/classes/sun/security/ec/SunECEntries.java

7191662: JCE providers should be located via ServiceLoader
184 lines changed: 0 ins; 184 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw make/gensrc/Gensrc-java.naming.gmk

7191662: JCE providers should be located via ServiceLoader
88 lines changed: 88 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.naming/share/classes/META-INF/services/java.security.Provider

7191662: JCE providers should be located via ServiceLoader
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.security.jgss/share/classes/META-INF/services/java.security.Provider

7191662: JCE providers should be located via ServiceLoader
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.security.sasl/share/classes/META-INF/services/java.security.Provider

7191662: JCE providers should be located via ServiceLoader
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.smartcardio/share/classes/META-INF/services/java.security.Provider

7191662: JCE providers should be located via ServiceLoader
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.xml.crypto/share/classes/META-INF/services/java.security.Provider

7191662: JCE providers should be located via ServiceLoader
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.crypto.ec/share/classes/META-INF/services/java.security.Provider

7191662: JCE providers should be located via ServiceLoader
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.crypto.mscapi/windows/classes/META-INF/services/java.security.Provider

7191662: JCE providers should be located via ServiceLoader
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.crypto.pkcs11/share/classes/META-INF/services/java.security.Provider

7191662: JCE providers should be located via ServiceLoader
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.crypto.ucrypto/solaris/classes/META-INF/services/java.security.Provider

7191662: JCE providers should be located via ServiceLoader
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.crypto.ucrypto/solaris/classes/com/oracle/security/ucrypto/ServiceDesc.java

7191662: JCE providers should be located via ServiceLoader
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.deploy.osx/macosx/classes/META-INF/services/java.security.Provider

7191662: JCE providers should be located via ServiceLoader
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.security.jgss/share/classes/META-INF/services/java.security.Provider

7191662: JCE providers should be located via ServiceLoader
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.security.jgss/share/classes/com/sun/security/sasl/gsskerb/JdkSASL.java

7191662: JCE providers should be located via ServiceLoader
89 lines changed: 89 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/security/Provider/DefaultProviderList.java

7191662: JCE providers should be located via ServiceLoader
83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/SecurityManager/CheckSecurityProvider.java

7191662: JCE providers should be located via ServiceLoader
14 lines changed: 2 ins; 8 del; 4 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/pkcs11/KeyStore/Basic.java

7191662: JCE providers should be located via ServiceLoader
6 lines changed: 5 ins; 0 del; 1 mod; 1449 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/pkcs11/KeyStore/ClientAuth.java

7191662: JCE providers should be located via ServiceLoader
8 lines changed: 5 ins; 1 del; 2 mod; 355 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/pkcs11/PKCS11Test.java

7191662: JCE providers should be located via ServiceLoader
43 lines changed: 34 ins; 5 del; 4 mod; 593 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/pkcs11/rsa/TestCACerts.java

7191662: JCE providers should be located via ServiceLoader
4 lines changed: 1 ins; 0 del; 3 mod; 79 unchg

------ ------ ------ ------ Old --- Patch --- test/sun/security/pkcs11/KeyStore/ProviderLoader.java

7191662: JCE providers should be located via ServiceLoader
43 lines changed: 0 ins; 43 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/launcher/MiscTests.java

7191662: JCE providers should be located via ServiceLoader
2 lines changed: 1 ins; 0 del; 1 mod; 73 unchg

This code review page was prepared using /home/vpeng/bin/HG/hgWebrev (vers 23.18-hg).