Code Review for jdkLastConsolidated

Prepared by:vromero on Tue Feb 13 15:34:57 EST 2018
Workspace:/home/vromero/work/langtoolsProjects/consolidatedJDK10Projects/jdkLastConsolidated
Compare against version:48855
Summary of changes: 430 lines changed: 357 ins; 6 del; 67 mod; 8361 unchg
Patch of changes: jdkLastConsolidated.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java

rev 48856 : 8194892: add compiler support for local-variable syntax for lambda parameters
rev 48721 : 8196403: remove the remaining use of string keys for errors and warnings in the compiler
Reviewed-by: mcimadamore, jlahoda
rev 48551 : 8189146: Have use of "var" in 9 and earlier source versions issue a warning for type declarations
Reviewed-by: mcimadamore, jjg
rev 48054 : 8189749: Devise strategy for making source level checks more uniform
Summary: Create a 'feature' enum which is responsible for handling source version checks and related diagnostic generation
Reviewed-by: jjg, jlahoda
rev 47936 : 8185983: Javac should reject TypeArguments on field access expression
Reviewed-by: mcimadamore
rev 47439 : 8189796: Incorrect end position for missing statement
Summary: Recording end positions for error trees representing missing statements.
Reviewed-by: mcimadamore
Contributed-by: dusan.balek@oracle.com, jan.lahoda@oracle.com
rev 47318 : 8188225: AST could be improved in presence of var types.
Summary: Adding a better start pos for vars; always adding a synthetic type tree to vars.
Reviewed-by: mcimadamore
rev 47268 : 8177466: Add compiler support for local variable type-inference
Summary: Add support for 'var' in implicitly typed local variable declarations
Reviewed-by: vromero, jlahoda
rev 47234 : 8184739: Incorrect end position of PackageTree
Summary: Fixing end position of PackageTree.
Reviewed-by: jjg
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
171 lines changed: 126 ins; 2 del; 43 mod; 4211 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/parser/ParserFactory.java

rev 48856 : 8194892: add compiler support for local-variable syntax for lambda parameters
rev 48721 : 8196403: remove the remaining use of string keys for errors and warnings in the compiler
Reviewed-by: mcimadamore, jlahoda
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
2 lines changed: 2 ins; 0 del; 0 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties

rev 48856 : 8194892: add compiler support for local-variable syntax for lambda parameters
rev 48746 : 8190452: javac should not add MethodParameters attributes to v51 and earlier class files
Reviewed-by: vromero, jjg
rev 48721 : 8196403: remove the remaining use of string keys for errors and warnings in the compiler
Reviewed-by: mcimadamore, jlahoda
rev 48608 : Merge
rev 48551 : 8189146: Have use of "var" in 9 and earlier source versions issue a warning for type declarations
Reviewed-by: mcimadamore, jjg
rev 48538 : Merge
rev 48498 : 8187487: crash with classes with same binary name
Reviewed-by: jjg
rev 48430 : Merge
rev 48427 : 8193125: javac should not compile a module if it requires java.base with modifiers
Reviewed-by: vromero
rev 48367 : 8187487: crash with classes with same binary name
Reviewed-by: jjg
rev 48352 : 8057650: uniform error diagnostics for inconsistent inherited method signatures
Summary: consolidate diagnostics for bad overrides
Reviewed-by: vromero
rev 48054 : 8189749: Devise strategy for making source level checks more uniform
Summary: Create a 'feature' enum which is responsible for handling source version checks and related diagnostic generation
Reviewed-by: jjg, jlahoda
rev 47934 : 8191834: Assigning a void expression to a "var" crashes the compiler
Summary: local variable type inference should give error on void initializers
Reviewed-by: sundar
rev 47485 : 8187681: Compiling for target 9 while also using --patch-module
Summary: Removing limitation on simultaneous use of --release and --patch-module for system modules.
Reviewed-by: mcimadamore, jjg
rev 47268 : 8177466: Add compiler support for local variable type-inference
Summary: Add support for 'var' in implicitly typed local variable declarations
Reviewed-by: vromero, jlahoda
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
14 lines changed: 14 ins; 0 del; 0 mod; 3188 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/ReplParser.java

rev 48856 : 8194892: add compiler support for local-variable syntax for lambda parameters
rev 48721 : 8196403: remove the remaining use of string keys for errors and warnings in the compiler
Reviewed-by: mcimadamore, jlahoda
rev 48054 : 8189749: Devise strategy for making source level checks more uniform
Summary: Create a 'feature' enum which is responsible for handling source version checks and related diagnostic generation
Reviewed-by: jjg, jlahoda
rev 47268 : 8177466: Add compiler support for local variable type-inference
Summary: Add support for 'var' in implicitly typed local variable declarations
Reviewed-by: vromero, jlahoda
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
1 line changed: 0 ins; 0 del; 1 mod; 262 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/lambda/8131742/T8131742.out

rev 48856 : 8194892: add compiler support for local-variable syntax for lambda parameters
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
2 lines changed: 0 ins; 0 del; 2 mod; 2 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/lambda/LambdaParserTest.java

rev 48856 : 8194892: add compiler support for local-variable syntax for lambda parameters
rev 47350 : 8186694: JShell: speed-up compilation by reusing compiler instances
Summary: Generalizing ReusableContext and using it in JShell to speed up processing.
Reviewed-by: mcimadamore, rfield
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
59 lines changed: 38 ins; 3 del; 18 mod; 253 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/lvti/ParserTest.java

rev 48856 : 8194892: add compiler support for local-variable syntax for lambda parameters
rev 48551 : 8189146: Have use of "var" in 9 and earlier source versions issue a warning for type declarations
Reviewed-by: mcimadamore, jjg
rev 47268 : 8177466: Add compiler support for local variable type-inference
Summary: Add support for 'var' in implicitly typed local variable declarations
Reviewed-by: vromero, jlahoda
1 line changed: 0 ins; 0 del; 1 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/lvti/ParserTest.out

rev 48856 : 8194892: add compiler support for local-variable syntax for lambda parameters
rev 48551 : 8189146: Have use of "var" in 9 and earlier source versions issue a warning for type declarations
Reviewed-by: mcimadamore, jjg
rev 47268 : 8177466: Add compiler support for local variable type-inference
Summary: Add support for 'var' in implicitly typed local variable declarations
Reviewed-by: vromero, jlahoda
2 lines changed: 0 ins; 1 del; 1 mod; 23 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/parser/extend/TrialParser.java

rev 48856 : 8194892: add compiler support for local-variable syntax for lambda parameters
rev 48721 : 8196403: remove the remaining use of string keys for errors and warnings in the compiler
Reviewed-by: mcimadamore, jlahoda
rev 48054 : 8189749: Devise strategy for making source level checks more uniform
Summary: Create a 'feature' enum which is responsible for handling source version checks and related diagnostic generation
Reviewed-by: jjg, jlahoda
rev 47268 : 8177466: Add compiler support for local variable type-inference
Summary: Add support for 'var' in implicitly typed local variable declarations
Reviewed-by: vromero, jlahoda
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
1 line changed: 0 ins; 0 del; 1 mod; 254 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/diags/examples/BracketsNotAllowedImplicitLambda.java

rev 48856 : 8194892: add compiler support for local-variable syntax for lambda parameters
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/diags/examples/ExplicitImplicitLambda.java

rev 48856 : 8194892: add compiler support for local-variable syntax for lambda parameters
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/diags/examples/VarAllOrNothing.java

rev 48856 : 8194892: add compiler support for local-variable syntax for lambda parameters
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/diags/examples/VarExplicitLambda.java

rev 48856 : 8194892: add compiler support for local-variable syntax for lambda parameters
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/diags/examples/VarNotAllowedExplicitLambda.java

rev 48856 : 8194892: add compiler support for local-variable syntax for lambda parameters
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/var_implicit_lambda/VarInImplicitLambdaNegTest01.java

rev 48856 : 8194892: add compiler support for local-variable syntax for lambda parameters
17 lines changed: 17 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/var_implicit_lambda/VarInImplicitLambdaNegTest01.out

rev 48856 : 8194892: add compiler support for local-variable syntax for lambda parameters
6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/vromero/work/webrev/webrev.ksh (vers 23.18-hg).