Code Review for jdkLastConsolidated

Prepared by:vromero on Wed Feb 14 10:29:14 EST 2018
Workspace:/home/vromero/work/langtoolsProjects/consolidatedJDK10Projects/jdkLastConsolidated
Compare against version:48895
Summary of changes: 425 lines changed: 350 ins; 8 del; 67 mod; 8267 unchg
Patch of changes: jdkLastConsolidated.patch
Author comments:

Index

Examples: A B C D E F G H I J K L M N O P Q R S T U V W X Y Z

compiler.err.invalid.lambda.parameter.declaration ExplicitImplicitLambda.java, VarAllOrNothing.java, VarExplicitLambda.java, VarNotAllowedExplicitLambda.java
compiler.err.var.not.allowed.array BracketsNotAllowedImplicitLambda.java
compiler.misc.implicit.and.explicit.not.allowed ExplicitImplicitLambda.java
compiler.misc.var.and.explicit.not.allowed VarExplicitLambda.java, VarNotAllowedExplicitLambda.java
compiler.misc.var.and.implicit.not.allowed VarAllOrNothing.java

BracketsNotAllowedImplicitLambda.java

tests/BracketsNotAllowedImplicitLambda.java:29: error: 'var' is not allowed as an element type of an array BiFunction<String[], String, String> f = (var s1[], var s2) -> s2; ^ 1 error

ExplicitImplicitLambda.java

tests/ExplicitImplicitLambda.java:30: error: invalid lambda parameter declaration IntBinaryOperator f = (int x, y) -> x + y; ^ (cannot mix implicitly-typed and explicitly-typed parameters) 1 error

VarAllOrNothing.java

tests/VarAllOrNothing.java:30: error: invalid lambda parameter declaration IntBinaryOperator f = (x, var y) -> x + y; ^ (cannot mix 'var' and implicitly-typed parameters) 1 error

VarExplicitLambda.java

tests/VarExplicitLambda.java:30: error: invalid lambda parameter declaration IntBinaryOperator f = (int x, var y) -> x + y; ^ (cannot mix 'var' and explicitly-typed parameters) 1 error

VarNotAllowedExplicitLambda.java

tests/VarNotAllowedExplicitLambda.java:30: error: invalid lambda parameter declaration F f = (String s, var v)->{}; ^ (cannot mix 'var' and explicitly-typed parameters) 1 error

Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java

rev 48896 : 8194892: add compiler support for local-variable syntax for lambda parameters
168 lines changed: 121 ins; 4 del; 43 mod; 4209 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties

rev 48896 : 8194892: add compiler support for local-variable syntax for lambda parameters
14 lines changed: 14 ins; 0 del; 0 mod; 3188 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/ReplParser.java

rev 48896 : 8194892: add compiler support for local-variable syntax for lambda parameters
1 line changed: 0 ins; 0 del; 1 mod; 262 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/lambda/8131742/T8131742.out

rev 48896 : 8194892: add compiler support for local-variable syntax for lambda parameters
2 lines changed: 0 ins; 0 del; 2 mod; 2 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/lambda/LambdaParserTest.java

rev 48896 : 8194892: add compiler support for local-variable syntax for lambda parameters
59 lines changed: 38 ins; 3 del; 18 mod; 253 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/lvti/ParserTest.java

rev 48896 : 8194892: add compiler support for local-variable syntax for lambda parameters
1 line changed: 0 ins; 0 del; 1 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/lvti/ParserTest.out

rev 48896 : 8194892: add compiler support for local-variable syntax for lambda parameters
2 lines changed: 0 ins; 1 del; 1 mod; 23 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/parser/extend/TrialParser.java

rev 48896 : 8194892: add compiler support for local-variable syntax for lambda parameters
1 line changed: 0 ins; 0 del; 1 mod; 254 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/diags/examples/BracketsNotAllowedImplicitLambda.java

rev 48896 : 8194892: add compiler support for local-variable syntax for lambda parameters
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/diags/examples/ExplicitImplicitLambda.java

rev 48896 : 8194892: add compiler support for local-variable syntax for lambda parameters
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/diags/examples/VarAllOrNothing.java

rev 48896 : 8194892: add compiler support for local-variable syntax for lambda parameters
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/diags/examples/VarExplicitLambda.java

rev 48896 : 8194892: add compiler support for local-variable syntax for lambda parameters
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/diags/examples/VarNotAllowedExplicitLambda.java

rev 48896 : 8194892: add compiler support for local-variable syntax for lambda parameters
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/var_implicit_lambda/VarInImplicitLambdaNegTest01.java

rev 48896 : 8194892: add compiler support for local-variable syntax for lambda parameters
17 lines changed: 17 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/var_implicit_lambda/VarInImplicitLambdaNegTest01.out

rev 48896 : 8194892: add compiler support for local-variable syntax for lambda parameters
6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/vromero/work/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).