Code Review for jdk.dev

Prepared by:vromero on Tue Sep 11 13:38:28 EDT 2018
Workspace:/home/vromero/work/langtoolsProjects/consolidatedJDK10Projects/jdk.dev
Compare against version:51699
Summary of changes: 6564 lines changed: 6446 ins; 15 del; 103 mod; 50433 unchg
Patch of changes: jdk.dev.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Class.java

rev 51700 : 8210031: implementation for JVM Constants API
45 lines changed: 44 ins; 0 del; 1 mod; 4031 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Double.java

rev 51700 : 8210031: implementation for JVM Constants API
30 lines changed: 29 ins; 0 del; 1 mod; 1074 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Enum.java

rev 51700 : 8210031: implementation for JVM Constants API
92 lines changed: 90 ins; 1 del; 1 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Float.java

rev 51700 : 8210031: implementation for JVM Constants API
30 lines changed: 29 ins; 0 del; 1 mod; 986 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Integer.java

rev 51700 : 8210031: implementation for JVM Constants API
30 lines changed: 29 ins; 0 del; 1 mod; 1829 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Long.java

rev 51700 : 8210031: implementation for JVM Constants API
30 lines changed: 29 ins; 0 del; 1 mod; 1951 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/String.java

rev 51700 : 8210031: implementation for JVM Constants API
32 lines changed: 29 ins; 1 del; 2 mod; 3344 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodHandle.java

rev 51700 : 8210031: implementation for JVM Constants API
56 lines changed: 55 ins; 0 del; 1 mod; 1683 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodType.java

rev 51700 : 8210031: implementation for JVM Constants API
38 lines changed: 32 ins; 2 del; 4 mod; 1380 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/VarHandle.java

rev 51700 : 8210031: implementation for JVM Constants API
211 lines changed: 204 ins; 1 del; 6 mod; 2078 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/VarHandles.java

rev 51700 : 8210031: implementation for JVM Constants API
35 lines changed: 35 ins; 0 del; 0 mod; 540 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/X-VarHandle.java.template

rev 51700 : 8210031: implementation for JVM Constants API
75 lines changed: 75 ins; 0 del; 0 mod; 950 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/X-VarHandleByteArrayView.java.template

rev 51700 : 8210031: implementation for JVM Constants API
11 lines changed: 11 ins; 0 del; 0 mod; 946 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/module-info.java

rev 51700 : 8210031: implementation for JVM Constants API
1 line changed: 1 ins; 0 del; 0 mod; 371 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/invoke/util/Wrapper.java

rev 51700 : 8210031: implementation for JVM Constants API
9 lines changed: 7 ins; 1 del; 1 mod; 647 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symtab.java

rev 51700 : 8210031: implementation for JVM Constants API
4 lines changed: 4 ins; 0 del; 0 mod; 853 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java

rev 51700 : 8210031: implementation for JVM Constants API
117 lines changed: 75 ins; 6 del; 36 mod; 685 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java

rev 51700 : 8210031: implementation for JVM Constants API
17 lines changed: 11 ins; 0 del; 6 mod; 571 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleBaseByteArrayTest.java

rev 51700 : 8210031: implementation for JVM Constants API
2 lines changed: 0 ins; 0 del; 2 mod; 360 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessBoolean.java

rev 51700 : 8210031: implementation for JVM Constants API
68 lines changed: 68 ins; 0 del; 0 mod; 1260 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessByte.java

rev 51700 : 8210031: implementation for JVM Constants API
68 lines changed: 68 ins; 0 del; 0 mod; 1297 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessChar.java

rev 51700 : 8210031: implementation for JVM Constants API
68 lines changed: 68 ins; 0 del; 0 mod; 1297 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessDouble.java

rev 51700 : 8210031: implementation for JVM Constants API
68 lines changed: 68 ins; 0 del; 0 mod; 1188 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessFloat.java

rev 51700 : 8210031: implementation for JVM Constants API
68 lines changed: 68 ins; 0 del; 0 mod; 1188 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessInt.java

rev 51700 : 8210031: implementation for JVM Constants API
68 lines changed: 68 ins; 0 del; 0 mod; 1297 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessLong.java

rev 51700 : 8210031: implementation for JVM Constants API
68 lines changed: 68 ins; 0 del; 0 mod; 1297 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessShort.java

rev 51700 : 8210031: implementation for JVM Constants API
68 lines changed: 68 ins; 0 del; 0 mod; 1297 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessString.java

rev 51700 : 8210031: implementation for JVM Constants API
68 lines changed: 68 ins; 0 del; 0 mod; 1238 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsChar.java

rev 51700 : 8210031: implementation for JVM Constants API
41 lines changed: 36 ins; 0 del; 5 mod; 906 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsDouble.java

rev 51700 : 8210031: implementation for JVM Constants API
41 lines changed: 36 ins; 0 del; 5 mod; 1336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsFloat.java

rev 51700 : 8210031: implementation for JVM Constants API
41 lines changed: 36 ins; 0 del; 5 mod; 1336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsInt.java

rev 51700 : 8210031: implementation for JVM Constants API
41 lines changed: 36 ins; 0 del; 5 mod; 1740 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsLong.java

rev 51700 : 8210031: implementation for JVM Constants API
41 lines changed: 36 ins; 0 del; 5 mod; 1740 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsShort.java

rev 51700 : 8210031: implementation for JVM Constants API
41 lines changed: 36 ins; 0 del; 5 mod; 906 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/X-VarHandleTestAccess.java.template

rev 51700 : 8210031: implementation for JVM Constants API
72 lines changed: 72 ins; 0 del; 0 mod; 1925 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/X-VarHandleTestByteArrayView.java.template

rev 51700 : 8210031: implementation for JVM Constants API
45 lines changed: 40 ins; 0 del; 5 mod; 2108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/lib/JavadocTester.java

rev 51700 : 8210031: implementation for JVM Constants API
3 lines changed: 2 ins; 0 del; 1 mod; 1795 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testClassTree/TestClassTree.java

rev 51700 : 8210031: implementation for JVM Constants API
2 lines changed: 0 ins; 1 del; 1 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/jshell/TypeNameTest.java

rev 51700 : 8210031: implementation for JVM Constants API
18 lines changed: 17 ins; 0 del; 1 mod; 254 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/generics/inference/8176534/TestUncheckedCalls.java

rev 51700 : 8210031: implementation for JVM Constants API
1 line changed: 0 ins; 0 del; 1 mod; 254 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/lvti/harness/NonDenotableTest.java

rev 51700 : 8210031: implementation for JVM Constants API
2 lines changed: 0 ins; 2 del; 0 mod; 157 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/AsTypeMethodHandleDesc.java

rev 51700 : 8210031: implementation for JVM Constants API
77 lines changed: 77 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/ClassDesc.java

rev 51700 : 8210031: implementation for JVM Constants API
266 lines changed: 266 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/Constable.java

rev 51700 : 8210031: implementation for JVM Constants API
75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/ConstantDesc.java

rev 51700 : 8210031: implementation for JVM Constants API
101 lines changed: 101 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/ConstantDescs.java

rev 51700 : 8210031: implementation for JVM Constants API
351 lines changed: 351 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/ConstantUtils.java

rev 51700 : 8210031: implementation for JVM Constants API
199 lines changed: 199 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/DirectMethodHandleDesc.java

rev 51700 : 8210031: implementation for JVM Constants API
164 lines changed: 164 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/DirectMethodHandleDescImpl.java

rev 51700 : 8210031: implementation for JVM Constants API
195 lines changed: 195 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/DynamicCallSiteDesc.java

rev 51700 : 8210031: implementation for JVM Constants API
269 lines changed: 269 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/DynamicConstantDesc.java

rev 51700 : 8210031: implementation for JVM Constants API
440 lines changed: 440 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/MethodHandleDesc.java

rev 51700 : 8210031: implementation for JVM Constants API
209 lines changed: 209 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/MethodTypeDesc.java

rev 51700 : 8210031: implementation for JVM Constants API
192 lines changed: 192 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/MethodTypeDescImpl.java

rev 51700 : 8210031: implementation for JVM Constants API
170 lines changed: 170 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/PrimitiveClassDescImpl.java

rev 51700 : 8210031: implementation for JVM Constants API
82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/ReferenceClassDescImpl.java

rev 51700 : 8210031: implementation for JVM Constants API
109 lines changed: 109 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/package-info.java

rev 51700 : 8210031: implementation for JVM Constants API
95 lines changed: 95 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/invoke/TypeDescriptor.java

rev 51700 : 8210031: implementation for JVM Constants API
152 lines changed: 152 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/ClassDescTest.java

rev 51700 : 8210031: implementation for JVM Constants API
267 lines changed: 267 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/CondyDescTest.java

rev 51700 : 8210031: implementation for JVM Constants API
217 lines changed: 217 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/IndyDescTest.java

rev 51700 : 8210031: implementation for JVM Constants API
117 lines changed: 117 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/MethodHandleDescTest.java

rev 51700 : 8210031: implementation for JVM Constants API
295 lines changed: 295 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/MethodTypeDescTest.java

rev 51700 : 8210031: implementation for JVM Constants API
248 lines changed: 248 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/SymbolicDescTest.java

rev 51700 : 8210031: implementation for JVM Constants API
111 lines changed: 111 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/TestHelpers.java

rev 51700 : 8210031: implementation for JVM Constants API
62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/TypeDescriptorTest.java

rev 51700 : 8210031: implementation for JVM Constants API
87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/boottest/TEST.properties

rev 51700 : 8210031: implementation for JVM Constants API
4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/boottest/java.base/java/lang/constant/ConstantUtilsTest.java

rev 51700 : 8210031: implementation for JVM Constants API
95 lines changed: 95 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/specialConstantFolding/DynamicConstantDescTest.java

rev 51700 : 8210031: implementation for JVM Constants API
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/vromero/work/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).