--- old/src/java.base/unix/classes/java/net/PlainSocketImpl.java 2017-11-23 14:42:32.848726755 +0530 +++ new/src/java.base/unix/classes/java/net/PlainSocketImpl.java 2017-11-23 14:42:32.708726480 +0530 @@ -69,9 +69,6 @@ } } } else { - if (getSocket() == null) { - throw new UnsupportedOperationException("unsupported option"); - } if (isClosedOrPending()) { throw new SocketException("Socket closed"); } @@ -92,9 +89,6 @@ } } } else { - if (getSocket() == null) { - throw new UnsupportedOperationException("unsupported option"); - } if (isClosedOrPending()) { throw new SocketException("Socket closed"); } @@ -104,12 +98,24 @@ protected Set> supportedOptions() { HashSet> options = new HashSet<>(super.supportedOptions()); - if (getSocket() != null) { - options.addAll(extendedOptions.options()); - } + addExtSocketOptions(extendedOptions.options(), options); return options; } + private void addExtSocketOptions(Set> extOptions, + Set> options) { + for (SocketOption option : extOptions) { + if (option.name().equals("SO_FLOW_SLA")) { + // SO_FLOW_SLA is Solaris specific option whis is not applicable + // for ServerSockets. + // getSocket() will always return null for server socket + if (getSocket() != null) { + options.add(option); + } + } + options.add(option); + } + } protected void socketSetOption(int opt, boolean b, Object val) throws SocketException { if (opt == SocketOptions.SO_REUSEPORT && !supportedOptions().contains(StandardSocketOptions.SO_REUSEPORT)) { --- /dev/null 2017-11-23 08:47:42.171999976 +0530 +++ new/test/jdk/jdk/net/Sockets/ExtOptionTest.java 2017-11-23 14:42:33.016727085 +0530 @@ -0,0 +1,67 @@ +/* + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + + /* + * @test + * @bug 8190843 + * @summary can not set/get extendedOptions to ServerSocket + * @modules jdk.net + * @run main ExtOptionTest + */ +import java.io.IOException; +import java.net.ServerSocket; + +import static jdk.net.ExtendedSocketOptions.TCP_QUICKACK; +import static jdk.net.ExtendedSocketOptions.SO_FLOW_SLA; + +public class ExtOptionTest { + + private static final String OS = "Linux"; + + public static void main(String args[]) throws IOException { + var operSys = System.getProperty("os.name"); + try (ServerSocket ss = new ServerSocket(0)) { + // currently TCP_QUICKACK is available only on Linux. + if (operSys.equals(OS)) { + ss.setOption(TCP_QUICKACK, true); + if (!ss.getOption(TCP_QUICKACK)) { + throw new RuntimeException("Test failed, TCP_QUICKACK should" + + " have been set"); + } + } else if (operSys.equals("SunOS")) { + if (ss.supportedOptions().contains(SO_FLOW_SLA)) { + throw new RuntimeException("Test failed, SO_FLOW_SLA is not " + + "applicate for ServerSocket"); + } + } else { + if (ss.supportedOptions().contains(TCP_QUICKACK)) { + ss.setOption(TCP_QUICKACK, true); + if (!ss.getOption(TCP_QUICKACK)) { + throw new RuntimeException("Test failed, TCP_QUICKACK should" + + " have been set"); + } + } + } + } + } +}